thermald: suppress systemd failure message when running in a VM

Bug #1480182 reported by Colin Ian King
28
This bug affects 3 people
Affects Status Importance Assigned to Milestone
thermald (Ubuntu)
Fix Released
Low
Colin Ian King
Trusty
Fix Released
Low
Colin Ian King
Vivid
Fix Released
Low
Colin Ian King
Wily
Fix Released
Low
Colin Ian King

Bug Description

With hardware that thermald cannot support, thermald exits(1) and we get a failure message in the systemd logs. Since this is a known "exit" status to indicate thermald can't support the H/W, we should add SuccessExitStatus=1 to systemd the [Service] section to suppress the "failure" message in systemd

Changed in thermald (Ubuntu):
importance: Undecided → Low
status: New → In Progress
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in thermald (Ubuntu Trusty):
status: New → Confirmed
Changed in thermald (Ubuntu Vivid):
status: New → Confirmed
Revision history for this message
Colin Ian King (colin-king) wrote :

[SRU Justification] (Vivid, Trusty)

Systems that thermald cannot support will see systemd failure messages on boot. This fix suppresses these messages.

[Test Case]
Boot machine, observe systemd logs. Without the fix systemd will complain that thermald has failed. With the fix, this message is no longer appearing.

[Regression Potential]
This fix is mainly cosmetic, so I can't think of any.

Changed in thermald (Ubuntu Trusty):
status: Confirmed → In Progress
Changed in thermald (Ubuntu Vivid):
status: Confirmed → In Progress
Changed in thermald (Ubuntu Trusty):
importance: Undecided → Low
Changed in thermald (Ubuntu Vivid):
importance: Undecided → Low
Changed in thermald (Ubuntu Trusty):
assignee: nobody → Colin Ian King (colin-king)
Changed in thermald (Ubuntu Vivid):
assignee: nobody → Colin Ian King (colin-king)
Revision history for this message
Chris J Arges (arges) wrote : Please test proposed package

Hello Colin, or anyone else affected,

Accepted thermald into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.4.3-3~14.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in thermald (Ubuntu Trusty):
status: In Progress → Fix Committed
tags: added: verification-needed
Revision history for this message
Chris J Arges (arges) wrote :

Hello Colin, or anyone else affected,

Accepted thermald into vivid-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/thermald/1.4.3-3~15.04.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in thermald (Ubuntu Vivid):
status: In Progress → Fix Committed
Revision history for this message
Colin Ian King (colin-king) wrote :

Verified on vivid-proposed in a VM

Revision history for this message
Colin Ian King (colin-king) wrote :

Verified on trusty-proposed in a VM too

tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 1.4.3-3~14.04.1

---------------
thermald (1.4.3-3~14.04.1) trusty; urgency=medium

  * Fix null pointer deferences with _ART active trip points (LP: #1480821)
  * Re-enable lockfile (LP: #1480892)
  * Report multiple instances of thermald with thd_log_fatal (LP: #1432220)
  * Suppress systemd failed service messages (e.g. on VMs) (LP: #1480182)

 -- Colin King <email address hidden> Tue, 4 Aug 2015 11:50:00 +0100

Changed in thermald (Ubuntu Trusty):
status: Fix Committed → Fix Released
Revision history for this message
Adam Conrad (adconrad) wrote : Update Released

The verification of the Stable Release Update for thermald has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package thermald - 1.4.3-3~15.04.1

---------------
thermald (1.4.3-3~15.04.1) vivid; urgency=medium

  * Fix null pointer deferences with _ART active trip points (LP: #1480821)
  * Re-enable lockfile (LP: #1480892)
  * Report multiple instances of thermald with thd_log_fatal (LP: #1432220)
  * Suppress systemd failed service messages (e.g. on VMs) (LP: #1480182)

 -- Colin King <email address hidden> Tue, 4 Aug 2015 11:48:00 +0100

Changed in thermald (Ubuntu Vivid):
status: Fix Committed → Fix Released
Changed in thermald (Ubuntu Wily):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers