Preferenes dialog issue

Bug #630364 reported by Ky6uk
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
testdrive (Ubuntu)
Wishlist
Unassigned

Bug Description

Binary package hint: testdrive-gtk

"Save" button are saving only active tab in preferences dialog with replacing previous ~/.testdriverc.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: testdrive-gtk 3.0-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.35-19.28-generic 2.6.35.3
Uname: Linux 2.6.35-19-generic i686
NonfreeKernelModules: nvidia
Architecture: i386
Date: Sun Sep 5 00:14:51 2010
InstallationMedia: Kubuntu 10.10 "Maverick Meerkat" - Alpha i386 (20100630.1)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=ru_RU
 LANG=ru_RU.utf8
 SHELL=/bin/bash
SourcePackage: testdrive

Revision history for this message
Ky6uk (ky6uk) wrote :
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi Ky6uk,

Thank you for reporting bugs. Now let me understand a little bit more of what this is about.

What do you mean with "Saving only active tab". For what I understand, is that if you make changes in "General" tab and then click on "Save", the preferences dialog closes. Is that what's happening?

Now, the preferences "Save" buttons saves only the preferences that have been modified and that are different from default values. On the other hand, if we Modify preferences on the "General tab", and then switch to the "Virtualization tab" and we also make modifications, when "Save" is clicked, the preferences from both tabs are gonna be saved. This is the desired behavior.

Changed in testdrive (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Ky6uk (ky6uk) wrote :

If I change settings on first tab and then press "save" button - saving only settings on this first tab.
If I change settings on first tab, then change on secondary tab and save it - saved only settings on current active tab and reset all previously settings.

Sorry for my english. :)

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Try this:

Go to preferences "General" tab:

 - Repository should be: cdimage
 - Release: Lucid

Now, go to "Virtualization" tab:

 - Change Memory to: 512 MB

Then click "Save", and $HOME/.testdriverc should look like:

 [testdrive-gtk]
mem = 512
p = cdimage
r = lucid
f = ubuntu, kubuntu, xubuntu

Now, this means that changes on "General" tab are kept if we "Save" from "Virtualization" tab, which is correct.

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Now, I've just noticed if we rerun testdrive with changes related to "General", and we go to "Virtualization" tab, and we make changes, those previously made changes on "General" tab are overwritten.

If this is what you mean, yes there's a bug :).

Revision history for this message
Ky6uk (ky6uk) wrote :

Yes, I mean it. :)

Revision history for this message
Andres Rodriguez (andreserl) wrote :

Ok then.

Thank you for finding it. I'll fix it in the next release :)

Changed in testdrive (Ubuntu):
assignee: nobody → Andres Rodriguez (andreserl)
importance: Low → Wishlist
status: Triaged → Confirmed
Changed in testdrive (Ubuntu):
status: Confirmed → In Progress
Changed in testdrive (Ubuntu):
status: In Progress → Fix Committed
assignee: Andres Rodriguez (andreserl) → nobody
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package testdrive - 3.1-0ubuntu1

---------------
testdrive (3.1-0ubuntu1) natty; urgency=low

  * UI Improvements. Thanks to Andrew (and471).
  * testdrive-cli: Add support to change ISO image repository.
  * Support for UEC Images: (LP: #619974)
    - testdrive-cli: Added initial support.
  * Improve the way the downloading widget is displayed. (LP: #618166)
  * testdrive-gtk: Fix preferences dialog issue. (LP: #630364)
  * testdrive/testdrive.py: Fix loading of CACHE_ISO if changed.
  * Allow Mobile ISO's to be TestDrived. (LP: #645052)
  * Fix some identation issues that appeared with new quickly version, and
    some minor cleanups.
 -- Andres Rodriguez <email address hidden> Wed, 20 Oct 2010 16:41:15 -0400

Changed in testdrive (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers