TypeError /usr/bin/testdrive when downloading using HTTP

Bug #602585 reported by Severin Heiniger on 2010-07-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
testdrive (Ubuntu)
Medium
Unassigned

Bug Description

Binary package hint: testdrive

When testdrives downloads an ISO using HTTP (like http://releases.ubuntu.com/9.10/ubuntu-9.10-desktop-amd64.iso), it will crash after the successful download with the following traceback:

Traceback (most recent call last):
  File "/usr/bin/testdrive", line 366, in <module>
    main()
  File "/usr/bin/testdrive", line 314, in main
    run_or_die(cmd)
  File "/usr/bin/testdrive", line 103, in run_or_die
    if run(cmd) != 0:
  File "/usr/bin/testdrive", line 100, in run
    return(os.system(cmd))
TypeError: system() argument 1 must be string, not None

The reason is that TestDrive.get_proto returns None when the download using zsync succeeded, rather than 0 (which indicates success). It looks to me as if a 'return 0' statement is missing on line 224 of testdrive.py.

After some investigation, I noticed that there might be another underlying problem. When adding 'return 0', testdrive continues with the following output:

Creating disk image [/home/lantash/.cache/testdrive/img/testdrive-disk-1py09v.img]...
Formatting '/home/lantash/.cache/testdrive/img/testdrive-disk-1py09v.img', fmt=qcow2 size=6442450944 encryption=off cluster_size=0
INFO: Launching Virtual Machine...
Running the Virtual Machine...
qemu: could not open disk image /home/lantash/.cache/testdrive/iso/other_ubuntu-9.10-desktop-amd64.iso: No such file or directory

The prefix other_ should not have been added.

ProblemType: Bug
DistroRelease: Ubuntu 10.10
Package: testdrive 2.4-0ubuntu1
ProcVersionSignature: Ubuntu 2.6.35-6.9-generic 2.6.35-rc3
Uname: Linux 2.6.35-6-generic x86_64
Architecture: amd64
Date: Wed Jul 7 10:03:53 2010
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Alpha amd64 (20100624)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en
 LANG=de_CH.utf8
 SHELL=/bin/bash
SourcePackage: testdrive

Severin Heiniger (severinh) wrote :
tags: removed: ubuntu-une
description: updated
Changed in testdrive (Ubuntu):
importance: Undecided → Medium
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package testdrive - 2.5-0ubuntu1

---------------
testdrive (2.5-0ubuntu1) maverick; urgency=low

  [ Andres Rodriguez ]
  * testdrive.py: Update ISO manifest every 12hrs instead of every 24hrs.
  * virt/{virtualbox,parallels}.py, testdrive: Changes to support
    threading in GTK Frontend for VirtualBox and Parallels.
  * Fix launch error when downloading with zsync. (LP: #602585)
  * Changed the way to obtain the protocol for synchronization.
  * Re-add ISO verification in URL, while improving protocol determination.

  [ Dustin Kirkland ]
  * testdriverc: change kvm default video mode from vmware back to cirrus;
    need to document that vmware video mode will provide more resolutions,
    but cirrus is faster and more responsive
 -- Andres Rodriguez <email address hidden> Sun, 11 Jul 2010 16:24:04 -0400

Changed in testdrive (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers