[Infographic] Duplicate metrics for no calls made today

Bug #1450988 reported by David Planella
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu UX
Won't Fix
Medium
Grazina
telephony-service (Ubuntu)
New
Undecided
Unassigned

Bug Description

I noticed that when tapping on the welcome screen, the metrics for "No calls made today"" were shown twice. That is:

1. Tap on the circle until you see "No calls made today""
2. Double tap again

Actual:
 - The same "No calls made today"" text is shown, but with a different diagram

Expected:
- "No time spent on calls today" (or similar) is shown

I think it just needs a one-liner change on this code in indicator/metrics.cpp [1]. I would suggest "No time spent on calls today" on the second instance.

This will also need a .pot file update to expose the new string to translators.

        mMetrics[OutgoingCalls] = mMetricManager->add(MetricParameters(DIALER_OUTGOING_STATISTICS_ID).formatString(GettextMarkExtraction("<b>%1</b> calls made today"))
                                                      .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));
        mMetrics[CallDurations] = mMetricManager->add(MetricParameters(DIALER_CALL_DURATION_STATISTICS_ID).formatString(GettextMarkExtraction("Spent <b>%1</b> minutes in calls today"))
                                                      .emptyDataString(GettextMarkExtraction("No calls made today")).textDomain(APP_ID).minimum(0.0));

[1] http://bazaar.launchpad.net/~phablet-team/telephony-service/trunk/view/head:/indicator/metrics.cpp#L48

- Design comment -
  05/08/2015

It can't be fixed as a single bug. The desired resolution and specs will be updated as soon as they are available. https://canonical.leankit.com/Boards/View/109386535/113890502

Related branches

Revision history for this message
Sebastien Bacher (seb128) wrote :

Listing ubuntu-ux as well, design might want to validate the string

Changed in ubuntu-ux:
status: New → Triaged
assignee: nobody → Olga Kemmet (olga-kemmet)
Changed in ubuntu-ux:
assignee: Olga Kemmet (olga-kemmet) → nobody
assignee: nobody → Andreea Pirvu (andreea-pirvu)
summary: - Duplicate metrics for no calls made today
+ [Greeter] Duplicate metrics for no calls made today
Changed in ubuntu-ux:
importance: Undecided → Medium
assignee: Andreea Pirvu (andreea-pirvu) → Benjamin Keyser (bjkeyser)
John Lea (johnlea)
summary: - [Greeter] Duplicate metrics for no calls made today
+ [Infographic] Duplicate metrics for no calls made today
Revision history for this message
David Planella (dpm) wrote :

I feel we've spent more time triaging and changing the status of this bug than actually solving it. The change should not be more than a line of text, so what about using the following messages:

- "No calls made today"
- "No time spent on calls today"

Changed in ubuntu-ux:
assignee: Benjamin Keyser (bjkeyser) → Grazina (boroskograzina)
Revision history for this message
Grazina (boroskograzina) wrote :

- Design comment -
  05/08/2015

It can't be fixed as a single bug. The desired resolution and specs will be updated as soon as they are available. https://canonical.leankit.com/Boards/View/109386535/113890502

description: updated
Changed in ubuntu-ux:
status: Triaged → Won't Fix
Grazina (boroskograzina)
description: updated
Revision history for this message
David Planella (dpm) wrote :

Could you please provide more context on why it cannot be fixed as a single bug?

Currently, the link to the leankit board takes me to a page I cannot access (and I suspect none of the other subscribers can). Would you mind explaining the solution in writing as a comment in the bug? Thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.