telepathy-butterfly crashed with NameError in on_conversation_nudge_received()

[K. Aning]

Binary package hint: telepathy-butterfly

Apparently I was nudged by someone on MSN

ProblemType: Crash
Architecture: i386
DistroRelease: Ubuntu 8.10
ExecutablePath: /usr/lib/telepathy/telepathy-butterfly
InterpreterPath: /usr/bin/python2.5
Package: telepathy-butterfly 0.3.2-1
PackageArchitecture: all
ProcAttrCurrent: unconfined
ProcCmdline: /usr/bin/python /usr/lib/telepathy/telepathy-butterfly
ProcEnviron:
 SHELL=/bin/bash
 PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
 LANG=en_GB.UTF-8
PythonArgs: ['/usr/lib/telepathy/telepathy-butterfly']
SourcePackage: telepathy-butterfly
Title: telepathy-butterfly crashed with NameError in on_conversation_nudge_received()
Uname: Linux 2.6.27-4-generic i686
UserGroups: adm admin audio cdrom dialout dip floppy fuse lpadmin plugdev video

[Olivier Le Thanh Duong (olethanh)]

This bug was originally reported by K. Aning on Launchpad (see URL).

"Apparently I was nudged by someone on MSN"

Traceback (most recent call last):
  File "/usr/lib/python2.5/site-packages/pymsn/switchboard_manager.py", line 365, in _sb_message_received
    handler._on_message_received(message)
  File "/usr/lib/python2.5/site-packages/pymsn/conversation.py", line 374, in _on_message_received
    self._dispatch("on_conversation_nudge_received", sender)
  File "/usr/lib/python2.5/site-packages/pymsn/event/__init__.py", line 44, in _dispatch
    if event_handler._dispatch_event(name, *args):
  File "/usr/lib/python2.5/site-packages/pymsn/event/__init__.py", line 65, in _dispatch_event
    handler(*params)
  File "/usr/lib/python2.5/site-packages/butterfly/channel/text.py", line 121, in on_conversation_nudge_received
    text = unicode(_("sends you a nudge"), "utf-8")
NameError: global name '_' is not defined

Dev note :
I don't even know why we are passing it to _() since we don't use gettext at all. Easy fix

[Olivier Le Thanh Duong (olethanh)]

Thanks for your bug report. It's still present in telepathy-butterfly so I will forward it upstream

[Guillaume-desmottes (guillaume-desmottes)]

CM are not supposed to contain translatable strings.

[Nicolò Chieffo (yelo3)]

Created an attachment (id=27186)
nudge.patch

if so it's a simple patch

[Nicolò Chieffo (yelo3)]

this patch fixes it, I've also forwarded it upstream

[Olivier Le Thanh Duong (olethanh)]

Thanks for your patch Nicolò, it has been merged in master

[Olivier Le Thanh Duong (olethanh)]

Merged upstream in master, thanks Nicolò

[Olivier Le Thanh Duong (olethanh)]

Fixed in telepathy-butterfly 0.5.1