/etc/csh.login fails when ls command aliased

Bug #70763 reported by Hadmut Danisch
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
tcsh (Debian)
Fix Released
Unknown
tcsh (Ubuntu)
High
Unassigned

Bug Description

Binary package hint: tcsh

Hi,

/etc/csh.login is just a simple script which reads all files from /etc/csh/login.d, but actually the script is poorly written.

When - as usual - the ls command is aliased to the internal ls-F command, and the directory contains a link, that script fails, since ls-F appends a @ to the filename. Similar problem for executable files ( *-suffix).

regards
Hadmut

Revision history for this message
Hadmut Danisch (hadmut) wrote :

...and btw calling files without absolute paths is dangerous here.

If at all necessary to call ls, then call /bin/ls

Revision history for this message
Lionel Le Folgoc (mrpouit) wrote :

Thank you for taking the time to report this bug and helping to make Ubuntu better. You reported this bug a while ago and there hasn't been any activity in it recently. We were wondering is this still an issue for you? Thanks in advance.

Changed in tcsh:
status: New → Incomplete
Revision history for this message
Ryan Kavanagh (ryanakca) wrote :

We are closing this bug report because it lacks the information we need to investigate the problem, as described in the previous comments. Please reopen it if you can give us the missing information, and don't hesitate to submit bug reports in the future. To reopen the bug report you can click on the current status, under the Status column, and change the Status back to "New". Thanks again!

Changed in tcsh:
status: Incomplete → Invalid
Revision history for this message
Ryan Daly (daly-ctcnet) wrote :

I can confirm this bug. The script is still poorly written in Intrepid.

Changed in tcsh:
status: Invalid → Confirmed
Revision history for this message
Dimitrios Symeonidis (azimout) wrote :

Still an issue in Karmic, because the version is stuck at 6.14 since dapper!!!
Meanwhile, upstream is at 6.17 and the issue seems fixed there (as far as I can tell):
see the file 'cygwin/csh.login' in the source code...

Changed in tcsh (Ubuntu):
importance: Undecided → High
Revision history for this message
Lucas Nussbaum (lucas) wrote :

Could someone propose a patch?

Revision history for this message
DouglasPhillips (doug-sbscomp) wrote :

Looking at a git clone of the tcsh package from the debian upstream, the problem exists there too.

Here's a patch against the upstream file; could be just as easily applied to the ubuntu package as well. The patch also fixes the security issue raised by not calling ls by a complete path.

tags: added: patch
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package tcsh - 6.17.02-4ubuntu1

---------------
tcsh (6.17.02-4ubuntu1) natty; urgency=low

  * debian/csh.login:
    - Apply patch by Douglas Phillips to use full path for ls, fixing
      the script for people with an aliased ls. LP: #70763
 -- Michael Terry <email address hidden> Wed, 22 Dec 2010 13:28:20 -0500

Changed in tcsh (Ubuntu):
status: Confirmed → Fix Released
Changed in tcsh (Debian):
status: Unknown → New
Changed in tcsh (Debian):
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.