hwdb: Mask rfkill event from intel-hid on HP platforms

Bug #1883846 reported by Kai-Heng Feng on 2020-06-17
18
This bug affects 1 person
Affects Status Importance Assigned to Milestone
HWE Next
Undecided
Unassigned
OEM Priority Project
Critical
hugh chao
systemd (Ubuntu)
Status tracked in Groovy
Focal
Medium
Dan Streetman
Groovy
Undecided
Unassigned

Bug Description

[Impact]
Press wireless hotkey on HP's latest generation laptops generate two rfkill events, prevent airplane mode from turning off.

One event is from intel-hid and the other one is from hp-wireless.

[Fix]
Commit "hwdb: Mask rfkill event from intel-hid on HP platforms", to only use rfkill from hp-wireless.

[Test]
With the one-liner fix, press wireless hotkey only generate one rfkill event, hence airplane mode works as expected.

[Regression Potential]
Low, use hp-wireless over intel-hid is anticipated.

any regression would likely result in missed rfkill events.

[scope]

this is fixed upstream by commit d8a9dd0dc17df77229d079afe29c05ae4a9e2ae9 which is not included in any version yet, so this is needed for f and g.

@kaihengfeng is this needed on b and/or x as well?

tags: added: oem-priority originate-from-1882924 stella
Balint Reczey (rbalint) wrote :

I've committed the cherry-picked change to systemd's packaging repo and it will be available in the next upload, probably in 2-3 weeks.

Changed in systemd (Ubuntu Groovy):
status: New → Fix Committed
Dan Streetman (ddstreet) on 2020-06-30
Changed in systemd (Ubuntu Focal):
assignee: nobody → Dan Streetman (ddstreet)
importance: Undecided → Medium
status: New → In Progress
Chih-Hsyuan Ho (chih) wrote :

@Dan, is it possible for you to speed up the SRU process for this fix please? We have an OEM platform which is being blocked by this issue and we are targeting mid-July for its final image. Thank you.

Chih-Hsyuan Ho (chih) wrote :

@Dan, can you let us know when we can expect the SRU progress to Focal to complete please?

Dan Streetman (ddstreet) wrote :

@chih sorry for the delay, i'll be uploading today.

Balint Reczey (rbalint) wrote :

I'm also uploading to Groovy so the SRU can be accepted according to the process.

Dan Streetman (ddstreet) on 2020-07-06
description: updated
Kai-Heng Feng (kaihengfeng) wrote :

I think we can skip B/X, I haven't seen any wireless hotkey bug report for these two series.

Chih-Hsyuan Ho (chih) wrote :

@Dan, can you let us know when we can expect the fix to land on Focal please?

Dan Streetman (ddstreet) wrote :

@chih it's uploaded, at this point it's waiting for review by the ~ubuntu-sru team. Out of my hands now.

Chih-Hsyuan Ho (chih) wrote :

@Dan, got it. Will ping the team for help. Thanks again.

Rex Tsai (chihchun) on 2020-07-14
Changed in oem-priority:
importance: Undecided → Critical
assignee: nobody → hugh chao (hugh712)
hugh chao (hugh712) on 2020-07-14
Changed in oem-priority:
status: New → Confirmed
hugh chao (hugh712) on 2020-07-14
tags: added: verification-needed-focal
tags: added: verification-needed
hugh chao (hugh712) on 2020-07-14
tags: removed: verification-needed verification-needed-focal
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd - 245.6-2ubuntu1

---------------
systemd (245.6-2ubuntu1) groovy; urgency=medium

  * Merge to Ubuntu from Debian unstable
    - Dropped changes:
      * dhclient-exit-hooks.d/timesyncd: Act only when systemd-timesyncd is enabled
  * hwdb: Mask rfkill event from intel-hid on HP platforms (LP: #1883846)
    File: debian/patches/hwdb-Mask-rfkill-event-from-intel-hid-on-HP-platforms.patch
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=c705323d61b9cd4e36ceb92e236cd6e9ba4c1b1a
  * debian/tests/tests-in-lxd: Show debugging info about reason of skipping test
    File: debian/tests/tests-in-lxd
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=1c835ca2d4f6d09977525d781d224a87ba7cde24
  * debian/tests/tests-in-lxd: Drop workaround removing fstab from the container
    (LP: #1886430)
    File: debian/tests/tests-in-lxd
    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=f13213af98fa4c27c5f7e58c511b9691bb56065a

 -- Balint Reczey <email address hidden> Mon, 06 Jul 2020 16:30:25 +0200

Changed in systemd (Ubuntu Groovy):
status: Fix Committed → Fix Released

Hello Kai-Heng, or anyone else affected,

Accepted systemd into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/systemd/245.4-4ubuntu3.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in systemd (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-focal
Kai-Heng Feng (kaihengfeng) wrote :

Verification done by the following steps:
1. Enable -proposed pocket and upgrade.
2. Press airplane mode hotkey. Airplane mode is enabled correctly.
3. Press the hotkey again. Airplane mode is disabled correctly.

tags: added: verification-done verification-done-focal
removed: verification-needed verification-needed-focal

All autopkgtests for the newly accepted systemd (245.4-4ubuntu3.2) for focal have finished running.
The following regressions have been reported in tests triggered by the package:

apt/unknown (armhf)
indicator-session/17.3.20+19.10.20190921-0ubuntu1 (arm64)
dovecot/1:2.3.7.2-1ubuntu3.1 (armhf)
postgresql-12/unknown (armhf)
mir/unknown (armhf)
systemd/245.4-4ubuntu3.2 (amd64)
umockdev/unknown (armhf)
policykit-1/unknown (armhf)
asterisk/unknown (armhf)
anbox/unknown (armhf)
php7.4/unknown (armhf)
ksystemlog/unknown (armhf)
polkit-qt-1/unknown (armhf)

Please visit the excuses page listed below and investigate the failures, proceeding afterwards as per the StableReleaseUpdates policy regarding autopkgtest regressions [1].

https://people.canonical.com/~ubuntu-archive/proposed-migration/focal/update_excuses.html#systemd

[1] https://wiki.ubuntu.com/StableReleaseUpdates#Autopkgtest_Regressions

Thank you!

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package systemd - 245.4-4ubuntu3.2

---------------
systemd (245.4-4ubuntu3.2) focal; urgency=medium

   [ Dan Streetman ]
   * Hotadd only offline memory and CPUs (LP: #1876018)
     File: debian/extra/rules-ubuntu/40-vm-hotadd.rules
     https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=72d815471596056b7727be5b10f87513ff1d5757
   * Lock swap blockdevice while calling mkswap (LP: #1838329)
     Files:
     - d/p/lp1838329/0001-blockdev-propagate-one-more-unexpected-error.patch
     - d/p/lp1838329/0002-makefs-log-about-OOM-condition.patch
     - d/p/lp1838329/0003-dissect-use-log_debug_errno-where-appropriate.patch
     - d/p/lp1838329/0004-blockdev-add-helper-for-locking-whole-block-device.patch
     - d/p/lp1838329/0005-makefs-lock-device-while-we-operate.patch
     - d/p/lp1838329/0006-makefs-normalize-logging-a-bit.patch
     - d/p/lp1838329/0007-cryptsetup-generator-use-systemd-makefs-for-implemen.patch
     https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=c81b75c4297cbb04554488b070b6f79996b8cceb

   [ Balint Reczey ]
   * debian/udev.postinst: Allow kvm to be an already present non-system group
     (LP: #1880541)
     File: debian/udev.postinst
     https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=8b5c31828d4323ddb719326b1316c179b7cdbdef
   * d/p/hwdb-Mask-rfkill-event-from-intel-hid-on-HP-platforms.patch:
     hwdb: Mask rfkill event from intel-hid on HP platforms
     (LP: #1883846)
     https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=164c016b466210c7d6d05963fd753eccf4679844
   * journald: stream pid change newline fix (LP: #1875708)
     Files:
     - debian/patches/lp1875708/journald-Increase-stdout-buffer-size-sooner-when-almost-f.patch
     - debian/patches/lp1875708/journald-rework-end-of-line-marker-handling-to-use-a-fiel.patch
     - debian/patches/lp1875708/journald-rework-pid-change-handling.patch
     - debian/patches/lp1875708/journald-use-log_warning_errno-where-appropriate.patch
     - debian/patches/lp1875708/journald-use-the-fact-that-client_context_release-returns.patch
     - debian/patches/lp1875708/man-document-the-new-_LINE_BREAK-type.patch
     - debian/patches/lp1875708/socket-util-introduce-type-safe-dereferencing-wrapper-CMS.patch
     - debian/patches/lp1875708/test-Add-a-test-case-for-15654.patch
     https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=2dc19f7ae4aad7277e9d89849182453ff1d046dc

 -- Dan Streetman <email address hidden> Mon, 06 Jul 2020 17:38:31 -0400

Changed in systemd (Ubuntu Focal):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for systemd has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

hugh chao (hugh712) on 2020-07-24
Changed in oem-priority:
status: Confirmed → Fix Committed
Changed in hwe-next:
status: New → Fix Released
hugh chao (hugh712) on 2020-07-24
Changed in oem-priority:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers