autopkgtest regression TEST-22-TMPFILES are not executable
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| systemd (Ubuntu) |
Undecided
|
Unassigned | ||
| Bionic |
Undecided
|
Unassigned | ||
| Cosmic |
Undecided
|
Unassigned |
Bug Description
[Impact]
* Newly added testcase in a security upload used a traditional GNU patch format, instead of using extended git patch format, as supported by GNU patch. Therefore, executable bits on shells scripts were lost, resulting in autopkgtest failures.
[Test Case]
* `upstream` test/TEST-
[Regression Potential]
* This is testcode change only.
CVE References
summary: |
- autopkgtest regression TEST-22-TMPFILES are note executable + autopkgtest regression TEST-22-TMPFILES are not executable |
Launchpad Janitor (janitor) wrote : | #2 |
This bug was fixed in the package systemd - 239-7ubuntu14
---------------
systemd (239-7ubuntu14) disco; urgency=medium
* Fix compat with new meson.
File: debian/
https:/
-- Dimitri John Ledkov <email address hidden> Thu, 29 Nov 2018 16:53:00 +0000
Changed in systemd (Ubuntu): | |
status: | Triaged → Fix Released |
Changed in systemd (Ubuntu Cosmic): | |
status: | New → In Progress |
Hello Dimitri, or anyone else affected,
Accepted systemd into cosmic-proposed. The package will build now and be available at https:/
Please help us by testing this new package. See https:/
If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-
Further information regarding the verification process can be found at https:/
N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.
Changed in systemd (Ubuntu Cosmic): | |
status: | In Progress → Fix Committed |
tags: | added: verification-needed verification-needed-cosmic |
Dimitri John Ledkov (xnox) wrote : | #4 |
========== TEST-22-TMPFILES ==========
make: Entering directory '/tmp/autopkgte
TEST CLEANUP: Tmpfiles related tests
TEST SETUP: Tmpfiles related tests
...
TEST RUN: Tmpfiles related tests
...
TEST RUN: Tmpfiles related tests [OK]
make: Leaving directory '/tmp/autopkgte
autopkgtest [02:14:17]: test upstream: -------
upstream PASS
the test case succeeds, and thus has the right executable permission.
tags: |
added: verification-done verification-done-cosmic removed: verification-needed verification-needed-cosmic |
Launchpad Janitor (janitor) wrote : | #5 |
This bug was fixed in the package systemd - 237-3ubuntu10.11
---------------
systemd (237-3ubuntu10.11) bionic-security; urgency=medium
* SECURITY UPDATE: memory corruption in journald via attacker controlled alloca
- debian/
entry for process commandline on the stack
- CVE-2018-16864
* SECURITY UPDATE: memory corruption in journald via attacker controlled alloca
- debian/
number of fields (1k)
- debian/
number of fields in a message
- CVE-2018-16865
* SECURITY UPDATE: out-of-bounds read in journald
- debian/
- CVE-2018-16866
* Fix LP: #1804603 - btrfs-util: unbreak tmpfiles' subvol creation
- add debian/
- update debian/
* Fix LP: #1804864 - test: Set executable bits on TEST-22-TMPFILES shell scripts
- add debian/
- update debian/
-- Chris Coulson <email address hidden> Wed, 09 Jan 2019 15:11:53 +0000
Changed in systemd (Ubuntu Bionic): | |
status: | New → Fix Released |
Launchpad Janitor (janitor) wrote : | #6 |
This bug was fixed in the package systemd - 239-7ubuntu10.6
---------------
systemd (239-7ubuntu10.6) cosmic-security; urgency=medium
* SECURITY UPDATE: memory corruption in journald via attacker controlled alloca
- debian/
entry for process commandline on the stack
- CVE-2018-16864
* SECURITY UPDATE: memory corruption in journald via attacker controlled alloca
- debian/
number of fields (1k)
- debian/
number of fields in a message
- CVE-2018-16865
* SECURITY UPDATE: out-of-bounds read in journald
- debian/
- CVE-2018-16866
* Fix LP: #1804603 - btrfs-util: unbreak tmpfiles' subvol creation
- add debian/
- update debian/
* Fix LP: #1804864 - test: Set executable bits on TEST-22-TMPFILES shell scripts
- add debian/
- update debian/
-- Chris Coulson <email address hidden> Wed, 09 Jan 2019 14:37:15 +0000
Changed in systemd (Ubuntu Cosmic): | |
status: | Fix Committed → Fix Released |
This bug was supposed to be fixed on bionic with systemd (237-3ubuntu10.11) but it's still failing:
========== TEST-22-TMPFILES ==========
make: Entering directory '/tmp/autopkgte
/bin/sh: 1: ./test.sh: Permission denied
make: *** [clean] Error 126
Makefile:4: recipe for target 'clean' failed
make: Leaving directory '/tmp/autopkgte
While running ADT tests with the new systemd packages on both Bionic and Cosmic we get the following error on the src pkg install phase:
dpkg-source: warning: diff 'src/debian/
Looking back at the log history of the tests, the testcase never failed on Cosmic. An example is this test result with systemd 239-7ubuntu9:
https:/
And as I stated on my previous comment, the test is still failing on Bionic. So it seems that the fix proposed for this issue is not taking any effect.
Dimitri John Ledkov (xnox) wrote : | #9 |
The warning is always there, but the permissions are correctly applied in cosmic+
So for bionic we will need a chmod +x added in the debian/
FYI for others checking for current known test issues like me - this is in systemd/ 239-7ubuntu12 currently in -proposed
Due to that I'd think this must at least be triaged as there is this changelog entry: patches/ test-Set- executable- bits-on- TEST-22- TMPFILES- shell-script. patch /git.launchpad. net/~ubuntu- core-dev/ ubuntu/ +source/ systemd/ commit/ ?id=0e5b6e44a96 2f299565949e100 6a4ba86d171dc3
* test: Set executable bits on TEST-22-TMPFILES shell scripts. (LP: #1804864)
File: debian/
https:/