udev-generated /dev/disk/by-path names broken for virtio disks

Bug #1623003 reported by bugproxy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu on IBM z Systems
Fix Released
Wishlist
Dimitri John Ledkov
systemd
Fix Released
Unknown
systemd (Ubuntu)
Fix Released
Wishlist
Dimitri John Ledkov

Bug Description

The udev-generated /dev/disk/by-path names for virtio disks are broken on z Systems as they have the format virtio-pci-h.h.hhhh[-partn], where h.h.hhhh is the CCW devno of the virtio device representing the whole disk. Historically, the standard CCW naming was applied, which was ccw-h.h.hhhh[-partn]

---uname output---
Linux ubuntu 4.4.0-36-generic #55-Ubuntu SMP Thu Aug 11 18:05:09 UTC 2016 s390x s390x s390x GNU/Linux

Machine Type = 2964-703 running KVM for IBM z Systems

---Debugger---
A debugger is not configured

---Steps to Reproduce---
1. Install Ubuntu LTS 16.04.1 on KVM for IBM z Systems 1.1.1
2. Issue ls -l /dev/disk/by-path

Userspace tool common name: udev

The userspace tool has the following bit modes: 64-bit

Userspace rpm: udev

Userspace tool obtained from project website: na

There are basically two problems with this:
1. The naming is technically incorrect, since the virtio devices on z are no PCI devices but CCW devices
2. Then naming based on virtio- is backwards incompatible. This may seem not to be an issue for Xenial but customers may be confused if they have been running Linux on KVM for IBM z before.

bugproxy (bugproxy)
tags: added: architecture-s39064 bugnameltc-146190 severity-high targetmilestone-inin---
Changed in ubuntu:
assignee: nobody → Skipper Bug Screeners (skipper-screen-team)
affects: ubuntu → udev-discover (Ubuntu)
affects: udev-discover (Ubuntu) → udev (Ubuntu)
bugproxy (bugproxy)
tags: added: targetmilestone-inin16041
removed: targetmilestone-inin---
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
importance: Undecided → Medium
assignee: nobody → Dimitri John Ledkov (xnox)
bugproxy (bugproxy)
tags: removed: bugnameltc-146190 severity-high
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Userspace rpm: udev
... Ubuntu does not use RPMs, do you mean .deb or just package?

Note the bugs are tracked by source package name, which is systemd.

This change was introduced upstream in v229 see:
https://github.com/systemd/systemd/blob/master/NEWS

https://github.com/systemd/systemd/commit/f073b1b3c0f4f0df1b0bd61042ce85fb5d27d407

https://lists.linuxfoundation.org/pipermail/virtualization/2015-August/030328.html

https://github.com/systemd/systemd/issues/2501

Please discuss this upstream to change/improve the path_id detection. This is not ubuntu-specific and affects all Linux on z that use systemd v229 or newer.

If a fix for this lands upstream, we can discuss cherrypicking it to xenial.

Changed in udev (Ubuntu):
status: New → Invalid
affects: udev (Ubuntu) → systemd (Ubuntu)
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: New → Invalid
bugproxy (bugproxy)
tags: added: bugnameltc-146190 severity-high
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Hi,
this bug report is marked invalid in Ubuntu, and severity-high has no affect.

Please report this issue upstream at https://github.com/systemd/systemd as it affects all Linux on z distributions (or will when they upgrade to the relevant systemd version)..

Do you have a url to a github issue you have opened?

Regards,

Dimitri.

Revision history for this message
bugproxy (bugproxy) wrote : Comment bridged from LTC Bugzilla

------- Comment From <email address hidden> 2017-03-02 04:56 EDT-------
The upstream commit [1] fixes the issue for virtio-ccw and will retain the compatibility symlinks for virtio-pci devices. The commit applies to systemd-229 and later versions.

[1] https://github.com/systemd/systemd/commit/fb92fbb1b171ef94207a1ebc111ef0e414d49b4c

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Thanks! Targeting for this month.

Changed in systemd (Ubuntu):
status: Invalid → Confirmed
importance: Undecided → Wishlist
assignee: Skipper Bug Screeners (skipper-screen-team) → Dimitri John Ledkov (xnox)
milestone: none → ubuntu-17.03
Changed in ubuntu-z-systems:
status: Invalid → Confirmed
importance: Medium → Wishlist
Changed in systemd (Ubuntu):
status: Confirmed → Fix Committed
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: Confirmed → Fix Committed
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Was not mentioned in debian/changelog but this is part of v233 release and thus is fix released in artful, and is present in the below mentioned uploads:
ubuntu/233-5ubuntu1
ubuntu/233-6ubuntu1
ubuntu/233-6ubuntu2
ubuntu/233-6ubuntu3
ubuntu/233-8ubuntu1
ubuntu/233-8ubuntu2

Changed in systemd (Ubuntu):
status: Fix Committed → Fix Released
Frank Heimes (fheimes)
Changed in ubuntu-z-systems:
status: Fix Committed → Fix Released
Revision history for this message
bugproxy (bugproxy) wrote :

------- Comment From <email address hidden> 2017-11-16 11:01 EDT-------
IBM Bugzilla Status-> closed. fixed with systemd 233 which is included with Ubuntu 17.10.

tags: added: targetmilestone-inin1710
removed: targetmilestone-inin16041
Changed in systemd:
status: Unknown → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.