[shares-admin] creates multiple repeat entries in smb.conf when the folder name contains a '$'

[Robert Schumann]

Using Ubuntu Breezy, although this problem was also observed under Hoary. Using gnome-system-tools 1.4.0-0ubuntu10

When using the graphical tool for administering Samba shares (/usr/bin/shares-admin in the g-s-t package), a whole series of blank entries corresponding to one entry is made.

Steps to repeat:
1. "sudo mv /etc/samba/smb.conf /etc/samba/smb.conf.OLD", to ensure that we're starting from scratch (see * below)
2. Start up shares-admin, either from the command line or via System > Administration > Shared Folders
3. Add a new Samba share. I added a hidden name "folder$" and a comment and ticked the browseable and read-only buttons.
4. Close shares-admin.
5. Inspect /etc/samba/smb.conf, which will now have multiple entries for share "folder$". (see # below)
6. If you restart shares-admin, you will see multiple (I get 9) blank entries. Not very helpful.

(*) Yes, you're not supposed to just delete package files. I guess this also work if you have a fresh install of samba-common, i.e. "sudo apt-get --purge remove samba-common && sudo rm /etc/samba/smb.conf; sudo apt-get install samba-common" or something like that. I'm not sure of the dependencies in samba and this command has not been tested.

(#) After the shares-admin, my smb.conf reads:

[global]
wins support = no

[folder$]
path = /home/rewley/folder

[folder$]
comment = a folder

[folder$]
available = yes

[folder$]
browseable = yes

[folder$]
public = yes

[folder$]
writable = no

[folder$]

[folder$]

[folder$]

[Daniel Holbach (dholbach)]

Thanks for your bug report. I forwarded the issue to the upstream bug tracker: http://bugzilla.gnome.org/show_bug.cgi?id=325495

[Sebastien Bacher (seb128)]

Happens on edgy too when the folder name contains a '$', do you have example of such issue without a name with that char?

[Sebastien Bacher (seb128)]

The bug has been fixed upstream

[Sebastien Bacher (seb128)]

This upload fixes the issue:

" system-tools-backends (1.9.6-0ubuntu1) edgy; urgency=low
 .
   * New upstream version:
     - Do not repeat multiple SMB share entries when the name has a $ symbol
       (Ubuntu: #6142)
     - Avoid timeouts during file monitoring (Ubuntu: #61186)
     - Code improvements to BSD, RCng and SuSE services init code
     - Add an UID/GID independent ID number in UsersConfig and GroupsConfig
       to avoid confusions when adding/deleting groups (Ubuntu: #18632)
     - DBus struct improvements in ServicesConfig
     - Avoid "use lib" warning during s-t-b initialization
     - Fix a possible bug when saving modem interfaces configuration
     - Code cleanups"