PPP username/passwords that contain hashes get corrupted

[Dimos Dimoulis]

Steps to reproduce the bug:
Configure a PPP connection with g-s-t network and
username: user
password: ab#cd

Close it to have the entries updated. pap-secrets contains:
"user" * "ab#cd"

Reopen g-s-t network and modify password to:
password: eab#cd

pap-secrets now contains:
"user" * "eab#cd"#cd"

From that point on the parser gets confused and new modifications will further
corrupt the password. If it's the username that contains a hash mark, multiple
entries will be created, the old ones are not removed.

I have narrowed down the problem to the use of gst_replace_split (in replace.pl)
by gst_network_set_pap_passwd (in network.pl). gst_replace_split doesn't protect
hashes inside quotes.

[Michael Vogt (mvo)]

Thanks for your bugreport.

I talked with the upstream author of gnome-system-tools and we are pretty
nervous about changing "gst_replace_split" because it is used all over the place
in g-s-t. The way forward is probably to use a custom "gst_replace_split" that
honors quotes in this particular context. If that is feasible for hoary (to be
released in 4 days is really questionable though :/

[Michael Vogt (mvo)]

Just FYI, I filed this as gnome bug #302790
(http://bugzilla.gnome.org/show_bug.cgi?id=302790)

[Matt Zimmerman (mdz)]

Did this get fixed during Breezy?

[Michael Vogt (mvo)]

(In reply to comment #3)
> Did this get fixed during Breezy?

No, the relevant code is unchanged. The upstream bug for it is still in
UNCONFIRMED state.

[Paul Dufresne (paulduf)]

I am able to reproduce this on edgy with:
ii gnome-system-t 2.15.5-0ubuntu Cross-platform configuration utilities

Easier info: run network-admin , choose modem, then properties.
And do sudo cat /etc/ppp/pap-secrets to check info there.

[Przemek K. (azrael)]

Since Ubuntu is now using network-manager instead of network-admin, can you test if this bug still appears in the latest Ubuntu release?

[rusivi2 (rusivi2-deactivatedaccount)]

Thank you for posting this bug.

Does this occur in Lucid?

[Milan Bouchet-Valat (nalimilan)]

Problem is, in current Lucid you can't access the interfaces configuration, since the tab is hidden. So it's hard to check...