The status of cups still shows idle when the printer has been unplugged

[hugh chao]

[ Impact ]
After printers (non-ippusb protocal) have been disconnected, the status of cups still shows "idle" instead of "disabled", so seems the disconnected procedure hasn't worked well.

[ Test Case ]
1. Connect the printer (non-ippusb protocal)(which isn't 070104) with any 20.04 machine
2. Wait for the status of cups became "Idle" (lpstat -p)
3. Unplug the cable of the printer
4. Check the status of cups again. (lpstat -p)

[ Regression potential ]
Very Low, if something went wrong in the change, then this issue happened again, due to this snippet will only be called during printer removed event.

[Expected result]
The status should show disabled.

[Actual result]
The status shows idle.

[info]
Target:
HP LaserJet Pro203dw
HP Officejet 100 Mobile Printer
HP Officeject 200 Mobile Printer
Brother HL-2250DN
Samsung ML-331x

Upstream Bug: https://github.com/OpenPrinting/system-config-printer/issues/182

PPA: https://launchpad.net/~hugh712/+archive/ubuntu/sru-1893300

[hugh chao (hugh712)]

currently the syspath for udev-configure-printer is too specific level as:

/devices/pci0000:00/0000:00:14.0/usb1/1-5

But current path can be as below for removing

/devices/pci0000:00/0000:00:14.0/usb1/1-5:1.0
or
/devices/pci0000:00/0000:00:14.0/usb1/1-5:1.0/usbmisc/lp0

so the printer can't be removed, I think the problem is this program - udev-configure-printer, so let me tried to make it more flexible...

[hugh chao (hugh712)]

The idea is :
1. check if the path provided by map is a subset of removing device path
eg. /devices/pci0000:00/0000:00:14.0/usb1/1-5 is a subset of /devices/pci0000:00/0000:00:14.0/usb1/1-5:1.0

2. check if the exist of this device
eg. stat /sys/devices/pci0000:00/0000:00:14.0/usb1/1-5

3. if this device is not exist, then remove..

[Till Kamppeter (till-kamppeter)]

Hugh Chao,

is your commit

https://github.com/hugh712/system-config-printer/commit/c437483c0a

a solution for this problem? If so, could you post a Pull Request on

https://github.com/OpenPrinting/system-config-printer/

mentioning that it solves Issue #182

This should make it easier for the upstream maintainer to review and include your fix.

[hugh chao (hugh712)]

Hi Till,

The PR is already there as
https://github.com/OpenPrinting/system-config-printer/pull/183

[hugh chao (hugh712)]

Here is the package diff for groovy

[hugh chao (hugh712)]

And this is the package diff for focal

[Till Kamppeter (till-kamppeter)]

Uploaded fixed package to Hirsute (1.5.12-0ubuntu4).

[Till Kamppeter (till-kamppeter)]

Uploaded fixed packages for focal and groovy, correcting version numbers and message in debian/changelog.

Hugh, thanks for the debdiffs.

[Łukasz Zemczak (sil2100)]

hm, I would appreciate a bit more information in the Regression Potential section. In this section we need some analysis on where to look for regressions after this lands into the archive. This should be an exercise, thinking: "hmmm, if we change these parts of the code, what could go wrong? Where should we expect regressions, new bugs?"

[hugh chao (hugh712)]

@Łukasz,

updated, please help to review again, thanks.

[Łukasz Zemczak (sil2100)]

Hello hugh, or anyone else affected,

Accepted system-config-printer into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/system-config-printer/1.5.12-0ubuntu3.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[Łukasz Zemczak (sil2100)]

Hello hugh, or anyone else affected,

Accepted system-config-printer into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/system-config-printer/1.5.12-0ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

[hugh chao (hugh712)]

verified the version 1.5.12-0ubuntu3.1 in groovy-proposed, works well and didn't observe any potential regression.

[hugh chao (hugh712)]

verified the version 1.5.12-0ubuntu1.1 in focal-proposed, works well and didn't observe any potential regression.

[Launchpad Janitor (janitor)]

This bug was fixed in the package system-config-printer - 1.5.12-0ubuntu3.1

---------------
system-config-printer (1.5.12-0ubuntu3.1) groovy; urgency=medium

  * Fix USB printers not getting disabled when unplugged (LP: #1893300,
    Upstream issue #182).
     - Update the udev rule due to usb_id udev import is disabled in some
       systems.
     - Make the matching rule of printer device path more flexible.

 -- hugh chao <email address hidden> Tue, 03 Nov 2020 15:31:05 +0800

[Łukasz Zemczak (sil2100)]

The verification of the Stable Release Update for system-config-printer has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

[Launchpad Janitor (janitor)]

This bug was fixed in the package system-config-printer - 1.5.12-0ubuntu1.1

---------------
system-config-printer (1.5.12-0ubuntu1.1) focal; urgency=medium

  * Fix USB printers not getting disabled when unplugged (LP: #1893300,
    Upstream issue #182).
     - Update the udev rule due to usb_id udev import is disabled in some
       systems.
     - Make the matching rule of printer device path more flexible.

 -- hugh chao <email address hidden> Tue, 03 Nov 2020 15:31:05 +0800