"/etc/init.d/syslog-ng reload" fails if SYSLOGNG_OPTS is set

[Dan Urist]

Binary package hint: syslog-ng

Versions affected: syslog-ng 3.1.2-1 in maverick and lucid backports.

Options for syslog-ng can be set directly in /etc/init.d/syslog-ng or in /etc/default/syslog-ng. If options are set, for example "--fd-limit 1024", then "/etc/init.d/syslog-ng reload" fails with the error:

    start-stop-daemon: unrecognized option '--fd-limit'

The issue is in the syslog-ng function, which contains the line:

      start-stop-daemon --stop --signal 1 --quiet --exec "$SYSLOGNG" \
                        --pidfile "$PIDFILE" $SYSLOGNG_OPTS

Instead, this should probably be:

    start-stop-daemon --stop --signal 1 --exec "$SYSLOGNG" \
                      --pidfile "$PIDFILE" -- -p "$PIDFILE" $SYSLOGNG_OPTS

[Peter Czanik (pczanik)]

Tested on Ubuntu 11.10 and the problem is fixed.