synaptic network proxy preferences doesn't capitalize "internet"

Bug #706271 reported by Eliah Kagan
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
synaptic
Fix Committed
Undecided
Unassigned
synaptic (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

Binary package hint: synaptic

In synaptic 0.75~pre4 on Natty i386, in the Network tab of the Preferences, the option "Direct connection to the internet" appears under Proxy Server. The word "Internet" should be capitalized when it refers to the largest and most widely used global internetwork (which is what it refers to here, and almost everywhere else; appropriate uses of the term "internet" without initial capitalization exist but are rare).

So, that option should instead read, "Direct connection to the Internet".

Besides being correct (and because of that), this usage is also common throughout applications in Ubuntu, so adopting it in Synaptic will also increase interface uniformity.

This bug might be reflected in other languages too, so fixing it might require slight retranslation.

I am also able to produce this bug with synaptic 0.63.1ubuntu4 on a Maverick amd64 system.

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: synaptic 0.75~pre4
ProcVersionSignature: Ubuntu 2.6.37-12.26-generic 2.6.37
Uname: Linux 2.6.37-12-generic i686
Architecture: i386
Date: Sat Jan 22 07:49:16 2011
ExecutablePath: /usr/sbin/synaptic
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Alpha i386 (20110120)
ProcEnviron:
 LANGUAGE=en_US:en
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 LC_MESSAGES=en_US.utf8
 SHELL=/bin/bash
SourcePackage: synaptic

Related branches

Revision history for this message
Eliah Kagan (degeneracypressure) wrote :
Revision history for this message
Hans Joachim Desserud (hjd) wrote :

Thanks for spotting it. This should probably be an easy fix.

Changed in synaptic (Ubuntu):
status: New → Confirmed
tags: added: bitesize string-fix
Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

This is my first attempt to fix anything and generate a patch. (Following patch guide, used apt-get source, copied source tree, applied fix and used diff).

Hope it is correct.

tags: added: patch
Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

I have not produced the patch correctly, above is probably useless. Re-doing it now.

Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

Now, have redone this, following the video tutorial from dholbach on patching. Debdiff attached.

Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

Third time lucky perhaps. Thanks to ari-tczew on IRC for pointing out the shortcomings of my previous debdiff.

Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

I have also just realised that I have edited the maverick version synaptic 0.63 whereas the OP was referring to a problem with Natty 0.75, so the patch is perhaps still useless. Getting Natty now and will try again.

Revision history for this message
Eliah Kagan (degeneracypressure) wrote :

My original report documents this bug in both Natty and Maverick. I presume that it is present in every other release's version of Synaptic as well, but I have not actually checked.

Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

I have just finished replacing my old karmic system with a new maverick install, running natty via testdrive, so will be in a position to create a debdiff under natty, hopefully later today.

Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

Now adding debdiff for Natty.

As I've indicated above, this is my first bug to patch, so feedback will be welcome either here or on #ubuntu-motu.
Thanks.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Looks good at first glance.

I realize you may have never worked with Bzr before, but would it be possible for you to apply these changes in a copy of the lp:synaptic branch and file a merge request? This way we could include your changes "upstream", and release a new version of synaptic to Ubuntu without carrying ubuntu-specific changes. This way it benefits all distributions. :)

You can learn more about using bazaar here: http://doc.bazaar.canonical.com/bzr.2.2/en/user-guide/index.html

Revision history for this message
Chris McGinlay (chrismcginlay) wrote :

OK Mathieu, I have started working through the bazaar docs.

Michael Vogt (mvo)
Changed in synaptic:
status: New → Fix Committed
Changed in synaptic (Ubuntu):
status: Confirmed → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package synaptic - 0.75.1ubuntu1

---------------
synaptic (0.75.1ubuntu1) natty; urgency=low

  * merged fixed from debian/sid

synaptic (0.75.1) unstable; urgency=low

  * po/ru.po:
    - updated, thanks to Alexander Sashanov (closes: #614969)
  * gtk/rgrepositorywin.cc, gtk/gtkbuilder/window_repositories.ui:
    - fix repository editor (closes: #613436)
  * gtk/gtkbuilder/window_main.ui:
    - fixup glade->gtkbuild menu messup
  * gtk/rgmainwindow.cc:
    - hide "quick filter" if no apt-xapian-index is installed
      (closes: #613434)
  * po/pl.po:
    - fix newsgroup translation (thanks to Michal Szwaczko),
      closes: #613346
  * merged lp:~and471/synaptic/fix-resize-grip that adds a bit of
    extra spacing for the progressbar on the lower right

synaptic (0.75) unstable; urgency=low

  [ Michael Vogt ]
  * merged lp:~mathieu-tl/synaptic/gtk3 this brings gtkbuilder
    (instead of glade) and the preparation for updating for gtk3
    Many thanks to Mathieu Trudel-Lapierre
  * show changelog button alongside the screenshot button
  * make sure /etc/apt/apt.conf.d/99synaptic is mode 644
    (LP: #637157)
  * common/rpackagecache.cc:
    - read pindir as well as the pinfile (LP: #628818)
  * when reading markings, ensure the views are refreshed
    so that broken dependencies are displayed
  * show /ask about the pkg state changes when reading selections
    from a file, simpify askStateChanges code
  * merged
    lp:~chris-ascentsoftware/ubuntu/natty/synaptic/synaptic-fix-706271
    many thanks! (LP: #706271)
  * merged lp:~kelemeng/synaptic/bug702181, many thanks!
    (LP: #702181)
  * merged lp:~kelemeng/synaptic/bug688897, many thanks!
    (LP: #688897)

  [ Chris McGinlay ]
  * gtk/gtkbuilder/window_preferences.ui, po/*
   - Change capitalisation of internet to Internet (LP: #706271)

  [ Luca Falavigna ]
  * common/rpackageview.cc:
    - Do not display base packages in manual view.
 -- Michael Vogt <email address hidden> Fri, 04 Mar 2011 12:29:46 +0100

Changed in synaptic (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers