RGDebInstallProgress cuts off the error string if the error contains a ':'

Bug #600658 reported by Jonathan Thomas on 2010-07-01
This bug affects 1 person
Affects Status Importance Assigned to Milestone
synaptic (Ubuntu)

Bug Description

Binary package hint: synaptic

Currently, the string reported by dpkg --status-fd in RGDebInstallProgress::updateInterface() is being split at ':'.

However, if an error string (split[3]) contains a ':', the previous splitting rules will truncate the error at that ':'. This can happen with a file overwrite error of a package that has an epoch. I've pasted the example in my screenshot.

The QApt worker's InstallProgress class also suffered from this bug. I've attatched the solution I am currently using for LibQApt, as well as a screenshot of the error.

Related branches

Jonathan Thomas (echidnaman) wrote :
Changed in synaptic (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Jean-Baptiste Lallement (jibel) wrote :

Fix in bzr revno 99.

This is a really trivial fix but I'm always very suspicious of trivial fixes and it's untested because I haven't found a package to reproduce in maverick.
Setting the max_tokens to 4 instead of 5 should do the trick because the 5th token was never used and g_strsplit will append the remainder of the string to the last token i.e the part of the version string after the last ':'

Changed in synaptic (Ubuntu):
status: Triaged → Fix Committed
Launchpad Janitor (janitor) wrote :
Download full text (3.9 KiB)

This bug was fixed in the package synaptic - 0.70~pre2ubuntu1

synaptic (0.70~pre2ubuntu1) natty; urgency=low

  * merged from debian/unstable, remaining changes:
    - ubuntu icons for supported applications
    - launchpad-integration
    - ubuntu changelog download support
    - support section metapackages
    - x-ubuntu-gettext-domain in desktop file

synaptic (0.70~pre2) unstable; urgency=low

  [ Michael Vogt ]
  * po/pt_BR.po:
    - updated, thanks to Sergio Cipolla (closes: #593758)
  * po/id.po:
    - added, thanks to Dirgita
  * po/ru.po:
    - updated, thansk to Yuri Kozlov (closes: #571712)
  * po/de.po:
    - fix fuzzy string, thanks to Alek (closes: #599744)
  * po/et.po:
    - updated, thanks to Guido Tabbernuk
  * po/he.po:
    - updated, thanks to Lior Kaplan and Sergio Cipolla
      (closes: #586940)
  * gtk/rgdebinstallprogress.cc, gtk/rgterminstallprogress.cc:
    - fix FTBFS on latest vte (closes: #597384)
  * common/rpackagecache.{cc,h}, common/rpackage.cc:
    - add cache for PkgFileIterator->pkgIndexFile* to speed up
      RPackage::IsTrusted (LP: #165181)
  * gtk/rgdebinstallprogress.cc:
    - merge fix for error string if those contain a ":"
      (LP: #600658), thanks to Jonathan Thomas and Jean-Baptiste Lallement
  * common/rpackagelister.cc:
    - when sorting by support status use STL stable_parition to speed
      up the list view (thanks to David Purcell)
    - when clicking on the "supported" column, default to showing the
      supported items first, then the unsupported ones
  * gtk/rgmainwindow.cc:
    - show message in quick search label if no apt-xapian-index can
      be found

   [ Jean-Baptiste Lallement ]
   * gtk/rgdebinstallprogress.{cc,h}: Terminal shortcuts fixes
     - fix <CTRL><SHIFT>c behavior (LP: #250359)
     - add shortcuts <CTRL>a and <CTRL><SHIFT>a to select all/none text
       in the terminal
     - add contextual menu to the terminal to select all and copy text
       (LP: #31396)

synaptic (0.70~pre1) unstable; urgency=low

  * New upstream release that merges all changes from
    Debian and Ubuntu into a single tree again. This include libept
    support and lots of fixes.
  * po/sl.po:
    - updated, thanks to Matej Urbančič
  * po/pt_BR.po:
    - updatd, thanks to Sergio Cipolla, closes: #579296
  * gtk/rgmainwindow.cc:
    - fix hang when applying the preferences (LP: #172487)
  * po/th.po:
    - updated, thanks to Theppitak Karoonboonyanan
      (closes: #592696)
  * pre-build.sh:
    - ensure version number gets updated on build

synaptic (0.63.2) unstable; urgency=low

  [ Michael Vogt ]
  * po/uk.po:
    - updated, thanks to Serhij Dubyk
  * po/it.po:
    - updated, thanks to Milo Casagrande (closes: #575685)
  * po/et.po:
    - added, thanks to G. Tabbernuk

  [ Bilal Akhtar ]
  * gtk/rgmainwindow.cc
    - Modify gtk/rgmainwindow.cc to populate package list again after
     'Unmark All' is selected. (LP: #155930)

  [ Jean-Baptiste Lallement ]
  * Fix sorting issues of the package list
    - Fix sort by name and by section (LP: #518509)
    - Improve sort by column performance
  * sort 'installed files' list in alphabetical order (LP: #32550)
  * Set versi...


Changed in synaptic (Ubuntu):
status: Fix Committed → Fix Released

   Antibiotics have become part of modern life but few of us actually know what it exactly entail.

        Dear 600658,

Even if your sex life is already rich and fulfilling... Imagine you had a little more energy... if your erections stayed harder... or you could go just a little longer...
Or maybe you worry, when you climb under the covers, that you’re starting something you can’t finish?
Well, now advancements in natural medicine are making it easier than ever to promote a strong libido, firm, natural erections and enhanced desire.

Now thanks to this exciting natural breakthrough, you could get an erection “on demand” and when you do, sustain it long enough – and keep firm enough — to fully satisfy your wife in bed. Even if you’re in your 50s, 60s, 70s, 80s or older!

As a doctor, I’ve learned something over the years that may surprise you — age has very little to do with sex. There are men out there having the best sex of their lives well into their 80th year and beyond.

And those men have three key things in common that their sex starved friends don’t:
Hard, recurring erections...
Heightened desire and stamina...
And a reproductive system that could be functioning at the top of its game...

   Lucky? You bet.

But you too could give your body the nutrients it needs to support your entire sexual health.

   Let your penis a chance to restore its sexual activity and indulge into some pleasure!


>>> www.pillsnoar.ru <<<


To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers