swift-container package is missing Upstart and System V files for the container-sharder service

Bug #1827340 reported by Tytus Kurek on 2019-05-02
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
swift (Ubuntu)
Low
Tytus Kurek

Bug Description

It looks like the most recent version of the swift-container package is missing Upstart and System V files for the container-sharder service:

root@swift:~# apt-cache policy swift-container
swift-container:
  Installed: 2.21.0-0ubuntu1~cloud0
  Candidate: 2.21.0-0ubuntu1~cloud0
  Version table:
 *** 2.21.0-0ubuntu1~cloud0 500
        500 http://ubuntu-cloud.archive.canonical.com/ubuntu bionic-updates/stein/main amd64 Packages
        100 /var/lib/dpkg/status
     2.17.1-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu bionic-updates/main amd64 Packages
     2.17.0-0ubuntu1 500
        500 http://archive.ubuntu.com/ubuntu bionic/main amd64 Packages
root@swift:~#
root@swift:~#
root@swift:~#
root@swift:~# dpkg -L swift-container
/.
/etc
/etc/init
/etc/init/swift-container-auditor.conf
/etc/init/swift-container-replicator.conf
/etc/init/swift-container-sync.conf
/etc/init/swift-container-updater.conf
/etc/init/swift-container.conf
/etc/init.d
/etc/init.d/swift-container
/etc/init.d/swift-container-auditor
/etc/init.d/swift-container-replicator
/etc/init.d/swift-container-sync
/etc/init.d/swift-container-updater
/etc/swift
/etc/swift/container-server.conf
/usr
/usr/bin
/usr/bin/swift-container-auditor
/usr/bin/swift-container-info
/usr/bin/swift-container-reconciler
/usr/bin/swift-container-replicator
/usr/bin/swift-container-server
/usr/bin/swift-container-sharder
/usr/bin/swift-container-sync
/usr/bin/swift-container-updater
/usr/bin/swift-manage-shard-ranges
/usr/bin/swift-reconciler-enqueue
/usr/share
/usr/share/doc
/usr/share/doc/swift-container
/usr/share/doc/swift-container/changelog.Debian.gz
/usr/share/doc/swift-container/container-server.conf-sample
/usr/share/doc/swift-container/container-sync-realms.conf-sample
/usr/share/doc/swift-container/copyright
/usr/share/man
/usr/share/man/man1
/usr/share/man/man1/swift-container-auditor.1.gz
/usr/share/man/man1/swift-container-info.1.gz
/usr/share/man/man1/swift-container-reconciler.1.gz
/usr/share/man/man1/swift-container-replicator.1.gz
/usr/share/man/man1/swift-container-server.1.gz
/usr/share/man/man1/swift-container-sync.1.gz
/usr/share/man/man1/swift-container-updater.1.gz
/usr/share/man/man5
/usr/share/man/man5/container-reconciler.conf.5.gz
/usr/share/man/man5/container-server.conf.5.gz
/usr/share/man/man5/container-sync-realms.conf.5.gz

This disallows managing the service through the 'service' or 'systemctl' commands which is required for the following bug:

https://bugs.launchpad.net/charm-swift-storage/+bug/1826859

Tytus Kurek (tkurek) on 2019-05-02
tags: removed: field-medium
Tytus Kurek (tkurek) on 2019-05-06
Changed in swift (Ubuntu):
assignee: nobody → Tytus Kurek (tkurek)
Tytus Kurek (tkurek) wrote :

Patch attached

Changed in swift (Ubuntu):
status: New → In Progress

The attachment "lp1827340.patch" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Bryan Quigley (bryanquigley) wrote :

I don't see the point in enabling Upstart (or sysv init.d jobs) at this point - unless I really don't understand how this will be used Upstart jobs won't do anything on modern releases of Ubuntu.

Instead perhaps using similar systemd jobs that Debian has -https://packages.debian.org/sid/all/swift-container/filelist

Tytus Kurek (tkurek) wrote :

I agree that it reveals a deeper issue. Would you suggest to remove all old Upstart / System V files (for all Swift services) and replace them with Systemd files?

Bryan Quigley (bryanquigley) wrote :

Yea, I'd be for going systemd unit files only. They will always take precedence on 18.04+, so might as well only provide them.

Tytus Kurek (tkurek) on 2019-05-14
Changed in swift (Ubuntu):
status: In Progress → New
assignee: Tytus Kurek (tkurek) → nobody
Tytus Kurek (tkurek) on 2019-05-14
Changed in swift (Ubuntu):
status: New → In Progress
assignee: nobody → Tytus Kurek (tkurek)
Tytus Kurek (tkurek) wrote :

Hi Bryan,

I'm attaching an updated patch, however, as this is the first time I'm creating a patch for ubuntu package, I am not sure whether everything is correct. Please have a look and let me know if anything has to be changed.

Regards

Tytus

Bryan Quigley (bryanquigley) wrote :

Hi Tytus,

I did a once over and it looks good to me. I'm far from an expert though. I think they use git-ubuntu for this, but I'd check with one of the maintainers.

Thanks,
Bryan

Changed in swift (Ubuntu):
importance: Undecided → Low
Tytus Kurek (tkurek) wrote :

Hi Mathew,

Is there any chance to move this forward?

Thanks

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers