Please merge 1.9.13p1-1 into lunar

Bug #2007698 reported by Danilo Egea Gondolfo
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sudo (Ubuntu)
Fix Released
Undecided
Unassigned

Related branches

Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

Autopkgtests are passing (tested on ppc64 and amd64)

summary: - Please merge 1.9.12p2-1 into lunar
+ Please merge 1.9.13p1-1 into lunar
Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

It looks like you forgot to add the following to the changelog:

    - debian/control:
      + Build-Conflicts on fakeroot (<< 1.25.3-1.1ubuntu1)
    - debian/sudo[-ldap].manpages: install man/man8/sudo_root.8
    - debian/sudo[-ldap].init: delete init scripts, as they are no longer
      necessary.
    - debian/etc/pam.d/sudo[-i]:
      + Use pam_env to read /etc/environment and /etc/default/locale
        environment files. Reading ~/.pam_environment is not permitted due
        to security reasons.
    - debian/etc/sudoers:
      + also grant admin group sudo access
      + include /snap/bin in the secure_path
    - debian/tests/control: 03-getroot-ldap:
      + allow removal of 'sudo' in autopkgtest (SUDO_FORCE_REMOVE=yes)

And it looks like you didn't add the BuildConflicts to the debian/control file.

Please update the package, thanks!

Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

Hi Marc, thanks a lot for taking a look at this. I misunderstood how the changelog must be constructed.

I believe the Build-Conflicts can just be dropped as the problem with fakeroot was fixed (LP: #1915250) and sudo doesn't require root to be built anymore (and the file permissions seem to be correct in my PPA).

I updated the merge request.

Thanks!

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks! New changelog looks good, I am uploading it now, with a slight change to split one of the lines that was long and generating a lintian error.

Simon Quigley (tsimonq2)
Changed in sudo (Ubuntu):
status: New → Fix Committed
Changed in sudo (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.