regression: sudo returns exit code 0 if child is killed with SIGTERM

Bug #1832257 reported by PeterWoodman on 2019-06-10
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
sudo (Ubuntu)
Undecided
Marc Deslauriers
Xenial
High
Marc Deslauriers

Bug Description

hey there- it looks like we accidentally removed the patch that fixed this problem when releasing sudo 1.8.16-0ubuntu1.6 -

https://git.launchpad.net/ubuntu/+source/sudo/commit/?h=ubuntu/xenial-updates&id=15345b19b82f587498573b38554e24ec0ab816cb

note that `terminate-with-commands-signal.patch` is removed from debian/patches/series in that commit

and the behavior described in the original bug (LP 1686803) has returned in xenial.

can we get this back into the current sudo package? the fix still exists upstream so it feels like this was an accidental reversion.

Marc Deslauriers (mdeslaur) wrote :

Oh wow, I'm not sure how that happened. I'll release an update for this.

Changed in sudo (Ubuntu):
status: New → Confirmed
assignee: nobody → Marc Deslauriers (mdeslaur)
status: Confirmed → Fix Released
Changed in sudo (Ubuntu Xenial):
status: New → Confirmed
assignee: nobody → Marc Deslauriers (mdeslaur)
importance: Undecided → High
PeterWoodman (peter-shortbus) wrote :

do you have any guidance on how long a fix like this generally takes to land? we're deciding whether or not to roll our own, as this has some immediately undesirable effects in our environment.

Marc Deslauriers (mdeslaur) wrote :

I'll release it tomorrow.

Marc Deslauriers (mdeslaur) wrote :

I've uploaded it to build in the following PPA:

https://launchpad.net/~ubuntu-security-proposed/+archive/ubuntu/ppa/+packages

You can get it from there if you need it before tomorrow.

PeterWoodman (peter-shortbus) wrote :

awesome, thanks so much

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sudo - 1.8.16-0ubuntu1.7

---------------
sudo (1.8.16-0ubuntu1.7) xenial-security; urgency=medium

  * debian/patches/terminate-with-commands-signal.patch: re-enable patch
    that got dropped by mistake in previous upload. (LP: #1832257)

 -- Marc Deslauriers <email address hidden> Mon, 10 Jun 2019 15:42:44 -0400

Changed in sudo (Ubuntu Xenial):
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers