update crashes on password protected server

[Pedro de Oliveira]

Hello,

The current version of Subversion on Ubuntu Bionic has a bug related with gpg-agent.

The problem is when you run "svn up" with multiple directories and/or files as arguments on a already checked out repository. This only happens on a UN/PW protected Subversion repository via https.

Steps to reproduce:

rm -rf ~/.subversion [if you don't do this its harder to reproduce]
cd private_repo
svn up dir1 dir2/foo dir3/bar myfile.txt

Output:

Updating 'dir1':
Authentication realm: <https://REDACTED:443> Repositorio SVN - REDACTED
Password for 'falso': <enter>

Authentication realm: <https://REDACTED:443> Repositorio SVN - REDACTED
Username: myuser
Password for 'myuser': mypass

-----------------------------------------------------------------------
ATTENTION! Your password for authentication realm:

   <https://REDACTED:443> Repositorio SVN - REDACTED

can only be stored to disk unencrypted! You are advised to configure
your system so that Subversion can store passwords encrypted, if
possible. See the documentation for details.

You can avoid future appearances of this warning by setting the value
of the 'store-plaintext-passwords' option to either 'yes' or 'no' in
'/home/falso/.subversion/servers'.
-----------------------------------------------------------------------
Store password unencrypted (yes/no)? no
U dir1/test.txt
U dir1/test2.txt
Updated to revision 71.
Updating 'dir2/foo':

-----------------------------------------------------------------------
ATTENTION! Your password for authentication realm:

   <https://REDACTED:443> Repositorio SVN - REDACTED

can only be stored to disk unencrypted! You are advised to configure
your system so that Subversion can store passwords encrypted, if
possible. See the documentation for details.

You can avoid future appearances of this warning by setting the value
of the 'store-plaintext-passwords' option to either 'yes' or 'no' in
'/home/falso/.subversion/servers'.
-----------------------------------------------------------------------
Store password unencrypted (yes/no)? no
U dir2/foo/test.txt
Updated to revision 71.
Updating 'dir3/bar':
U dir3/bar/test.txt
Updated to revision 71.
Updating 'myfile.txt':
Segmentation fault

--

The version on bionic is 1.9.7. So went digging in the Subversion source code and tried to see if it was fixed in newer releases of this same branch.

I built every version from the 1.9 branch until I found it was fixed in version 1.9.10, so I used git bisect to figure out which commit fixed it.

Its this one: https://github.com/apache/subversion/commit/aa731718d6ff24dfcf5a3260d8988cee34ce2be1

In that commit it mentions r1691952 of the Subversion repository: https://svn.apache.org/viewvc?view=revision&revision=1691952

And that one mentions a bug in the Subversion bug tracker: https://issues.apache.org/jira/browse/SVN-4584?issueNumber=4584

I tried that patch (the github one) on 1.9.7 and it fixes the crash.

--

To submit this bug I tried to follow this: https://packaging.ubuntu.com/html/fixing-a-bug.html

But in the process of running: pbuilder-dist bionic ../subversion_1.9.7-4ubuntu2.dsc

The compilation fails with some other unrelated problem:

/bin/bash: /usr/lib/jvm/default-java/bin/javah: No such file or directory

From what I've found javah has been deprecated - https://stackoverflow.com/a/50353275

--

$ lsb_release -rd
Description: Ubuntu 18.04.4 LTS
Release: 18.04

$ apt-cache policy subversion
subversion:
  Installed: 1.9.7-4ubuntu1
  Candidate: 1.9.7-4ubuntu1
  Version table:
 *** 1.9.7-4ubuntu1 500
        500 http://pt.archive.ubuntu.com/ubuntu bionic/universe amd64 Packages
        100 /var/lib/dpkg/status

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "gpg-agent.diff" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]