| 2021-11-16 18:20:47 |
Colin Ian King |
bug |
|
|
added bug |
| 2021-11-16 18:20:54 |
Colin Ian King |
stress-ng: assignee |
|
Colin Ian King (colin-king) |
|
| 2021-11-16 18:20:57 |
Colin Ian King |
stress-ng: status |
New |
In Progress |
|
| 2021-11-16 18:21:00 |
Colin Ian King |
stress-ng: importance |
Undecided |
Low |
|
| 2021-11-16 19:02:55 |
Colin Ian King |
description |
== SRU Justification ==
[ The issue ]
Turns out the math is incorrect in calculating the offset into a file on direct I/O writes cause non-block aligned offsets that cause -EINVAL on writes. This can occur when running non-power of two number of hdd stressors, e.g. 5 stressors.
[ The fix ]
Upstream fix:
From 9bbe45dfbd5db48c658dd0cf1f28cdb847bcee9c Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@gmail.com>
Date: Thu, 11 Nov 2021 13:11:27 +0000
Subject: [PATCH] stress-hdd: ensure offset is aligned to 512 byte boundary
Fix corrects rounds to the 512 byte boundary on offsets.
[ Test plan ]
stress-ng --hdd 5 --hdd-write-size 512 --hdd-bytes 2M --hdd-opts direct,sync,wr-rnd,rd-rnd --timeout 0 --verbose
Without the fix the test exits early with a invalid write failure error. With the fix the test will run forever.
[ Where problems could occur ]
This fix only affects the hdd stressor test with random I/O writes AND direct I/O. The fix aligns the random offset, so in effect the change won't affect the overall test behaviour except for fixing the offsets so they are always naturally block aligned. This does mean that the stressor will do writes that are no longer spanned over multiple blocks (which is a valid test case), so the test case is less effective, but it is now at least working for direct I/O cases. |
== SRU Justification ==
[ The issue ]
Turns out the math is incorrect in calculating the offset into a file on direct I/O writes cause non-block aligned offsets that cause -EINVAL on writes. This can occur when running non-power of two number of hdd stressors, e.g. 5 stressors.
[ The fix ]
Upstream fix:
From 9bbe45dfbd5db48c658dd0cf1f28cdb847bcee9c Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@gmail.com>
Date: Thu, 11 Nov 2021 13:11:27 +0000
Subject: [PATCH] stress-hdd: ensure offset is aligned to 512 byte boundary
Fix corrects rounds to the 512 byte boundary on offsets.
See: https://github.com/ColinIanKing/stress-ng/issues/158
[ Test plan ]
stress-ng --hdd 5 --hdd-write-size 512 --hdd-bytes 2M --hdd-opts direct,sync,wr-rnd,rd-rnd --timeout 0 --verbose
Without the fix the test exits early with a invalid write failure error. With the fix the test will run forever.
[ Where problems could occur ]
This fix only affects the hdd stressor test with random I/O writes AND direct I/O. The fix aligns the random offset, so in effect the change won't affect the overall test behaviour except for fixing the offsets so they are always naturally block aligned. This does mean that the stressor will do writes that are no longer spanned over multiple blocks (which is a valid test case), so the test case is less effective, but it is now at least working for direct I/O cases. |
|
| 2021-11-16 19:47:32 |
Colin Ian King |
description |
== SRU Justification ==
[ The issue ]
Turns out the math is incorrect in calculating the offset into a file on direct I/O writes cause non-block aligned offsets that cause -EINVAL on writes. This can occur when running non-power of two number of hdd stressors, e.g. 5 stressors.
[ The fix ]
Upstream fix:
From 9bbe45dfbd5db48c658dd0cf1f28cdb847bcee9c Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@gmail.com>
Date: Thu, 11 Nov 2021 13:11:27 +0000
Subject: [PATCH] stress-hdd: ensure offset is aligned to 512 byte boundary
Fix corrects rounds to the 512 byte boundary on offsets.
See: https://github.com/ColinIanKing/stress-ng/issues/158
[ Test plan ]
stress-ng --hdd 5 --hdd-write-size 512 --hdd-bytes 2M --hdd-opts direct,sync,wr-rnd,rd-rnd --timeout 0 --verbose
Without the fix the test exits early with a invalid write failure error. With the fix the test will run forever.
[ Where problems could occur ]
This fix only affects the hdd stressor test with random I/O writes AND direct I/O. The fix aligns the random offset, so in effect the change won't affect the overall test behaviour except for fixing the offsets so they are always naturally block aligned. This does mean that the stressor will do writes that are no longer spanned over multiple blocks (which is a valid test case), so the test case is less effective, but it is now at least working for direct I/O cases. |
== SRU Justification ==
[IMPISH][HIRSUTE][FOCAL][BIONIC][XENIAL]
[ The issue ]
Turns out the math is incorrect in calculating the offset into a file on direct I/O writes cause non-block aligned offsets that cause -EINVAL on writes. This can occur when running non-power of two number of hdd stressors, e.g. 5 stressors.
[ The fix ]
Upstream fix:
From 9bbe45dfbd5db48c658dd0cf1f28cdb847bcee9c Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@gmail.com>
Date: Thu, 11 Nov 2021 13:11:27 +0000
Subject: [PATCH] stress-hdd: ensure offset is aligned to 512 byte boundary
Fix corrects rounds to the 512 byte boundary on offsets.
See: https://github.com/ColinIanKing/stress-ng/issues/158
[ Test plan ]
stress-ng --hdd 5 --hdd-write-size 512 --hdd-bytes 2M --hdd-opts direct,sync,wr-rnd,rd-rnd --timeout 0 --verbose
Without the fix the test exits early with a invalid write failure error. With the fix the test will run forever.
[ Where problems could occur ]
This fix only affects the hdd stressor test with random I/O writes AND direct I/O. The fix aligns the random offset, so in effect the change won't affect the overall test behaviour except for fixing the offsets so they are always naturally block aligned. This does mean that the stressor will do writes that are no longer spanned over multiple blocks (which is a valid test case), so the test case is less effective, but it is now at least working for direct I/O cases. |
|
| 2021-11-16 19:49:24 |
Colin Ian King |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2021-11-16 19:56:58 |
Colin Ian King |
bug task added |
|
stress-ng (Ubuntu) |
|
| 2021-11-16 19:57:04 |
Colin Ian King |
bug task deleted |
stress-ng |
|
|
| 2021-11-16 19:57:09 |
Colin Ian King |
stress-ng (Ubuntu): assignee |
|
Colin Ian King (colin-king) |
|
| 2021-11-16 19:57:11 |
Colin Ian King |
stress-ng (Ubuntu): importance |
Undecided |
Medium |
|
| 2021-11-16 19:57:14 |
Colin Ian King |
stress-ng (Ubuntu): status |
New |
In Progress |
|
| 2021-11-16 19:57:23 |
Colin Ian King |
description |
== SRU Justification ==
[IMPISH][HIRSUTE][FOCAL][BIONIC][XENIAL]
[ The issue ]
Turns out the math is incorrect in calculating the offset into a file on direct I/O writes cause non-block aligned offsets that cause -EINVAL on writes. This can occur when running non-power of two number of hdd stressors, e.g. 5 stressors.
[ The fix ]
Upstream fix:
From 9bbe45dfbd5db48c658dd0cf1f28cdb847bcee9c Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@gmail.com>
Date: Thu, 11 Nov 2021 13:11:27 +0000
Subject: [PATCH] stress-hdd: ensure offset is aligned to 512 byte boundary
Fix corrects rounds to the 512 byte boundary on offsets.
See: https://github.com/ColinIanKing/stress-ng/issues/158
[ Test plan ]
stress-ng --hdd 5 --hdd-write-size 512 --hdd-bytes 2M --hdd-opts direct,sync,wr-rnd,rd-rnd --timeout 0 --verbose
Without the fix the test exits early with a invalid write failure error. With the fix the test will run forever.
[ Where problems could occur ]
This fix only affects the hdd stressor test with random I/O writes AND direct I/O. The fix aligns the random offset, so in effect the change won't affect the overall test behaviour except for fixing the offsets so they are always naturally block aligned. This does mean that the stressor will do writes that are no longer spanned over multiple blocks (which is a valid test case), so the test case is less effective, but it is now at least working for direct I/O cases. |
== SRU Justification ==
[IMPISH][HIRSUTE][FOCAL][BIONIC]
[ The issue ]
Turns out the math is incorrect in calculating the offset into a file on direct I/O writes cause non-block aligned offsets that cause -EINVAL on writes. This can occur when running non-power of two number of hdd stressors, e.g. 5 stressors.
[ The fix ]
Upstream fix:
From 9bbe45dfbd5db48c658dd0cf1f28cdb847bcee9c Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.i.king@gmail.com>
Date: Thu, 11 Nov 2021 13:11:27 +0000
Subject: [PATCH] stress-hdd: ensure offset is aligned to 512 byte boundary
Fix corrects rounds to the 512 byte boundary on offsets.
See: https://github.com/ColinIanKing/stress-ng/issues/158
[ Test plan ]
stress-ng --hdd 5 --hdd-write-size 512 --hdd-bytes 2M --hdd-opts direct,sync,wr-rnd,rd-rnd --timeout 0 --verbose
Without the fix the test exits early with a invalid write failure error. With the fix the test will run forever.
[ Where problems could occur ]
This fix only affects the hdd stressor test with random I/O writes AND direct I/O. The fix aligns the random offset, so in effect the change won't affect the overall test behaviour except for fixing the offsets so they are always naturally block aligned. This does mean that the stressor will do writes that are no longer spanned over multiple blocks (which is a valid test case), so the test case is less effective, but it is now at least working for direct I/O cases. |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
nominated for series |
|
Ubuntu Hirsute |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
bug task added |
|
stress-ng (Ubuntu Hirsute) |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
nominated for series |
|
Ubuntu Focal |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
bug task added |
|
stress-ng (Ubuntu Focal) |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
nominated for series |
|
Ubuntu Jammy |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
bug task added |
|
stress-ng (Ubuntu Jammy) |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
nominated for series |
|
Ubuntu Impish |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
bug task added |
|
stress-ng (Ubuntu Impish) |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
nominated for series |
|
Ubuntu Bionic |
|
| 2021-11-16 19:57:36 |
Colin Ian King |
bug task added |
|
stress-ng (Ubuntu Bionic) |
|
| 2021-11-16 19:57:56 |
Colin Ian King |
stress-ng (Ubuntu Jammy): status |
In Progress |
Fix Released |
|
| 2021-11-16 19:58:01 |
Colin Ian King |
stress-ng (Ubuntu Impish): status |
New |
In Progress |
|
| 2021-11-16 19:58:04 |
Colin Ian King |
stress-ng (Ubuntu Hirsute): status |
New |
In Progress |
|
| 2021-11-16 19:58:08 |
Colin Ian King |
stress-ng (Ubuntu Focal): status |
New |
In Progress |
|
| 2021-11-16 19:58:10 |
Colin Ian King |
stress-ng (Ubuntu Bionic): status |
New |
In Progress |
|
| 2021-11-19 13:09:57 |
Timo Aaltonen |
stress-ng (Ubuntu Impish): status |
In Progress |
Fix Committed |
|
| 2021-11-19 13:10:01 |
Timo Aaltonen |
bug |
|
|
added subscriber SRU Verification |
| 2021-11-19 13:10:04 |
Timo Aaltonen |
tags |
|
verification-needed verification-needed-impish |
|
| 2021-11-19 13:11:20 |
Timo Aaltonen |
stress-ng (Ubuntu Hirsute): status |
In Progress |
Fix Committed |
|
| 2021-11-19 13:11:26 |
Timo Aaltonen |
tags |
verification-needed verification-needed-impish |
verification-needed verification-needed-hirsute verification-needed-impish |
|
| 2021-11-19 13:15:24 |
Timo Aaltonen |
stress-ng (Ubuntu Focal): status |
In Progress |
Fix Committed |
|
| 2021-11-19 13:15:32 |
Timo Aaltonen |
tags |
verification-needed verification-needed-hirsute verification-needed-impish |
verification-needed verification-needed-focal verification-needed-hirsute verification-needed-impish |
|
| 2021-11-19 13:16:23 |
Timo Aaltonen |
stress-ng (Ubuntu Bionic): status |
In Progress |
Fix Committed |
|
| 2021-11-19 13:16:28 |
Timo Aaltonen |
tags |
verification-needed verification-needed-focal verification-needed-hirsute verification-needed-impish |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-impish |
|
| 2021-11-20 14:04:26 |
Colin Ian King |
stress-ng (Ubuntu Impish): assignee |
|
Colin Ian King (colin-king) |
|
| 2021-11-20 14:04:28 |
Colin Ian King |
stress-ng (Ubuntu Hirsute): assignee |
|
Colin Ian King (colin-king) |
|
| 2021-11-20 14:04:30 |
Colin Ian King |
stress-ng (Ubuntu Focal): assignee |
|
Colin Ian King (colin-king) |
|
| 2021-11-20 14:04:34 |
Colin Ian King |
stress-ng (Ubuntu Bionic): assignee |
|
Colin Ian King (colin-king) |
|
| 2021-11-20 14:07:48 |
Colin Ian King |
tags |
verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute verification-needed-impish |
verification-done-impish verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute |
|
| 2021-11-20 14:19:15 |
Colin Ian King |
tags |
verification-done-impish verification-needed verification-needed-bionic verification-needed-focal verification-needed-hirsute |
verification-done-impish verification-fixed-hirsute verification-needed verification-needed-bionic verification-needed-focal |
|
| 2021-11-20 14:20:37 |
Colin Ian King |
stress-ng (Ubuntu Impish): importance |
Undecided |
Medium |
|
| 2021-11-20 14:20:40 |
Colin Ian King |
stress-ng (Ubuntu Hirsute): importance |
Undecided |
Medium |
|
| 2021-11-20 14:20:42 |
Colin Ian King |
stress-ng (Ubuntu Focal): importance |
Undecided |
Medium |
|
| 2021-11-20 14:20:45 |
Colin Ian King |
stress-ng (Ubuntu Bionic): importance |
Undecided |
Medium |
|
| 2021-11-20 19:35:13 |
Colin Ian King |
tags |
verification-done-impish verification-fixed-hirsute verification-needed verification-needed-bionic verification-needed-focal |
verification-done-impish verification-fixed-focal verification-fixed-hirsute verification-needed verification-needed-bionic |
|
| 2021-11-20 19:35:51 |
Colin Ian King |
tags |
verification-done-impish verification-fixed-focal verification-fixed-hirsute verification-needed verification-needed-bionic |
verification-done-focal verification-done-hirsute verification-done-impish verification-needed verification-needed-bionic |
|
| 2021-11-20 19:41:13 |
Colin Ian King |
tags |
verification-done-focal verification-done-hirsute verification-done-impish verification-needed verification-needed-bionic |
verification-done-bionic verification-done-focal verification-done-hirsute verification-done-impish verification-needed |
|
| 2021-11-30 01:01:28 |
Launchpad Janitor |
stress-ng (Ubuntu Impish): status |
Fix Committed |
Fix Released |
|
| 2021-11-30 01:01:34 |
Brian Murray |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
| 2021-11-30 01:05:36 |
Launchpad Janitor |
stress-ng (Ubuntu Hirsute): status |
Fix Committed |
Fix Released |
|
| 2021-11-30 01:06:04 |
Launchpad Janitor |
stress-ng (Ubuntu Focal): status |
Fix Committed |
Fix Released |
|
| 2021-11-30 01:06:24 |
Launchpad Janitor |
stress-ng (Ubuntu Bionic): status |
Fix Committed |
Fix Released |
|
