streamripper garbles characters in media info when substutiting

Bug #1258814 reported by Alexey Perminov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
streamripper (Ubuntu)
New
Undecided
Unassigned

Bug Description

1) Ubuntu release:
Description: Ubuntu 12.04.3 LTS
Release: 12.04

2) package version:
streamripper:
  Installed: 1.64.6-1
  Candidate: 1.64.6-1
  Version table:
 *** 1.64.6-1 0
        500 http://de.archive.ubuntu.com/ubuntu/ precise/universe amd64 Packages
        100 /var/lib/dpkg/status
3) expected behavior:
using substitution rules in rules.txt, track titles for files to be written can be modified as documented

4) actual behavior:
about one in 10 track titles contains garbage characters like '?'

5) reason:
in lib/parse.c:611, g_strconcat is called with incorrect parameters (read from beyond allocated memory, valgrind points to this too)

6) proposed solution:
Apply patch from bombela: http://sourceforge.net/p/streamripper/code/ci/2f7c359d13a6985882ec65afaaf7637b52aceb2a/

additionally, memory is leaked for every substitution: g_free(subst_string); is missing, please add

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: streamripper 1.64.6-1
ProcVersionSignature: Ubuntu 3.2.0-57.87-generic 3.2.52
Uname: Linux 3.2.0-57-generic x86_64
ApportVersion: 2.0.1-0ubuntu17.6
Architecture: amd64
Date: Sat Dec 7 20:33:20 2013
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Release amd64 (20120425)
MarkForUpload: True
ProcEnviron:
 TERM=xterm
 PATH=(custom, no user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: streamripper
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Alexey Perminov (pandokos+launchpad) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.