Ubuntu
storage-framework package

Providers should exit automatically after a period of inactivity

Bug #1616758 reported by James Henstridge
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
storage-framework (Ubuntu)
Fix Released
Undecided
James Henstridge

Bug Description

If a provider service hasn't been used for a certain amount of time, it should exit in an orderly fashion so it doesn't consume system resources unnecessarily.

Related branches

lp:~jamesh/storage-framework/provider-exit-on-idle
unity-api-1-bot: Approve (continuous-integration)
Unity API Team: Pending requested
Diff: 748 lines (+180/-70)
22 files modified
CMakeLists.txt (+1/-1)
debian/changelog (+6/-0)
include/unity/storage/internal/ActivityNotifier.h (+20/-1)
include/unity/storage/internal/EnvVars.h (+7/-0)
include/unity/storage/internal/InactivityTimer.h (+3/-5)
include/unity/storage/provider/internal/AccountData.h (+9/-0)
include/unity/storage/provider/internal/DownloadJobImpl.h (+5/-0)
include/unity/storage/provider/internal/Handler.h (+2/-0)
include/unity/storage/provider/internal/ServerImpl.h (+3/-0)
include/unity/storage/provider/internal/TestServerImpl.h (+7/-0)
include/unity/storage/provider/internal/UploadJobImpl.h (+5/-0)
src/internal/EnvVars.cpp (+38/-28)
src/internal/InactivityTimer.cpp (+5/-24)
src/provider/internal/AccountData.cpp (+10/-1)
src/provider/internal/DownloadJobImpl.cpp (+5/-0)
src/provider/internal/Handler.cpp (+2/-1)
src/provider/internal/ProviderInterface.cpp (+3/-0)
src/provider/internal/ServerImpl.cpp (+18/-1)
src/provider/internal/TestServerImpl.cpp (+10/-2)
src/provider/internal/UploadJobImpl.cpp (+7/-0)
src/registry/main.cpp (+8/-6)
tests/provider-AccountData/AccountData_test.cpp (+6/-0)
lp:~ci-train-bot/storage-framework/storage-framework-ubuntu-zesty-2607
Revision history for this message
Michi Henning (michihenning) wrote :

We'll need some way for the provider to say yay/nay to shutdown because it may be holding onto state, such as for a resumable upload. We can just assume that it's OK to exit because no request arrived for some time.

James Henstridge (jamesh)
Changed in storage-framework (Ubuntu):
assignee: nobody → James Henstridge (jamesh)
status: New → In Progress
Michi Henning (michihenning)
Changed in storage-framework (Ubuntu):
status: In Progress → Fix Released
James Henstridge (jamesh)
Changed in storage-framework (Ubuntu):
status: Fix Released → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package storage-framework - 0.3+17.04.20170320.1-0ubuntu1

---------------
storage-framework (0.3+17.04.20170320.1-0ubuntu1) zesty; urgency=medium

  [ James Henstridge ]
  * Make providers exit after 30 seconds of inactivity. (LP: #1616758)
  * Add UnauthorizedException to the provider library, so the provider
    can trigger reauthentication of the account and have the request
    restarted. (LP: #1616756)
  * Dynamically add and remove providers as the associated accounts
    are enabled and disabled. (LP: #1616757)
  * Allow creation of storage providers that don't use online-accounts.
    Thisis likely only of interest to the local storage provider.

  [ Michi Henning ]
  * Add a storage provider backed by the local file system.
  * Move unity::storage::provider::Item to its own header file. (LP:
    #1668872)
  * If a provider can't acquire its D-Bus well known name, exit rather
    than throwing a (usually uncaught) exception. (LP: #1604640)

 -- Michi Henning <email address hidden> Mon, 20 Mar 2017 04:51:08 +0000

Changed in storage-framework (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.