sssd FTBFS on Trusty following samba update

Bug #1585698 reported by Graham Leggett on 2016-05-25
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
sssd (Ubuntu)
High
Unassigned
Trusty
High
Timo Aaltonen

Bug Description

When attempting to rebuild the sssd package in order to patch a bug, sssd package itself breaks during compilation:

sudo apt-get build-dep sssd
apt-get source --compile sssd

This fails to compile as follows:

In file included from ../src/providers/ad/ad_srv.c:27:0:
../src/util/util.h:304:6: error: conflicting types for 'CatchChild'
 void CatchChild(void);
      ^
In file included from /usr/include/samba-4.0/samba_util.h:77:0,
                 from /usr/include/samba-4.0/ndr.h:30,
                 from ../src/providers/ad/ad_srv.c:24:
/usr/include/samba-4.0/util/signal.h:42:8: note: previous declaration of 'CatchChild' was here
 void (*CatchChild(void))(int);
        ^
In file included from ../src/providers/ad/ad_srv.c:27:0:
../src/util/util.h:305:6: error: conflicting types for 'CatchChildLeaveStatus'
 void CatchChildLeaveStatus(void);
      ^
In file included from /usr/include/samba-4.0/samba_util.h:77:0,
                 from /usr/include/samba-4.0/ndr.h:30,
                 from ../src/providers/ad/ad_srv.c:24:
/usr/include/samba-4.0/util/signal.h:47:8: note: previous declaration of 'CatchChildLeaveStatus' was here
 void (*CatchChildLeaveStatus(void))(int);
        ^
make[3]: *** [src/providers/ad/libsss_ipa_la-ad_srv.lo] Error 1
make[3]: Leaving directory `/home/ubuntu/sssd-1.11.5/build'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/home/ubuntu/sssd-1.11.5/build'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/home/ubuntu/sssd-1.11.5/build'
dh_auto_build: make -j1 returned exit code 2
make: *** [build] Error 2
dpkg-buildpackage: error: debian/rules build gave error exit status 2
Build command 'cd sssd-1.11.5 && dpkg-buildpackage -b -uc' failed.

Robie Basak (racb) wrote :

Thank you for taking the time to file this bug and helping to make Ubuntu better.

I can reproduce this using sbuild and the latest trusty-updates. I suspect that the cause is the major version bump of samba from 4.1 to 4.3 to fix security issues (http://www.ubuntu.com/usn/usn-2950-1/).

tags: added: ftbfs regression-update trusty
Changed in sssd (Ubuntu):
status: New → Triaged
importance: Undecided → High
Changed in sssd (Ubuntu Trusty):
status: New → Triaged
importance: Undecided → High
Changed in sssd (Ubuntu):
status: Triaged → Invalid
summary: - Ubuntu provided sssd-common source doesn't compile on 14.04
+ sssd FTBFS on Trusty following samba update
Robie Basak (racb) wrote :

A workaround to build is:

DEB_BUILD_OPTIONS=parallel=15 sbuild --resolve-alternatives -Adtrusty --chroot-setup-commands='echo "Package: samba-dev\nPin: version 2:4.1*\nPin-Priority: 1001\n\nPackage: libldb-dev\nPin: version 1:1.1.16-1\nPin-Priority: 1001" >> /etc/apt/preferences' sssd_1.11.5-1ubuntu3.dsc

which forces samba-dev from the release pocket. Then builds succeed, but tests fail. I haven't looked into this further.

Graham Leggett (minfrin-y) wrote :

I don't follow - in theory v14.04 is a long term support release, meaning that APIs are frozen and security fixes are backported.

In this case it looks like an API/ABI was changed, causing build breakage, which is exactly the kind of thing we don't want in our production environment. Can you confirm?

Timo Aaltonen (tjaalton) wrote :

sssd has MRE, so bumping it to 1.11.8 (which includes the commit to fix this) would make sense.. I'll prepare it

Changed in sssd (Ubuntu Trusty):
assignee: nobody → Timo Aaltonen (tjaalton)
Robie Basak (racb) wrote :

The patch Marc found fixes the build problem the same as my use of the release pocket for samba-dev fixes the problem. Both fixes lead to the same test failure for me though (fail_over) which could be an unrelated issue:

FAIL: fail_over-tests
=====================

Running suite(s): fail_over
50%: Checks: 2, Failures: 1, Errors: 0
../src/tests/fail_over-tests.c:138:P:FAIL_OVER Tests:test_fo_new_service:0: Passed
../src/tests/fail_over-tests.c:160:F:FAIL_OVER Tests:test_fo_resolve_service:0: ../src/tests/fail_over-tests.c:244: Expected return of 0, got 110

make[1]: *** [override_dh_auto_test] Error 2
make[1]: Leaving directory `/<<PKGBUILDDIR>>'
make: *** [binary] Error 2
dpkg-buildpackage: error: fakeroot debian/rules binary gave error exit status 2
--------------------------------------------------------------------------------
Build finished at 20160526-1151

tags: added: server-next
Marc Deslauriers (mdeslaur) wrote :

I didn't see the test failure locally when I rebuilt with the commit:

PASS: fail_over-tests

Robie Basak (racb) wrote :

@Graham

You are right. I believe this particular samba update was an exception because a security backport was unfeasible. That did have some fallout, but from what I understand the security team had no alternative (apart from leaving users vulnerable).

Robie Basak (racb) wrote :

For reference, here's my full build log (test failure case) in case it's useful at some future date. Perhaps it's just my environment.

Victor Tapia (vtapia) on 2016-06-22
tags: added: sts

Hello Graham, or anyone else affected,

Accepted sssd into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sssd/1.11.8-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in sssd (Ubuntu Trusty):
status: Triaged → Fix Committed
tags: added: verification-needed
Martin Pitt (pitti) wrote :

Hello Graham, or anyone else affected,

Accepted sssd into trusty-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sssd/1.11.8-0ubuntu0.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Timo Aaltonen (tjaalton) wrote :

sssd build again

tags: added: verification-done
removed: verification-needed
tags: removed: brokenbuild
Changed in sssd (Ubuntu):
status: Invalid → Fix Released

The verification of the Stable Release Update for sssd has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sssd - 1.11.8-0ubuntu0.2

---------------
sssd (1.11.8-0ubuntu0.2) trusty; urgency=medium

  * control: Drop check from build-depends (ftbfs).

sssd (1.11.8-0ubuntu0.1) trusty; urgency=medium

  * New upstream bugfix release. (LP: #1443802, #1453253, #1456498,
    #1578191, #1585698)
    - fix-samba4-crash.patch: Dropped, upstream.
    - sssd-dbus: Add a new subpackage for the D-Bus responder.
    - sssd-common.install, sssd-dbus.install: Add new sss_signal helper
      and the dbus service using it.
  * fix-upstream-2620.diff: Set sdap handle as explicitly connected in
    LDAP auth. (LP: #1519086)
  * debian/patches/AD-*.diff: Prefer site-local-DCs in LDAP ping, thanks
    Jorge Niedbalski! (LP: #1587988)

 -- Timo Aaltonen <email address hidden> Thu, 30 Jun 2016 23:51:51 +0300

Changed in sssd (Ubuntu Trusty):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers