Ignores $http_proxy setting

[Soren Hansen]

Lately, I find myself stuck behind proxies more often than I'm used to. ssh-import-id unfortunately ignores the commonly used http_proxy environment variable. wget understands it, so it's just a matter of not cleaning it from the environment before calling wget.

[Soren Hansen (soren)]

Sorry, since it's https, the relevant environment variable is https_proxy, obviously.

[Soren Hansen (soren)]

Actually, I have to wonder why the environment is cleaned at all before calling wget?

[Dustin Kirkland  (kirkland)]

Soren, that was Jamie's suggestion. I've added him here, in case he can answer that one....

[Jamie Strandboge (jdstrand)]

I suggested it because importing a key is a sensitive operation. I maintain this is a sane default, but it seems it would make sense to add an optional command line argument to preserve https_proxy for when the user knows things are ok.

[Dustin Kirkland  (kirkland)]

I would be inclined to just whitelist the https_proxy environment variable, using env -i https_proxy="$https_proxy". However, Jamie's not on board with that at this time (per IRC).

[Dustin Kirkland  (kirkland)]

<kirkland> jdstrand: so what would the call look like, for example? ssh-import-id -e https_proxy jdstrand soren kirkland ?
<kirkland> jdstrand: where -e says "enable this environment variable"
<kirkland> jdstrand: and https_proxy is the env variable to whitelist?
<jdstrand> kirkland: seems fine. alternatively you could always use wget with '--no-proxy' unless the user gives '-p' or '--use-proxy' to ssh-import-id

[Dustin Kirkland  (kirkland)]

Fix committed and released upstream. I'd like to see this make it into Precise too.

[Launchpad Janitor (janitor)]

This bug was fixed in the package ssh-import-id - 2.10-0ubuntu1

---------------
ssh-import-id (2.10-0ubuntu1) precise; urgency=low

  * === added directory img, img/ssh-import-id_14.png, img/ssh-import-
    id_192.png, img/ssh-import-id_64.png, img/ssh-import-id.png:
    - add logos to revision control
  * ssh-import-id, ssh-import-id.1: LP: #944367
    - add -e parameter, which says "don't clean my environment"
    - helps if someone needs to set $https_proxy
 -- Dustin Kirkland <email address hidden> Tue, 31 Jan 2012 16:01:59 -0600