squid3 FTBFS due to missing --name arg to pod2man

[Tiago Stürmer Daitx]

squid3 fails with:

dh_install -psquid3 --sourcedir=/«PKGBUILDDIR»/debian/tmp
cp: cannot stat '/«PKGBUILDDIR»/debian/tmp/usr/share/man/man8/basic_db_auth.8': No such file or directory
dh_install: cp --reflink=auto -a /«PKGBUILDDIR»/debian/tmp/usr/share/man/man8/basic_db_auth.8 debian/squid3//usr/share/man/man8/ returned exit code 1
make: *** [binary-install/squid3] Error 2
/usr/share/cdbs/1/rules/debhelper.mk:213: recipe for target 'binary-install/squid3' failed

caused by helpers/auth_basic/DB/config.test failure during configure phase, which filters out the DB basic auth.

The error in config.test is caused by a missing --name argument to pod2man:

IO::File=IO(0x24d5e30) around line 1: No name given for document
POD document had syntax errors at /usr/bin/pod2man line 71.

This also affects helpers/external_acl/SQL_session/config.test and helpers/log_daemon/DB/config.test

Cause
=====
Since Perl 5.20.2-4 pod2man behavior changed for pipes and now the --name parameter must be included (or --errors set to 'pod', 'stderr', or 'none'). As per Debian [1] and pod2man change log page [2]:

"[Pod::Man] Attempt to detect if the input came from a pipe and therefore has a completely unhelpful (and nonreproducible) source file name, and diagnose this as an error. Document that the name option (--name to pod2man) is required when processing POD source from standard input. (Debian Bug#777405)"

[1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=777405
[2] http://www.eyrie.org/~eagle/software/podlators/news.html

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "patch with fixes for this bug as well as LP: #1496223 and LP: #1496924" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Daniel Holbach (dholbach)]

It fails to build for me on amd64 wily:

libtool: link: g++ -I/usr/include/libxml2 -Wall -Wpointer-arith -Wwrite-strings -Wcomments -Werror -pipe -D_REENTRANT -m64 -g -O2 -fPIE -fstack-protector-strong -Wformat -Werror=format-security -std=c++0x .libs/squidS.o -m64 -Wl,-Bsymbolic-functions -fPIE -pie -Wl,-z -Wl,relro -Wl,-z -Wl,now -o squid AclRegs.o AuthReg.o AccessLogEntry.o AsyncEngine.o YesNoNone.o cache_cf.o CacheDigest.o cache_manager.o carp.o cbdata.o ChunkedCodingParser.o client_db.o client_side.o client_side_reply.o client_side_request.o BodyPipe.o clientStream.o CompletionDispatcher.o ConfigOption.o ConfigParser.o CpuAffinity.o CpuAffinityMap.o CpuAffinitySet.o debug.o delay_pools.o DelayId.o DelayBucket.o DelayConfig.o DelayPool.o DelaySpec.o DelayTagged.o DelayUser.o DelayVector.o NullDelayId.o ClientDelayConfig.o disk.o DiskIO/DiskIOModule.o DiskIO/ReadRequest.o DiskIO/WriteRequest.o dlink.o dns_internal.o DnsLookupDetails.o errorpage.o ETag.o event.o EventLoop.o external_acl.o ExternalACLEntry.o FadingCounter.o fatal.o fd.o fde.o filemap.o forward.o fqdncache.o ftp.o gopher.o helper.o HelperChildConfig.o htcp.o http.o HttpStatusLine.o HttpHdrCc.o HttpHdrRange.o HttpHdrSc.o HttpHdrScTarget.o HttpHdrContRange.o HttpHeader.o HttpHeaderTools.o HttpBody.o HttpMsg.o HttpParser.o HttpReply.o RequestFlags.o HttpRequest.o HttpRequestMethod.o icp_v2.o icp_v3.o int.o internal.o ipc.o ipcache.o SquidList.o main.o mem.o mem_node.o MemBuf.o MemObject.o mime.o mime_header.o multicast.o neighbors.o Packer.o Parsing.o pconn.o peer_digest.o peer_proxy_negotiate_auth.o peer_select.o peer_sourcehash.o peer_userhash.o redirect.o refresh.o RemovalPolicy.o send-announce.o MemBlob.o snmp_core.o snmp_agent.o SquidMath.o SquidNew.o stat.o StatCounters.o StatHist.o String.o StrList.o stmem.o store.o StoreFileSystem.o store_io.o StoreIOState.o store_client.o store_digest.o store_dir.o store_key_md5.o store_log.o store_rebuild.o store_swapin.o store_swapmeta.o store_swapout.o StoreMeta.o StoreMetaMD5.o StoreMetaSTD.o StoreMetaSTDLFS.o StoreMetaUnpacker.o StoreMetaURL.o StoreMetaVary.o StoreStats.o StoreSwapLogData.o Server.o SwapDir.o MemStore.o time.o tools.o tunnel.o unlinkd.o url.o URLScheme.o urn.o wccp.o wccp2.o whois.o wordlist.o LoadableModule.o LoadableModules.o DiskIO/DiskIOModules_gen.o err_type.o err_detail_type.o globals.o hier_code.o icp_opcode.o lookup_t.o repl_modules.o swap_log_op.o DiskIO/AIO/AIODiskIOModule.o DiskIO/Blocking/BlockingDiskIOModule.o DiskIO/DiskDaemon/DiskDaemonDiskIOModule.o DiskIO/DiskThreads/DiskThreadsDiskIOModule.o DiskIO/IpcIo/IpcIoDiskIOModule.o DiskIO/Mmapped/MmappedDiskIOModule.o -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,-Bsymbolic-functions -Wl,-z -Wl,relro -Wl,--export-dynamic auth/.libs/libacls.a ident/.libs/libident.a acl/.libs/libacls.a acl/.libs/libstate.a auth/.libs/libauth.a libAIO.a libBlocking.a libDiskDaemon.a libDiskThreads.a libIpcIo.a libMmapped.a acl/.libs/libapi.a base/.libs/libbase.a ./.libs/libsquid.a ip/.libs/libip.a fs/.libs/libfs.a ipc/.libs/libipc.a mgr/.libs/libmgr.a anyp/.libs/libanyp.a comm/.libs/libcomm.a eui/.libs/libeui.a icmp/.libs/libicmp.a icmp/.libs/libicmp-core.a log/.libs/liblo...

[Tiago Stürmer Daitx (tdaitx)]

Daniel, thanks for sponsoring this.

I apologize, the main discussion for Squid FTBFS was being done in LP: #1496223 and I forgot to add here the piece that this patch actually requires libecap2 gcc5 transition for it to work. I also missed the fact that the bot subscribed ubuntu-sponsors, which was not my intention - at least until we decide to either keep the current squid3 version or merge a newer from Debian.

What is the appropriate action: should I remove the patch from here or just drop the patch flag+patch checkbox? If the latter then someone will have to unsubscribe ubuntu-sponsors.

[Tiago Stürmer Daitx (tdaitx)]

libecap3 was been deleted. I have created LP: #1504200 to handle the gcc5 transition. After it gets sponsored it should be ok to apply this fix.

[Launchpad Janitor (janitor)]

This bug was fixed in the package squid3 - 3.3.8-1ubuntu16

---------------
squid3 (3.3.8-1ubuntu16) wily; urgency=medium

  [ Tiago Stürmer Daitx ]
  * d/patches/fix-logical-not-parentheses-warning.patch: Fix warning for
    logical-not-parentheses which caused squid to FTBFS. (LP: #1496924)
  * d/patches/netfilter_fix.patch: Backported from Squid Bug #4323.
    (LP: #1496223)
  * d/patches/fix-pod2name-pipe-failure.patch: Add --name parameter to
    pod2man (LP: #1501566)
  * roll back build-dependency to libecap2-dev, this version of squid3 is not
    compatible with libecap3 and libecap3 transition has been rolled back for
    wily.

 -- Steve Langasek <email address hidden> Fri, 09 Oct 2015 00:29:47 +0000