| 2023-01-27 21:46:12 |
Athos Ribeiro |
bug |
|
|
added bug |
| 2023-01-27 21:53:11 |
Athos Ribeiro |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/squid/+git/squid/+merge/436437 |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
nominated for series |
|
Ubuntu Jammy |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
bug task added |
|
squid (Ubuntu Jammy) |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
nominated for series |
|
Ubuntu Lunar |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
bug task added |
|
squid (Ubuntu Lunar) |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
nominated for series |
|
Ubuntu Kinetic |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
bug task added |
|
squid (Ubuntu Kinetic) |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
nominated for series |
|
Ubuntu Focal |
|
| 2023-01-30 22:34:02 |
Athos Ribeiro |
bug task added |
|
squid (Ubuntu Focal) |
|
| 2023-01-30 22:36:14 |
Athos Ribeiro |
bug task deleted |
squid (Ubuntu Focal) |
|
|
| 2023-01-30 23:49:24 |
Athos Ribeiro |
description |
As pointed out in [1], as part of Squid's MRE request [2], squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan described in [2].
We want to enable the described behavior in lunar (development) and then SRU it all the way down to focal (which shall also receive MREs in the future).
[1] https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html
[2] https://wiki.ubuntu.com/SquidUpdates |
[ Impact ]
squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan being proposed in https://wiki.ubuntu.com/SquidUpdates.
[ Test Plan ]
The package build itself should suffice here since it runs the upstream test suite (and will fail if any of the upstream tests fail).
Additionally, one could run a local build removing the change related to using the installed binary for one of the tests, i.e., re-introducing the commented 0003-installed-binary-for-debian-ci.patch patch should force a test failure, which will make the build fail, confirming the intended changes.
[ Where problems could occur ]
The upstream testsuite may fail in different paths for different platforms (this is exactly why we need to disable LTO in s390x here). This could introduce test failures that were not predicted here and prevent the package to build, forcing us to either provide a new fix or revert our changes. To mitigate the matter, we will build the package for the supported platforms in a PPA before uploading the package. We will also run autopkgtests in these platforms to ensure no regressions were introduced, since we are also touching the dep8 test suite here.
Other than that, issues may arise from re-building the package against possible different versions of its dependencies. This would also be an issue for any next SRUs for the package, and we intend to stage this one (block-proposed) since it is a test related only change.
[ Other Info ]
This change was motivated by the discussions in https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html related to the squid MRE proposal in https://wiki.ubuntu.com/SquidUpdates.
[ Original message ]
As pointed out in [1], as part of Squid's MRE request [2], squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan described in [2].
We want to enable the described behavior in lunar (development) and then SRU it all the way down to focal (which shall also receive MREs in the future).
[1] https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html
[2] https://wiki.ubuntu.com/SquidUpdates |
|
| 2023-01-30 23:49:41 |
Athos Ribeiro |
bug |
|
|
added subscriber Ubuntu Server |
| 2023-01-30 23:49:50 |
Athos Ribeiro |
tags |
|
server-todo |
|
| 2023-01-30 23:50:00 |
Athos Ribeiro |
squid (Ubuntu Lunar): assignee |
|
Athos Ribeiro (athos-ribeiro) |
|
| 2023-01-30 23:50:02 |
Athos Ribeiro |
squid (Ubuntu Kinetic): assignee |
|
Athos Ribeiro (athos-ribeiro) |
|
| 2023-01-30 23:50:05 |
Athos Ribeiro |
squid (Ubuntu Jammy): assignee |
|
Athos Ribeiro (athos-ribeiro) |
|
| 2023-01-31 09:25:31 |
Launchpad Janitor |
squid (Ubuntu Lunar): status |
New |
Fix Released |
|
| 2023-01-31 14:09:55 |
Athos Ribeiro |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/squid/+git/squid/+merge/436605 |
|
| 2023-01-31 14:10:01 |
Athos Ribeiro |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/squid/+git/squid/+merge/436606 |
|
| 2023-01-31 16:18:35 |
Athos Ribeiro |
tags |
server-todo |
block-proposed-jammy block-proposed-kinetic server-todo |
|
| 2023-02-07 01:44:50 |
Bryce Harrington |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/squid/+git/squid/+merge/436827 |
|
| 2023-02-09 13:32:07 |
Athos Ribeiro |
squid (Ubuntu Jammy): status |
New |
In Progress |
|
| 2023-02-09 13:32:11 |
Athos Ribeiro |
squid (Ubuntu Kinetic): status |
New |
In Progress |
|
| 2023-02-09 13:32:33 |
Athos Ribeiro |
bug |
|
|
added subscriber Ubuntu Stable Release Updates Team |
| 2023-03-03 22:02:25 |
Steve Langasek |
squid (Ubuntu Kinetic): status |
In Progress |
Incomplete |
|
| 2023-03-03 22:04:03 |
Steve Langasek |
squid (Ubuntu Jammy): status |
In Progress |
Fix Committed |
|
| 2023-03-03 22:04:06 |
Steve Langasek |
bug |
|
|
added subscriber SRU Verification |
| 2023-03-03 22:04:10 |
Steve Langasek |
tags |
block-proposed-jammy block-proposed-kinetic server-todo |
block-proposed-jammy block-proposed-kinetic server-todo verification-needed verification-needed-jammy |
|
| 2023-03-13 21:50:52 |
Athos Ribeiro |
tags |
block-proposed-jammy block-proposed-kinetic server-todo verification-needed verification-needed-jammy |
block-proposed-jammy block-proposed-kinetic server-todo verification-done-jammy verification-needed |
|
| 2023-03-14 01:05:22 |
Athos Ribeiro |
merge proposal linked |
|
https://code.launchpad.net/~athos-ribeiro/ubuntu/+source/squid/+git/squid/+merge/438832 |
|
| 2023-03-15 19:39:44 |
Athos Ribeiro |
description |
[ Impact ]
squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan being proposed in https://wiki.ubuntu.com/SquidUpdates.
[ Test Plan ]
The package build itself should suffice here since it runs the upstream test suite (and will fail if any of the upstream tests fail).
Additionally, one could run a local build removing the change related to using the installed binary for one of the tests, i.e., re-introducing the commented 0003-installed-binary-for-debian-ci.patch patch should force a test failure, which will make the build fail, confirming the intended changes.
[ Where problems could occur ]
The upstream testsuite may fail in different paths for different platforms (this is exactly why we need to disable LTO in s390x here). This could introduce test failures that were not predicted here and prevent the package to build, forcing us to either provide a new fix or revert our changes. To mitigate the matter, we will build the package for the supported platforms in a PPA before uploading the package. We will also run autopkgtests in these platforms to ensure no regressions were introduced, since we are also touching the dep8 test suite here.
Other than that, issues may arise from re-building the package against possible different versions of its dependencies. This would also be an issue for any next SRUs for the package, and we intend to stage this one (block-proposed) since it is a test related only change.
[ Other Info ]
This change was motivated by the discussions in https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html related to the squid MRE proposal in https://wiki.ubuntu.com/SquidUpdates.
[ Original message ]
As pointed out in [1], as part of Squid's MRE request [2], squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan described in [2].
We want to enable the described behavior in lunar (development) and then SRU it all the way down to focal (which shall also receive MREs in the future).
[1] https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html
[2] https://wiki.ubuntu.com/SquidUpdates |
[ Impact ]
squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan being proposed in https://wiki.ubuntu.com/SquidUpdates.
[ Test Plan ]
The package build itself should suffice here since it runs the upstream test suite (and will fail if any of the upstream tests fail).
Additionally, one could run a local build removing the change related to using the installed binary for one of the tests, i.e., re-introducing the commented 0003-installed-binary-for-debian-ci.patch patch should force a test failure, which will make the build fail, confirming the intended changes.
[ Where problems could occur ]
The upstream testsuite may fail in different paths for different platforms (this is exactly why we need to disable LTO in s390x here). This could introduce test failures that were not predicted here and prevent the package to build, forcing us to either provide a new fix or revert our changes. To mitigate the matter, we will build the package for the supported platforms in a PPA before uploading the package. We will also run autopkgtests in these platforms to ensure no regressions were introduced, since we are also touching the dep8 test suite here.
Other than that, issues may arise from re-building the package against possible different versions of its dependencies. This would also be an issue for any next SRUs for the package, and we intend to stage this one (block-proposed) since it is a test related only change.
[ Other Info ]
This change was motivated by the discussions in https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html related to the squid MRE proposal in https://wiki.ubuntu.com/SquidUpdates.
As requested during the MP review process for this SRU, I am describing the change set applied below:
d/p/0003-installed-binary-for-debian-ci.patch was originally added to avoid any sed magic in d/t/upstream-test-suite. This was possible because test failures during the build process were being ignored. When no longer ignoring failures, we needed to drop the mentioned patch and apply some sed substitutions to d/t/upstream-test-suite so DEP8 tests use the installed binaries.
Enabling build failures upon failures in the test suit also triggers LTO related errors in s390x builds. We disable such errors as a workaround.
[ Original message ]
As pointed out in [1], as part of Squid's MRE request [2], squid builds do not fail when the upstream test suite (ran as part of dh_auto_test) fails.
Running such test suite and ensuring builds will fail when the tests fail will increase confidence in the packaging process and in the health of new packages. This will be specially useful for the MRE test plan described in [2].
We want to enable the described behavior in lunar (development) and then SRU it all the way down to focal (which shall also receive MREs in the future).
[1] https://lists.ubuntu.com/archives/ubuntu-release/2023-January/005528.html
[2] https://wiki.ubuntu.com/SquidUpdates |
|
| 2023-03-15 23:30:29 |
Athos Ribeiro |
squid (Ubuntu Kinetic): status |
Incomplete |
In Progress |
|
| 2023-03-17 15:30:08 |
Steve Langasek |
squid (Ubuntu Kinetic): status |
In Progress |
Fix Committed |
|
| 2023-03-17 15:30:15 |
Steve Langasek |
tags |
block-proposed-jammy block-proposed-kinetic server-todo verification-done-jammy verification-needed |
block-proposed-jammy block-proposed-kinetic server-todo verification-done-jammy verification-needed verification-needed-kinetic |
|
| 2023-03-22 15:08:04 |
Christian Ehrhardt |
tags |
block-proposed-jammy block-proposed-kinetic server-todo verification-done-jammy verification-needed verification-needed-kinetic |
block-proposed-jammy block-proposed-kinetic verification-done-jammy verification-needed verification-needed-kinetic |
|
| 2023-03-23 10:46:41 |
Athos Ribeiro |
tags |
block-proposed-jammy block-proposed-kinetic verification-done-jammy verification-needed verification-needed-kinetic |
block-proposed-jammy block-proposed-kinetic verification-done verification-done-jammy verification-done-kinetic |
|
| 2023-07-20 11:49:32 |
Łukasz Zemczak |
squid (Ubuntu Kinetic): status |
Fix Committed |
Won't Fix |
|
| 2023-08-17 21:13:36 |
Andreas Hasenack |
tags |
block-proposed-jammy block-proposed-kinetic verification-done verification-done-jammy verification-done-kinetic |
block-proposed-jammy block-proposed-kinetic verification-done-kinetic verification-needed verification-needed-jammy |
|
| 2023-08-17 21:13:55 |
Andreas Hasenack |
tags |
block-proposed-jammy block-proposed-kinetic verification-done-kinetic verification-needed verification-needed-jammy |
block-proposed-kinetic verification-done-kinetic verification-needed verification-needed-jammy |
|
| 2023-08-30 15:21:35 |
Athos Ribeiro |
tags |
block-proposed-kinetic verification-done-kinetic verification-needed verification-needed-jammy |
block-proposed-kinetic verification-done verification-done-jammy verification-done-kinetic |
|
| 2023-08-30 17:35:52 |
Athos Ribeiro |
tags |
block-proposed-kinetic verification-done verification-done-jammy verification-done-kinetic |
verification-done verification-done-jammy verification-done-kinetic |
|
| 2023-08-31 19:37:38 |
Launchpad Janitor |
squid (Ubuntu Jammy): status |
Fix Committed |
Fix Released |
|
| 2023-08-31 19:37:38 |
Launchpad Janitor |
cve linked |
|
2021-46784 |
|
| 2023-08-31 19:37:38 |
Launchpad Janitor |
cve linked |
|
2022-41317 |
|
| 2023-08-31 19:37:38 |
Launchpad Janitor |
cve linked |
|
2022-41318 |
|
| 2023-08-31 19:37:49 |
Andreas Hasenack |
removed subscriber Ubuntu Stable Release Updates Team |
|
|
|
