SRU: spl-linux: xenial: apply fix Fix do_div() types in condvar:timeout

Bug #1599219 reported by Colin Ian King on 2016-07-05
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
spl-linux (Ubuntu)
Medium
Colin Ian King
Xenial
Medium
Colin Ian King

Bug Description

[SRU JUSTIFICATION][XENIAL]

The do_div() macro expects unsigned types and this is detected in
powerpc implementation of do_div(). Make whole_delta and remain_delta unsigned.

[FIX]
Upstream spl fix 2a552736b7fc2bcb810cc520abd2ff9e229a9904 ("Fix do_div() types in condvar:timeout"), https://github.com/zfsonlinux/spl.git

[TEST CASE]
Must pass zfs regression tests.

[REGRESSION POTENTIAL]
Minimal, this touches the spl splat test module, so it's fix to the spl tests rather than core spl module.

------------------------------------------------------------

spl 0.6.5.7 has the following do_div fix that should be SRU'd to spl-linux 0.6.5.6 for Xenial:

[PATCH] Fix do_div() types in condvar:timeout

The do_div() macro expects unsigned types and this is detected in
powerpc implementation of do_div().

Signed-off-by: Brian Behlendorf <email address hidden>
Closes #516

Changed in spl-linux (Ubuntu):
importance: Undecided → Medium
assignee: nobody → Colin Ian King (colin-king)
description: updated

Hello Colin, or anyone else affected,

Accepted spl-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/spl-linux/0.6.5.6-0ubuntu4 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in spl-linux (Ubuntu Xenial):
status: New → Fix Committed
Changed in spl-linux (Ubuntu):
status: New → In Progress
Changed in spl-linux (Ubuntu Xenial):
status: Fix Committed → In Progress
importance: Undecided → Medium
assignee: nobody → Colin Ian King (colin-king)
Colin Ian King (colin-king) wrote :

Tested splat tests, no failure.
Tested against zfs regression tests, no failures.

Adding verification-done tag for Xenial.

tags: added: verification-done
Chris J Arges (arges) on 2016-07-13
Changed in spl-linux (Ubuntu):
status: In Progress → Fix Released
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package spl-linux - 0.6.5.6-0ubuntu4

---------------
spl-linux (0.6.5.6-0ubuntu4) xenial; urgency=medium

  * Fix do_div() types in condvar:timeout (LP: #1599219)
    - The do_div() macro expects unsigned types and this is detected in
      powerpc implementation of do_div().
  * Only perform dep8 tests on real hardware (LP: #1599221)
    - Add isolation-machine to tests/control Restrictions as
      we need to insert/remove the spl kernel module.
    - Also restrict spl tests to 64 bit systems and don't run on 32 bit
      architectures.
    - Limit large memory splat tests on systems with plenty of memory to
      accommodate the tests.
  * Fix dep8 splat test, should be kmem:slab_align and not slab_align in
    the SPLAT_TESTS large memory test case (LP: #1599259)

 -- Colin Ian King <email address hidden> Tue, 05 Jul 2016 19:51:41 +0100

Changed in spl-linux (Ubuntu Xenial):
status: In Progress → Fix Released

The verification of the Stable Release Update for spl-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers