add dep8 tests for the scripts/check.sh SPL/SPLAT tests

[Colin Ian King]

[SRU Justification][XENIAL]

Add dep8 SPL/SPLAT regression tests from the spl source to sanity check that the SPL driver module is behaving sanely.

This SRU is to fix issues found in the MIR review, https://bugs.launchpad.net/ubuntu/+source/spl-linux/+bug/1569294/comments/2

[FIX]
Modified version of the scripts/check.sh added to the dep8 test directory

[TESTCASE]
adt-run spl-linux_0.6.5.6-0ubuntu3.dsc --- qemu --ram-size 4096 adt-xenial-amd64-cloud.img

..with the tests we now get the spl splat checks running by adt:

Loading splat
------------------------------ Running SPLAT Tests ------------------------------
                kmem:kmem_alloc Pass
                kmem:kmem_zalloc Pass
                kmem:vmem_alloc Pass
                kmem:vmem_zalloc Pass
                kmem:slab_small Pass
                kmem:slab_large Pass
                kmem:slab_align Pass
                kmem:slab_reap Pass
                kmem:slab_age Pass
                kmem:slab_lock Pass
               taskq:single Pass
               taskq:multiple Pass
               taskq:system Pass
               taskq:wait Pass
               taskq:front Pass
               taskq:recurse Pass
               taskq:contention Pass
               taskq:delay Pass
               taskq:cancel Pass
               taskq:dynamic Pass
                krng:freq Pass
               mutex:tryenter Pass
               mutex:race Pass
               mutex:owned Pass
               mutex:owner Pass
             condvar:signal1 Pass
             condvar:broadcast1 Pass
             condvar:signal2 Pass
             condvar:broadcast2 Pass
             condvar:timeout Pass
              thread:create Pass
              thread:exit Pass
              thread:tsd Pass
              rwlock:N-rd/1-wr Pass
              rwlock:0-rd/N-wr Pass
              rwlock:held Pass
              rwlock:tryenter Pass
              rwlock:rw_downgrade Pass
              rwlock:rw_tryupgrade Pass
                time:time1 Pass
                time:time2 Pass
               vnode:vn_open Pass
               vnode:vn_openat Pass
               vnode:vn_rdwr Pass
               vnode:vn_getattr Pass
               vnode:vn_sync Pass
                kobj:open Pass
                kobj:size/read Pass
              atomic:64-bit Pass
                list:create/destroy Pass
                list:ins/rm head Pass
                list:ins/rm tail Pass
                list:insert_after Pass
                list:insert_before Pass
                list:remove Pass
                list:active Pass
             generic:ddi_strtoul Pass
             generic:ddi_strtol Pass
             generic:ddi_strtoull Pass
             generic:ddi_strtoll Pass
             generic:udivdi3 Pass
             generic:divdi3 Pass
                cred:cred Pass
                cred:kcred Pass
                cred:groupmember Pass
                zlib:compress/uncompress Pass
               linux:shrinker Pass
Unloading splat
Unloading spl
adt-run [12:35:55]: test check.sh: -----------------------]
adt-run [12:35:56]: test check.sh: - - - - - - - - - - results - - - - - - - - - -
check.sh PASS
adt-run [12:35:57]: @@@@@@@@@@@@@@@@@@@@ summary
dkms-test PASS
check.sh PASS

[Colin Ian King (colin-king)]

Package is in https://launchpad.net/~colin-king/+archive/ubuntu/zfs-0.6.5.6-beta for perusal

[Seth Arnold (seth-arnold)]

Nice! I skimmed the debdiffs, they looked good to me.

Thanks

[Adam Conrad (adconrad)]

Hello Colin, or anyone else affected,

Accepted spl-linux into xenial-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/spl-linux/0.6.5.6-0ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Colin Ian King (colin-king)]

Tested, verified adt tests work as expected, see attached log.

[Richard Laager (rlaager)]

Has this been fixed in yakkety? I'm not seeing it in the change log. The SRU process requires yakkety be fixed first.

[Colin Ian King (colin-king)]

Working on it

[Colin Ian King (colin-king)]

currently in yakkety -proposed https://launchpad.net/ubuntu/+source/spl-linux/0.6.5.7-0ubuntu2

[Brian Murray (brian-murray)]

There seem to be some autopkgtest failures with the SRU.

http://autopkgtest.ubuntu.com/packages/s/spl-linux/xenial/armhf/

http://autopkgtest.ubuntu.com/packages/s/spl-linux/xenial/s390x/

Could somebody look into these?

[Brian Murray (brian-murray)]

Setting to v-needed pending the investigation of the autopkgtests.

[Colin Ian King (colin-king)]

I'm tempted to disabled the tests on 32 bit arm arches as we don't support these.

As for the s390x failure, I'll try and get some idea why EPERM is failing, which is totally unexpected.

[Launchpad Janitor (janitor)]

This bug was fixed in the package spl-linux - 0.6.5.7-0ubuntu3

---------------
spl-linux (0.6.5.7-0ubuntu3) yakkety; urgency=medium

  * Only perform dep8 tests on real hardware (LP: #1586314)
    - Add isolation-machine, breaks-testbed to tests/control Restrictions as
      we need to insert/remove the spl kernel module.
    - Also restrict spl tests to 64 bit systems as that all we support for
      ZFS

 -- Colin Ian King <email address hidden> Fri, 27 May 2016 10:08:10 +0100

[Colin Ian King (colin-king)]

Not sure why I missed this, but it looks good for Xenial in the -proposed pocket too (https://launchpad.net/ubuntu/+source/spl-linux/0.6.5.6-0ubuntu3)

[Launchpad Janitor (janitor)]

This bug was fixed in the package spl-linux - 0.6.5.6-0ubuntu3

---------------
spl-linux (0.6.5.6-0ubuntu3) xenial; urgency=medium

  * Enable the spl/splat tests to exercise the SPL kernel module (LP: #1579036)

 -- Colin Ian King <email address hidden> Fri, 06 May 2016 12:45:12 +0100

[Martin Pitt (pitti)]

The verification of the Stable Release Update for spl-linux has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.