| 2019-06-26 06:50:47 |
Christian Ehrhardt |
description |
After the merge of 14.2 I realized that the autopkgtests failed.
There are a few changes required that are due to the new version.
- d/t/automated-tests: spice-common moved into dir subprojects
- d/t/automated-tests: option --enable-automated-tests now is always on"
- d/t/automated-tests, d/t/control: make tests more debuggable by allowing
stderr
- d/t/control: install new test dependency python-pil
- d/t/base_test.ppm, d/t/regression-test.py: provide test resources from
upstream git not part of the released tarball anymore
- d/source/include-binaries: allow binary base_test.ppm in package
Of these particularly interesting is that the python script and the image files are not even part of the release tarball anymore. So I wonder if this is really supposed to still be run that way.
I got it resolved to "run" the test but it complained about an image mismatch.
[...]
req_cursor_notification
wrote screen shot to output.ppm
FAIL: Regressions were found!
Please, take a look in your code and go fix it!
(process:21472): Spice-WARNING **: 08:00:30.990: Connection reset by peer
(process:21472): Spice-WARNING **: 08:00:31.136: Connection reset by peer
set_client_capabilities: present 0 caps 0
client_monitors_config: NULL monitors_config
There were plenty of changes to this test to make it work on windows, I wonder if one of them might have broken it - at least in the way we used to execute it.
The images it generates are reproducible, but don't match.
Since I had to tweak quite a lot to get it running in the first place I'm not entirely sure the test is valid at the moment.
Therefore I'll upload the test fixes to run them (but it will ignore this error for now).
=> https://code.launchpad.net/~paelzer/ubuntu/+source/spice/+git/spice/+merge/369300
To eventually resolve this I will report the problem upstream and depending on the outcome of that discussion we can fix our usage of the test OR drop it completely if it is no more meant to be run that way. |
After the merge of 14.2 I realized that the autopkgtests failed.
There are a few changes required that are due to the new version.
- d/t/automated-tests: spice-common moved into dir subprojects
- d/t/automated-tests: option --enable-automated-tests now is always on"
- d/t/automated-tests, d/t/control: make tests more debuggable by allowing
stderr
- d/t/control: install new test dependency python-pil
- d/t/base_test.ppm, d/t/regression-test.py: provide test resources from
upstream git not part of the released tarball anymore
- d/source/include-binaries: allow binary base_test.ppm in package
Of these particularly interesting is that the python script and the image files are not even part of the release tarball anymore. So I wonder if this is really supposed to still be run that way.
I got it resolved to "run" the test but it complained about an image mismatch.
[...]
req_cursor_notification
wrote screen shot to output.ppm
FAIL: Regressions were found!
Please, take a look in your code and go fix it!
(process:21472): Spice-WARNING **: 08:00:30.990: Connection reset by peer
(process:21472): Spice-WARNING **: 08:00:31.136: Connection reset by peer
set_client_capabilities: present 0 caps 0
client_monitors_config: NULL monitors_config
There were plenty of changes to this test to make it work on windows, I wonder if one of them might have broken it - at least in the way we used to execute it.
The images it generates are reproducible, but don't match.
Since I had to tweak quite a lot to get it running in the first place I'm not entirely sure the test is valid at the moment.
See comment #3 below for details on the old behavior which also was incomplete running the test but not comparing output at all.
Therefore I'll upload the test fixes to run them (but it will ignore this error for now) - which is exactly the old state.
=> https://code.launchpad.net/~paelzer/ubuntu/+source/spice/+git/spice/+merge/369300
To eventually resolve this I will report the problem upstream and depending on the outcome of that discussion we can fix our usage of the test OR drop it completely if it is no more meant to be run that way. |
|
