Comment 0 for bug 1925351

Revision history for this message
Eric Desrochers (slashd) wrote : [networking] dpdk port flapping observed during sosreport execution

[IMPACT]

sosreport networking plugin unconditionally exercise 'ethtool -e.

EEPROM dump collection might hang on specific types of devices,

ETHTOOL(8)
       -e --eeprom-dump
              Retrieves and prints an EEPROM dump for the specified network device. When raw is enabled, then it dumps the raw EEPROM data to stdout. The length and offset parameters allow dumping certain portions of the EEPROM. Default is to dump the entire EEPROM.

[TEST CASE]

* On a xenial system
* sosreport -o networking

[WHERE PROBLEM OCCURS]

No problem expected.

networking plugin will be gated to prevent 'ethtool -e' to be run by default, so that

sosreport -o networking will not execute 'ethtool -e' command.
On the other end, if one really want to eepromdump, one can use the 'eepromdump' plugin option as follows:

sosreport -o networking --plugin-option networking.eepromdump

So we are changing the default behaviour, but the former one is still available if *REALLY* needed, and knowing the risk that this can occurs.

[OTHER INFORMATION]

Upstream fix:
https://github.com/sosreport/sos/commit/bc3b7eefa093af150286ad6c345cef6afe282756