[conntrackd][plugin] add conntrack info

Bug #1898077 reported by Eric Desrochers
14
This bug affects 1 person
Affects Status Importance Assigned to Milestone
sosreport (Ubuntu)
Fix Released
Low
Hemanth Nakkina
Bionic
Fix Released
Low
Mauricio Faria de Oliveira
Focal
Fix Released
Low
Mauricio Faria de Oliveira
Groovy
Fix Released
Low
Mauricio Faria de Oliveira
Hirsute
Fix Released
Low
Hemanth Nakkina

Bug Description

[Impact]

* The plugin conntrackd is renamed to conntrack.
  (enabled automatically per installed packages.)

* Added the following conntrack commands to the plugin,
  which run on default and other network namespaces:

  conntrack -L -o extended
  conntrack -S

[Test Case]

* Install sosreport

* sosreport -a will exercise 'conntrack' plugin if one of the following packages installation is met: ('conntrack-tools', 'conntrack', 'conntrackd'),

* Alternative way to exercise the plugin :
  ** 'sosreport -o conntrack'
  ** 'sos report -o conntrack'

* Then a sosreport tarball will be generated under /tmp

* Extract that said tarball, and look under /path_to_sosreport/sos_commands/conntrack/

And one should see 2 new files, one for each new commands added by this command, for the default and other network namespaces.

[Regression Potential]

* The plugin is renamed from 'conntrackd' to 'conntrack'.
If one has a plugin_options in /etc/sos/sos.conf specific to former name 'conntrackd' (e.g skip the plugin, enable the plugin, ...) well it won't be effective anymore, and one would need to update their config file to reflect new reality of the plugin name change. But it's very uncommon to see users using such plugin options. Very unlikely to happen.

* conntrack -L -o extended
Show the connection tracking table in /proc/net/nf_conntrack format

* conntrack -S
       -S, --stats
              Show the in-kernel connection tracking system statistics.

The new commands addition are harmless, and if a problem arise it will be isolated to the 'conntrack' plugin and won't affect other plugins nor sosreport core functionalities.

[Other Info]

Closes: https://github.com/sosreport/sos/issues/2049
Origin: https://github.com/sosreport/sos/commit/e6af5287b6bde901690c58090f958960a536660a
Resolves: https://github.com/sosreport/sos/pull/2251

Eric Desrochers (slashd)
tags: added: seg sts
Revision history for this message
Eric Desrochers (slashd) wrote :

@hemanth @hillpd

Could you work at producing a debdiff for g/f/b when your time permit ?

I'll be happy to sponsor the patch.

Regards,
Eric

Changed in sosreport (Ubuntu):
assignee: nobody → Hemanth Nakkina (hemanth-n)
Changed in sosreport (Ubuntu Bionic):
assignee: nobody → Hemanth Nakkina (hemanth-n)
Changed in sosreport (Ubuntu Focal):
assignee: nobody → Hemanth Nakkina (hemanth-n)
Changed in sosreport (Ubuntu Bionic):
importance: Undecided → Low
Changed in sosreport (Ubuntu):
importance: Undecided → Low
Changed in sosreport (Ubuntu Focal):
importance: Undecided → Low
Eric Desrochers (slashd)
description: updated
description: updated
description: updated
description: updated
Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :
Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :
Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :
Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :

Updated with debdiffs for groovy, focal and bionic

Revision history for this message
Ubuntu Foundations Team Bug Bot (crichton) wrote :

The attachment "lp1898077_groovy.debdiff" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

tags: added: patch
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Hi Hemanth,

Thanks for the work on this.

Are the commands run by network namespace, as say, in the networking plugin?
(I'm not familiar w/ sosreport arch, so couldn't tell from the patch itself.)

I know you're familiar with the use case e.g. openstack/neutron deployments,
but just for doc purposes, there are diff network namespaces for routers/etc,
which have different conntrack info (otherwise missed in non-ns conntrack -L.)

If it's not per-ns yet, I'd be happy to try to help on that as first-time
sosreport contribution; just let me know; but feel free to tackle that if
you'd like.

Thanks!
Mauricio

Revision history for this message
Hemanth Nakkina (hemanth-n) wrote :

Hi Mauricio

Its a valid point which i missed to include conntrack info for all the network namespaces. And yes the commands run by network namespace are in networking plugin [1]
But conntrack information for the network namespaces can be implemented in conntrack plugin itself.
Please go ahead and submit a PR.

For reference, bug link raised for conntrack on sos [2]

Thanks!

[1] https://github.com/sosreport/sos/blob/master/sos/report/plugins/networking.py#L231-L305
[2] https://github.com/sosreport/sos/issues/2049

Changed in sosreport (Ubuntu):
status: New → In Progress
Changed in sosreport (Ubuntu Bionic):
status: New → In Progress
Changed in sosreport (Ubuntu Focal):
status: New → In Progress
Changed in sosreport (Ubuntu Groovy):
status: New → In Progress
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Hi,

Sorry for the delay; today I looked into this and found a couple of issues and improvements to be done on sosreport.

I should send PRs soon.

cheers,
Mauricio

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

PRs submitted:

#2306 [1] for a fundamental issue (not required), and
#2308 [2] for code deduplication and conntrack per-ns commands.

[1] https://github.com/sosreport/sos/pull/2306
[2] https://github.com/sosreport/sos/pull/2308

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

The sosreport PRs have been merged.

For conntrack per-namespace data, we only need one patch from PR #2308.
The other patches are refactoring, not that needed for stable releases.

Attaching debdiffs.

...

I was originally a bit concerned with the rename of the conntrack_d_
plugin to conntrack (no trailing 'd') for some script that hardcoded
it, and having that change in stable releases.

However, after searching for 'ubuntu AND conntrackd' it turns out to
be very unpopular, plus results seemed to be in the Xenial timeframe,
which is not being changed here.

So I guess since it's been an upstream-backed decision, and it might
be OK to hear about use-cases if someone reports a bug about it then,
let's move on.

Just wanted to document/mention this flag here for others to comment.

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Testing done on H/G/F/B; the conntrack plugin now collects
the output of two conntrack commands, including namespaces.

(the files listed are identical across all releases above.)

$ sudo ip netns add ns1
$ sudo ip netns add ns2
$ sudo ip netns add ns3

$ ip netns
ns3
ns2
ns1

$ sudo apt install -y conntrack
$ sudo sosreport -o conntrack --batch

$ sudo tar tf /tmp/sosreport-*.tar.xz | grep sos_commands | cut -d/ -f2-
sos_commands/
sos_commands/conntrack/
sos_commands/conntrack/conntrack_-L_-o_extended
sos_commands/conntrack/conntrack_-S
sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

@slashd

Hey Eric, could you please review/sponsor the debdiff for Hirsute?

I can take care of the stable releases if you are happy with that.

Thanks,
Mauricio

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

P.S.: I have test builds queued on all archs in ppa:mfo/lp1898077 [1].

It's waiting on maintenance to start building; but it built fine here,
and it's python, so hopefully the different archs should go fine too.

[1] https://launchpad.net/~mfo/+archive/ubuntu/lp1898077

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

The packages built successfully on all architectures in the PPA.

Revision history for this message
Eric Desrochers (slashd) wrote :

[sts-sponsors]

Sponsored in devel release (hirsute).

Note: I still have to upgrade sosreport in Bionic which, as of today, uses 3.9.1 while Focal onwards uses 4.X.

@mfo, I would suggest you stop the SRU sponsoring at Focal (basically the 4.X series), and let me take care of Bionic/18.04LTS when I'll upgrade sosreport to 4.X beginning of 2021.

Changed in sosreport (Ubuntu Bionic):
assignee: Hemanth Nakkina (hemanth-n) → Eric Desrochers (slashd)
Eric Desrochers (slashd)
Changed in sosreport (Ubuntu Bionic):
assignee: Eric Desrochers (slashd) → Hemanth Nakkina (hemanth-n)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.0-1ubuntu4

---------------
sosreport (4.0-1ubuntu4) hirsute; urgency=medium

  [Hemanth Nakkina]
  * d/p/0009-conntrack-add-conntrack-info.patch: rename the
    conntrackd plugin to conntrack; add conntrack commands.
    (LP: #1898077)

  [Mauricio Oliveira]
  * d/p/0010-conntrack-gather-per-namespace-data.patch: add
    conntrack commands for network namespaces.

 -- Mauricio Faria de Oliveira <email address hidden> Mon, 23 Nov 2020 15:10:12 -0300

Changed in sosreport (Ubuntu Hirsute):
status: In Progress → Fix Released
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Attaching updated debdiffs that include bug 1901555.

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :
Changed in sosreport (Ubuntu Groovy):
assignee: Hemanth Nakkina (hemanth-n) → Mauricio Faria de Oliveira (mfo)
Changed in sosreport (Ubuntu Focal):
assignee: Hemanth Nakkina (hemanth-n) → Mauricio Faria de Oliveira (mfo)
Changed in sosreport (Ubuntu Bionic):
assignee: Hemanth Nakkina (hemanth-n) → Mauricio Faria de Oliveira (mfo)
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Packages built successfully for all architectures on ppa:mfo/lp1898077-lp1901555.

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification for test packages on Groovy.
===

$ sudo ip netns add ns1
$ sudo ip netns add ns2
$ sudo ip netns add ns3

$ ip netns
ns3
ns2
ns1

$ sudo apt install conntrack conntrackd

$ lsb_release -cs
groovy

Before: (no conntrack files; only conntrackd)
------

$ dpkg -s sosreport | grep -i version:
Version: 4.0-1ubuntu2

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_cache
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_ct
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_expect
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_link
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_network
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_queue
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_rsqueue
sosreport-groovy-2020-12-29-tpjjhqx/sos_commands/conntrackd/conntrackd_-s_runtime

$ sudo rm /tmp/sosreport-*.xz

After: (new conntrack files!)
-----

$ dpkg -s sosreport | grep -i version:
Version: 4.0-1ubuntu2.1

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrack_-L_-o_extended
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrack_-S
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_cache
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_ct
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_expect
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_link
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_network
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_queue
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_rsqueue
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/conntrackd_-s_runtime
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sosreport-groovy-2020-12-29-stewcwc/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

$ sudo rm /tmp/sosreport-*.xz

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification for test packages on Focal.
===

$ sudo ip netns add ns1
$ sudo ip netns add ns2
$ sudo ip netns add ns3

$ ip netns
ns3
ns2
ns1

$ sudo apt install conntrack conntrackd

$ lsb_release -cs
focal

Before: (no conntrack files; only conntrackd)
---

$ dpkg -s sosreport | grep -i version:
Version: 4.0-1~ubuntu0.20.04.2

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_cache
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_ct
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_expect
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_link
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_network
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_queue
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_rsqueue
sosreport-focal-2020-12-29-ngoohaj/sos_commands/conntrackd/conntrackd_-s_runtime

$ sudo rm /tmp/sosreport-*.xz

After: (new conntrack files!)
---

$ dpkg -s sosreport | grep -i version:
Version: 4.0-1~ubuntu0.20.04.3

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrack_-L_-o_extended
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrack_-S
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_cache
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_ct
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_expect
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_link
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_network
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_queue
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_rsqueue
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/conntrackd_-s_runtime
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sosreport-focal-2020-12-29-vybyhjy/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

$ sudo rm /tmp/sosreport-*.xz

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification for test packages on Bionic.
===

$ sudo ip netns add ns1
$ sudo ip netns add ns2
$ sudo ip netns add ns3

$ ip netns
ns3
ns2
ns1

$ sudo apt install conntrack conntrackd

$ lsb_release -cs
bionic

Before: (no conntrack files; only conntrackd)
---

$ dpkg -s sosreport | grep -i version:
Version: 3.9.1-1ubuntu0.18.04.2

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_rsqueue
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_runtime
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_cache
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_link
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_network
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_expect
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_ct
sosreport-bionic-2020-12-29-csevyci/sos_commands/conntrackd/conntrackd_-s_queue

$ sudo rm /tmp/sosreport-*.xz

After: (new conntrack files!)
---

$ dpkg -s sosreport | grep -i version:
Version: 3.9.1-1ubuntu0.18.04.3

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack | sort
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrack_-L_-o_extended
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrack_-S
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_cache
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_ct
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_expect
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_link
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_network
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_queue
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_rsqueue
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/conntrackd_-s_runtime
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sosreport-bionic-2020-12-29-maeovkn/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

$ sudo rm /tmp/sosreport-*.xz

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Sponsored to F/G/B.

tags: added: sts-sponsor-mfo
description: updated
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Eric, or anyone else affected,

Accepted sosreport into groovy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.0-1ubuntu2.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-groovy to verification-done-groovy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-groovy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Groovy):
status: In Progress → Fix Committed
tags: added: verification-needed verification-needed-groovy
Changed in sosreport (Ubuntu Focal):
status: In Progress → Fix Committed
tags: added: verification-needed-focal
Revision history for this message
Robie Basak (racb) wrote :

Hello Eric, or anyone else affected,

Accepted sosreport into focal-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/4.0-1~ubuntu0.20.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-focal to verification-done-focal. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-focal. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Changed in sosreport (Ubuntu Bionic):
status: In Progress → Fix Committed
tags: added: verification-needed-bionic
Revision history for this message
Robie Basak (racb) wrote :

Hello Eric, or anyone else affected,

Accepted sosreport into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/sosreport/3.9.1-1ubuntu0.18.04.3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

Revision history for this message
Robie Basak (racb) wrote :

> If one has a plugin_options in /etc/sos/sos.conf specific to former name 'conntrackd' (e.g skip the plugin, enable the plugin, ...) well it won't be effective anymore, and one would need to update their config file to reflect new reality of the plugin name change. But it's very uncommon to see users using such plugin options. Very unlikely to happen.

Thank you for calling this out. For a normal package I don't think this would be acceptable as it's straightforward to simply not rename the plugin in the SRU. But for sosreport I think it's OK, given that it's run manually by users only in special circumstances and as you say it's unlikely that this will actually affect anyone.

> + # Collect info from conntrackd

This change seems to have disappeared in the backport to Bionic, but it doesn't matter so I left it.

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

>> + # Collect info from conntrackd
>
> This change seems to have disappeared in the backport to Bionic, but it doesn't matter so I left it.

Nice catch; I missed that one, sorry.
Thanks for the flexibility with that.

Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification done for focal-proposed.

The conntrack default ns and per-ns files for 'conntrack -L' and 'conntrack -S' are now present.

$ echo "deb http://archive.ubuntu.com/ubuntu $(lsb_release -cs)-proposed main universe" \
    | sudo tee /etc/apt/sources.list.d/proposed.list \
    && sudo apt update \
    && sudo apt install -y sosreport conntrack conntrackd

$ sudo ip netns add ns1 && sudo ip netns add ns2 && sudo ip netns add ns3

$ sudo ip netns
ns3
ns2
ns1

$ lsb_release -cs
focal

$ dpkg -s sosreport | grep Version:
Version: 4.0-1~ubuntu0.20.04.3

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack | sort
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrack_-L_-o_extended
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrack_-S
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_cache
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_ct
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_expect
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_link
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_network
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_queue
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_rsqueue
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/conntrackd_-s_runtime
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sosreport-mfo-sos-f-2021-01-06-imeiaft/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

tags: added: verification-done-focal
removed: verification-needed-focal
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification done for groovy-proposed.

The conntrack default ns and per-ns files for 'conntrack -L' and 'conntrack -S' are now present.

$ echo "deb http://archive.ubuntu.com/ubuntu $(lsb_release -cs)-proposed main universe" \
    | sudo tee /etc/apt/sources.list.d/proposed.list \
    && sudo apt update \
    && sudo apt install -y sosreport conntrack conntrackd

$ sudo ip netns add ns1 && sudo ip netns add ns2 && sudo ip netns add ns3

$ sudo ip netns
ns3
ns2
ns1

$ lsb_release -cs
groovy

$ dpkg -s sosreport | grep Version:
Version: 4.0-1ubuntu2.1

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack | sort
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrack_-L_-o_extended
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrack_-S
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_cache
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_ct
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_expect
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_link
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_network
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_queue
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_rsqueue
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/conntrackd_-s_runtime
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sosreport-mfo-sos-g-2021-01-06-wkdqtsk/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

tags: added: verification-done-groovy
removed: verification-needed-groovy
Revision history for this message
Mauricio Faria de Oliveira (mfo) wrote :

Verification done for bionic-proposed.

The conntrack default ns and per-ns files for 'conntrack -L' and 'conntrack -S' are now present.

$ echo "deb http://archive.ubuntu.com/ubuntu $(lsb_release -cs)-proposed main universe" \
    | sudo tee /etc/apt/sources.list.d/proposed.list \
    && sudo apt update \
    && sudo apt install -y sosreport conntrack conntrackd

$ sudo ip netns add ns1 && sudo ip netns add ns2 && sudo ip netns add ns3

$ sudo ip netns
ns3
ns2
ns1

$ lsb_release -cs
bionic

$ dpkg -s sosreport | grep Version:
Version: 3.9.1-1ubuntu0.18.04.3

$ sudo sosreport --batch

$ sudo tar tf /tmp/sosreport-*.xz | grep sos_commands/conntrack | sort
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrack_-L_-o_extended
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrack_-S
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_cache
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_ct
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_expect
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_link
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_network
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_queue
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_rsqueue
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/conntrackd_-s_runtime
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-L_-o_extended
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/ip_netns_exec_ns1_conntrack_-S
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-L_-o_extended
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/ip_netns_exec_ns2_conntrack_-S
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-L_-o_extended
sosreport-mfo-sos-b-2021-01-06-kyiprqo/sos_commands/conntrack/ip_netns_exec_ns3_conntrack_-S

tags: added: verification-done-bionic
removed: verification-needed-bionic
tags: added: verification-done
removed: verification-needed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.0-1ubuntu2.1

---------------
sosreport (4.0-1ubuntu2.1) groovy; urgency=medium

  [Hemanth Nakkina]
  * d/p/0008-conntrack-add-conntrack-info.patch: rename the
    conntrackd plugin to conntrack; add conntrack commands.
    (LP: #1898077)

  [Mauricio Oliveira]
  * d/p/0009-conntrack-gather-per-namespace-data.patch: add
    conntrack commands for network namespaces.
    (LP 1898077)

  [Edward Hope-Morley]
  * d/p/0010-networking-include-ns-ip-neigh-and-ip-rule-info.patch:
    add ip neigh and ip rule commands for network namespaces.
    (LP: #1901555)

 -- Mauricio Faria de Oliveira <email address hidden> Tue, 29 Dec 2020 16:00:00 -0300

Changed in sosreport (Ubuntu Groovy):
status: Fix Committed → Fix Released
Revision history for this message
Łukasz Zemczak (sil2100) wrote : Update Released

The verification of the Stable Release Update for sosreport has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 4.0-1~ubuntu0.20.04.3

---------------
sosreport (4.0-1~ubuntu0.20.04.3) focal; urgency=medium

  [Hemanth Nakkina]
  * d/p/0008-conntrack-add-conntrack-info.patch: rename the
    conntrackd plugin to conntrack; add conntrack commands.
    (LP: #1898077)

  [Mauricio Oliveira]
  * d/p/0009-conntrack-gather-per-namespace-data.patch: add
    conntrack commands for network namespaces.
    (LP 1898077)

  [Edward Hope-Morley]
  * d/p/0010-networking-include-ns-ip-neigh-and-ip-rule-info.patch:
    add ip neigh and ip rule commands for network namespaces.
    (LP: #1901555)

 -- Mauricio Faria de Oliveira <email address hidden> Tue, 29 Dec 2020 16:16:45 -0300

Changed in sosreport (Ubuntu Focal):
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package sosreport - 3.9.1-1ubuntu0.18.04.3

---------------
sosreport (3.9.1-1ubuntu0.18.04.3) bionic; urgency=medium

  [Hemanth Nakkina]
  * d/p/0005-conntrack-add-conntrack-info.patch: rename the
    conntrackd plugin to conntrack; add conntrack commands.
    (LP: #1898077)

  [Mauricio Oliveira]
  * d/p/0006-conntrack-gather-per-namespace-data.patch: add
    conntrack commands for network namespaces.
    (LP 1898077)

  [Edward Hope-Morley]
  * d/p/0007-networking-include-ns-ip-neigh-and-ip-rule-info.patch:
    add ip neigh and ip rule commands for network namespaces.
    (LP: #1901555)

 -- Mauricio Faria de Oliveira <email address hidden> Tue, 29 Dec 2020 16:30:50 -0300

Changed in sosreport (Ubuntu Bionic):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.