[plugin][snappy] Collect 'state.json' which may contain sensitive information (macaroons)

[Michael Vogt]

[Impact]

[Test Case]

[Regression Potential]

[Other Info]

[Original Description]

Please include the "journalctl -u snapd" output and /var/lib/snapd/state.json if possible. This will allow easier debugging of snap related issues.

Please note that the content of /var/lib/snapd/state.json may contain sensitive information (macaroons) so this data needs to be handled with care or we need to provide a way to scrub this data.

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Eric Desrochers (slashd)]

@mvo,

The 'snappy.py' plugin already provides the journal via 'add_journal()'[0] method producing the following: 'sos_commands/snappy/journalctl_--no-pager_--unit_snapd'

Note that this is already part of every supported Ubuntu stable release.

It would only be a matter of collecting '/var/lib/snapd/state.json' as suggested while not revealing sensitive information.

- Eric

[0] - https://github.com/sosreport/sos/blob/master/sos/report/plugins/snappy.py#L29

[Eric Desrochers (slashd)]

@mvo, I have reported the request upstream:

https://github.com/sosreport/sos/issues/2241

I'll work on it when my time permits.

Regards,
Eric

[Adam Bell (arbell)]

PR (currently draft) created: https://github.com/sosreport/sos/pull/2257; once we confirm that all the necessary fields are omitted/removed, I'll make the PR official for the sos team to review.

[Eric Desrochers (slashd)]

@Adam,

Any update on your upstream work ?

Regards,
Eric

[Brian Murray (brian-murray)]

The Groovy Gorilla has reached end of life, so this bug will not be fixed for that release

[Arif Ali (arif-ali)]

This has now been implemented upstream

This will be targeting the 4.7.0 release of sosreport which is due upstream 19th February