Meaning and function of 'Revert' ambiguous (particularly wrt "Download from:")

[Jani Uusitalo]

I've specified three different specific cases to demonstrate what I mean by the title, below. I could have filed three different bite-sized bugs, but all in all I believe they are part of the generic accessibility problem with the 'Revert' button that could be fixed in one go. (If the developers think otherwise, I'll be happy to split this into different reports.)

When you first run Software Sources, 'Revert' is ghosted as it probably should, implying no changes have been made that could be reverted.

Issue #1:
Steps to reproduce:
When Download from: is pointing at main servers, change it to something else and 'Revert' becomes active. Now click 'Revert', and main servers are restored as Download from: site.

What happens:
'Revert' stays active, implying there are still changes left to revert. Clicking it does nothing of course, as all changes have just been reverted.

What should happen:
'Revert' should become ghosted once pressed after becoming active.

Issue #2:
Steps to reproduce:
Point Download from: to your local mirror (other than main servers). Close Software Sources. Start it again. 'Revert' is now ghosted, implying there are again no changes to be reverted. Point Download from: to a third mirror, and 'Revert' becomes active. Click 'Revert'.

What happens:
Download from: now points to main servers.

What should happen:
I'd expect it to point to my local mirror, which was the initial state opening the window.

Issue #3:
Perhaps 'Revert' wrt the Download from: site means not reverting back to initial state of this SS session, but reverting back to the very initial state of pointing to main servers. But in that case, 'Revert' should *not* be ghosted when Software Sources starts with Download from: pointing somewhere else, as it just did.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: software-properties-gtk 0.82.2
ProcVersionSignature: Ubuntu 3.2.0-8.14-generic 3.2.0
Uname: Linux 3.2.0-8-generic x86_64
ApportVersion: 1.90-0ubuntu1
Architecture: amd64
CheckboxSubmission: 09ae689090491ca53449589269e4bfd8
CheckboxSystem: edda5d4f616ca792bf437989cb597002
Date: Wed Jan 11 21:10:58 2012
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 9.10 "Karmic Koala" - Release amd64 (20091027)
PackageArchitecture: all
SourcePackage: software-properties
UpgradeStatus: Upgraded to precise on 2011-12-22 (20 days ago)