software-properties-gtk "close" and "revert" buttons are too small

Bug #515990 reported by Alessio Bolognino on 2010-02-02
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Software Properties
Fix Released
Undecided
Unassigned
software-properties (Ubuntu)
Undecided
Unassigned

Bug Description

software-properties-gtk seems to use non-standard "Close" and "Revert" buttons, they are too small, especially if no icon is shown along the label in the buttons.

I'll attach a screenshot, notice how smaller are buttons in software-properties-gtk than the ones in Appearance Preferences. And yes, it seems to affect "Revert" and "Close" buttons only.

It's not a big deal, but it's annoying.

Related branches

Alessio Bolognino (themolok) wrote :
Alessio Bolognino (themolok) wrote :

I linked a branch that should fix the problem. I only changed the main.glade file, it shouldn't break anything else, but you never know.

Michael Vogt (mvo) wrote :

Hello, many thanks for the branch. Unfortunately its a huge diff, I would prefer to know what was changed before I apply it.

Alessio Bolognino (themolok) wrote :

You are right, the diff is huge, but I really don't know why. I just made a couple of changes with Glade. Just opening main.glade with Glade (3.6.7) and saving it (without making any changes) changes the file quite a lot.

I just removed hbox11 and added a new one with two columns and one gtkhbuttonbox for each column. One button on the left (help) and two on the right (revert and close); I also adjusted the padding of the gtkhbuttonboxes . It's 5 minutes of work.

I could have changed the file by hand, but it's XML and it's very messy.

Alessio Bolognino (themolok) wrote :

After more investigation, it looks like there are differences between on how glade 3.[4-5].x and 3.6.7 handle defaults properties, if someone had a working glade 3.[4-5].x installation, he could generate a much smaller diff. Sadly this is my only machine. The glade file is also affected by this [1] bug, on glade 3.6.7: it looks like all the vbox are treated like hbox. The application itself still works fine, but it is my understanding it could be broken with future versions of GTK+ (I may be wrong on this though).

[1] https://bugzilla.gnome.org/show_bug.cgi?id=594231

BrandonTomlinson (druke) wrote :

Here is a patch I did. I didn't use glade at all, so i don't have to worry about messing up the format.

(my first patch, ever, so sorry if I did something wrong)

BrandonTomlinson (druke) wrote :

Did a redo: the hbutton box was a much better method. I did it all by hand again so still don't have any glade version collisions. My new diff is up top.

BrandonTomlinson (druke) wrote :
BrandonTomlinson (druke) wrote :
BrandonTomlinson (druke) on 2010-04-17
Changed in software-properties:
status: New → Fix Committed
Changed in software-properties (Ubuntu):
status: New → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.76

---------------
software-properties (0.76) maverick; urgency=low

  [ Jonathan Harker ]
  * Improve documentation for apt-add-repository (LP: #586790)

  [ mac9416 ]
  * Fixed bug LP: #446216: added --remove option to add-apt-reporitory.
  * Fixed Bug LP: #579669 which points out that add-apt-repository will
    create a sources.list.d file with illegal characters
    if there are illegal characters in a PPA name

  [ Andrea Corbellini ]
  * Automatically create a deb-src line when adding a new repository
    (LP: 399711)

  [ Michael Vogt ]
  * add test for LP: #579669 and use re.sub() instead of urllib.quote()
  * merged lp:~alexzak/software-properties/fixes, many thanks

  [ Erik B. Andersen ]
  * Fixed depreciation warnings

  [ Brandon Tomlinson ]
  * Altered data/glade/main.glade Put the bottom buttons in a button box
    to make the buttons assume the correct width (LP: #515990)
 -- Michael Vogt <email address hidden> Fri, 13 Aug 2010 17:38:45 +0200

Changed in software-properties (Ubuntu):
status: Fix Committed → Fix Released
Vish (vish) on 2010-11-27
Changed in software-properties:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.