software-properties-gtk crashed with TypeError in on_driver_selection_changed(): Expected a string or a pair of strings

Bug #1969460 reported by Shih-Yuan Lee
102
This bug affects 13 people
Affects Status Importance Assigned to Milestone
OEM Priority Project
Fix Released
High
Shih-Yuan Lee
software-properties (Ubuntu)
Fix Released
High
Alberto Milone
Jammy
Fix Released
High
Alberto Milone

Bug Description

- Impact

software-properties-gtk hit an exception when dealing some drivers

- Test Case

On a Dell XPS 13 9320 enable ppa:oem-solutions-group/intel-ipu6 and try to install libcamhal-ipu6ep0 using software-properties-gtk

https://errors.ubuntu.com/problem/d3c26abd1d80970615ad06cff24972cee3001e57 should not include reports on the new version

- Regression potential

The change make the driver code ignore one extra type of error, it shouldn't impact on any of the already working cases. Ensure that drivers that were hitting the error correctly install now

[racb] It's possible that we accidentally catch and hide a real error due to an unrelated TypeError exception being raised inside the try block.

--------------------

1) The release of Ubuntu you are using, via 'lsb_release -rd' or System -> About Ubuntu
Ubuntu 22.04

2) The version of the package you are using, via 'apt-cache policy pkgname' or by checking in Software Center
 software-properties-gtk 0.99.22

3) What you expected to happen
No crash when using Additional Drivers with ppa:oem-solutions-group/intel-ipu6 on Dell XPS 13 9320
It can install libcamhal-ipu6ep0 from Additional Drivers without any problem.

4) What happened instead
It crashed when selecting libcamhal-ipu6ep0 in Additional Drivers

Related branches

Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :
tags: added: oem-priority
description: updated
Revision history for this message
Sebastien Bacher (seb128) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in software-properties (Ubuntu):
status: New → Confirmed
Changed in software-properties (Ubuntu):
assignee: nobody → Alberto Milone (albertomilone)
importance: Undecided → High
status: Confirmed → In Progress
Changed in software-properties (Ubuntu):
status: In Progress → Fix Committed
Changed in software-properties (Ubuntu Jammy):
milestone: none → ubuntu-22.04.1
Changed in software-properties (Ubuntu Jammy):
assignee: nobody → Alberto Milone (albertomilone)
importance: Undecided → High
status: New → Fix Committed
description: updated
description: updated
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.99.24

---------------
software-properties (0.99.24) kinetic; urgency=medium

  * softwareproperties/gtk/SoftwarePropertiesGtk.py:
    Don't crash if the driver package does not have a matching modules package
    Fixes LP: #1969460

 -- Alberto Milone <email address hidden> Mon, 30 May 2022 16:50:03 +0200

Changed in software-properties (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Robie Basak (racb) wrote : Please test proposed package

Hello Shih-Yuan, or anyone else affected,

Accepted software-properties into jammy-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.99.22.2 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, what testing has been performed on the package and change the tag from verification-needed-jammy to verification-done-jammy. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-jammy. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance for helping!

N.B. The updated package will be released to -updates after the bug(s) fixed by this package have been verified and the package has been in -proposed for a minimum of 7 days.

description: updated
tags: added: verification-needed verification-needed-jammy
Revision history for this message
Shih-Yuan Lee (fourdollars) wrote :

I checked software-properties/0.99.22.2 in jammy-proposed and it does fix the problem.

Changed in oem-priority:
importance: Undecided → High
assignee: nobody → Shih-Yuan Lee (fourdollars)
status: New → Fix Committed
tags: added: verification-done verification-done-jammy
removed: verification-needed verification-needed-jammy
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.99.22.2

---------------
software-properties (0.99.22.2) jammy; urgency=medium

  * softwareproperties/gtk/SoftwarePropertiesGtk.py:
    Don't crash if the driver package does not have a matching modules package
    Fixes LP: #1969460

 -- Alberto Milone <email address hidden> Tue, 31 May 2022 11:39:13 +0200

Changed in software-properties (Ubuntu Jammy):
status: Fix Committed → Fix Released
Revision history for this message
Brian Murray (brian-murray) wrote : Update Released

The verification of the Stable Release Update for software-properties has completed successfully and the package is now being released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

Changed in oem-priority:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.