test failures on focal due to missing build-depends on gpg and gpg-agent

[Corey Bryant]

======================================================================
ERROR: test_add_ppa_signing_key_multiple_fingerprints (tests.test_lp.AddPPASigningKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1330, in patched
    return func(*args, **keywargs)
  File "/build/software-properties-0.98.6/tests/test_lp.py", line 148, in test_add_ppa_signing_key_multiple_fingerprints
    res = self.t.add_ppa_signing_key("~mvo/ubuntu/ppa")
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 317, in add_ppa_signing_key
    minimal_key = self._minimize_key(armored_key)
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 259, in _minimize_key
    p = self.gpg_cmd("import-minimal,import-export")
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 242, in gpg_cmd
    return subprocess.Popen(cmd.split(), stdin=subprocess.PIPE, stdout=subprocess.PIPE)
  File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gpg'

======================================================================
ERROR: test_add_ppa_signing_key_ok (tests.test_lp.AddPPASigningKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1330, in patched
    return func(*args, **keywargs)
  File "/build/software-properties-0.98.6/tests/test_lp.py", line 158, in test_add_ppa_signing_key_ok
    res = self.t.add_ppa_signing_key("~mvo/ubuntu/ppa")
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 317, in add_ppa_signing_key
    minimal_key = self._minimize_key(armored_key)
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 259, in _minimize_key
    p = self.gpg_cmd("import-minimal,import-export")
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 242, in gpg_cmd
    return subprocess.Popen(cmd.split(), stdin=subprocess.PIPE, stdout=subprocess.PIPE)
  File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gpg'

======================================================================
ERROR: test_add_ppa_signing_key_wrong_fingerprint (tests.test_lp.AddPPASigningKeyTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/mock/mock.py", line 1330, in patched
    return func(*args, **keywargs)
  File "/build/software-properties-0.98.6/tests/test_lp.py", line 140, in test_add_ppa_signing_key_wrong_fingerprint
    res = self.t.add_ppa_signing_key("~mvo/ubuntu/ppa")
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 317, in add_ppa_signing_key
    minimal_key = self._minimize_key(armored_key)
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 259, in _minimize_key
    p = self.gpg_cmd("import-minimal,import-export")
  File "/build/software-properties-0.98.6/softwareproperties/ppa.py", line 242, in gpg_cmd
    return subprocess.Popen(cmd.split(), stdin=subprocess.PIPE, stdout=subprocess.PIPE)
  File "/usr/lib/python3.8/subprocess.py", line 854, in __init__
    self._execute_child(args, executable, preexec_fn, close_fds,
  File "/usr/lib/python3.8/subprocess.py", line 1702, in _execute_child
    raise child_exception_type(errno_num, err_msg, err_filename)
FileNotFoundError: [Errno 2] No such file or directory: 'gpg'

======================================================================
FAIL: test_add_gpg_key (tests.test_dbus.TestDBus)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/software-properties-0.98.6/tests/test_dbus.py", line 372, in test_add_gpg_key
    self.assertTrue(res)
AssertionError: dbus.Boolean(False) is not true

----------------------------------------------------------------------
Ran 30 tests in 1.972s

[Corey Bryant (corey.bryant)]

Adding gpg to build-depends helps but then we get the following due to missing gpg-agent:

======================================================================
FAIL: test_add_gpg_key (tests.test_dbus.TestDBus)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/build/software-properties-0.98.6/tests/test_dbus.py", line 372, in test_add_gpg_key
    self.assertTrue(res)
AssertionError: dbus.Boolean(False) is not true

[Corey Bryant (corey.bryant)]

I should have mentioned that I have a fix for this too just running it by mvo.

[Corey Bryant (corey.bryant)]

Fixed in focal via https://launchpad.net/ubuntu/+source/software-properties/0.98.6

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-properties - 0.98.6

---------------
software-properties (0.98.6) focal; urgency=medium

  * cloudarchive: Enable support for the Ussuri Ubuntu Cloud Archive on
    18.04 (LP: #1852489).
  * softwareproperties/dbus/SoftwarePropertiesDBus.py: In SetUpdateInterval,
    convert days argument from dbus.Int32 to int before passing to
    set_update_interval. This fixes a test failures as apt_pkg.config.set
    didn't understand a dbus.Int32 type (LP: #1852772).
  * debian/control: Add gpg and gpg-agent to Build-Depends to fix failing
    unit tests (LP: #1852773).

 -- Corey Bryant <email address hidden> Wed, 13 Nov 2019 16:00:59 -0500