software-properties-qt should not run as root

Bug #1804887 reported by Carlo Vanini on 2018-11-23
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-properties (Ubuntu)
Undecided
Unassigned

Bug Description

s-p-qt should not be run as root (with sudo or pkexec), instead it should use the DBus backend like s-p-gtk does. This way the UI runs as unprivileged user, and the user is asked for credentials when making changes.

Motivation:
* Running the UI with sudo is bad.
* It doesn't work in Wayland. (https://bugs.kde.org/show_bug.cgi?id=391965)
* The DBus backend already exists and is used by s-p-gtk.

RFC:
The attached patch changes s-p-qt to use the DBus service for the settings in the first tab (enable/disable components, change server).
Any comment on how it works or should work?

Known issues with the patch:
* When a change fails to be applied the UI doesn't notice and is out of sync with system state. That's because the DBus service never returns a value (except for DBus error). Solution is to reload the config after every change attempt.

Carlo Vanini (silhusk) wrote :

The attachment "partial implementation" seems to be a patch. If it isn't, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are a member of the ~ubuntu-reviewers, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issues please contact him.]

tags: added: patch
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers