Hide livepatch widgets in flavors without an online account panel in gnome-control-center

Bug #1770686 reported by Andrea Azzarone on 2018-05-11
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
software-properties (Ubuntu)
Medium
Andrea Azzarone
Bionic
Medium
Unassigned

Bug Description

[Impact]
Some distributions ship software-properties-gtk but not gnome-control-center. Considering that Livepatch strictly depends on the online account panel in gnome-control-center we should not show the option to enable Livepatch if those distributions, otherwise enabling Livepatch will fail and it will seem buggy.

[Test Case]
1. Start xubuntu (Bionic)
2. Open software-properties-gtk
3. Go to "Updates" tab
4. Make sure no Livepatch UI is displayed

[Regression Potential]
Please make sure the Livepatch UI is correctly displayed in vanilla Bionic.

[Original Bug Report]

Unfortunately Livepatch strictly depends on the online account panel in gnome-control-center. We should hide the checkbutton in flavors (e.g. Xubuntu) that do not ship gnome-control-center and/or the online account panel.

Related branches

Andrea Azzarone (azzar1) on 2018-05-11
Changed in software-properties (Ubuntu):
assignee: nobody → Andrea Azzarone (azzar1)
importance: Undecided → Medium
status: New → In Progress
summary: - Hide livepatch widgets if flavors without an online account panel in
+ Hide livepatch widgets in flavors without an online account panel in
gnome-control-center
Changed in software-properties (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.96.24.36

---------------
software-properties (0.96.24.36) cosmic; urgency=medium

  * SoftwarePropertiesGtk.py: Hide livepatch widgets in flavors without
    an online account panel in gnome-control-center (LP: #1770686).

 -- Andrea Azzarone <email address hidden> Wed, 25 Jul 2018 17:42:31 +0200

Changed in software-properties (Ubuntu):
status: Fix Committed → Fix Released
Andrea Azzarone (azzar1) on 2018-07-26
tags: added: rls-bb-incoming
Changed in software-properties (Ubuntu Bionic):
importance: Undecided → Medium
Andrea Azzarone (azzar1) wrote :

Please find attached a debdiff fixing this issue.

description: updated
Sebastien Bacher (seb128) wrote :

Thanks, the debdiff was based on the bionic version and not the current SRU though so something to keep an eye on for next time
I rebased and uploaded

Changed in software-properties (Ubuntu Bionic):
status: New → Fix Committed

Hello Andrea, or anyone else affected,

Accepted software-properties into bionic-proposed. The package will build now and be available at https://launchpad.net/ubuntu/+source/software-properties/0.96.24.32.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation on how to enable and use -proposed.Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested and change the tag from verification-needed-bionic to verification-done-bionic. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed-bionic. In either case, without details of your testing we will not be able to proceed.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed verification-needed-bionic
Andrea Azzarone (azzar1) wrote :

Tested in xubuntu.

tags: added: verification-done verification-done-bionic
removed: verification-needed verification-needed-bionic
Łukasz Zemczak (sil2100) wrote :

Please include a bit more information when performing verification! At least the version number of the package tested and some confirmation that the verification steps have been performed. Thank you!

Andrea Azzarone (azzar1) wrote :

@sill2100 sorry about that. I tested 0.96.24.32.5 both in vanilla bionic and in xubuntu bionic. I performed the following verification steps as per description:

Xubuntu:
"
[Test Case]
1. Start xubuntu (Bionic)
2. Open software-properties-gtk
3. Go to "Updates" tab
4. Make sure no Livepatch UI is displayed
"

Vanilla ubuntu:
Xubuntu:
"
[Test Case]
1. Start ubuntu (Bionic)
2. Open software-properties-gtk
3. Go to "Updates" tab
4. Make sure Livepatch UI is displayed
"

Screenshot attached for xubuntu.

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-properties - 0.96.24.32.5

---------------
software-properties (0.96.24.32.5) bionic; urgency=medium

  * SoftwarePropertiesGtk.py: Hide livepatch widgets in flavors without
    an online account panel in gnome-control-center (LP: #1770686)

 -- Andrea Azzarone <email address hidden> Fri, 17 Aug 2018 09:56:07 +0000

Changed in software-properties (Ubuntu Bionic):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for software-properties has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regressions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers