AttributeError: 'NoneType' object has no attribute '__contains__' when clicking the All Software button

[Gary Lasker]

Software Center 5.2.1, Ubuntu 10.04

SRU TEST CASE:
1. open stock software-center
2. click on the "All Software" button very quickly while the main page is still loading
3. verify that there is a traceback (note that this does not happen always, just most of the time)
4. use the fixed version from -proposed
5. verify that (2) no longer produces the following (or any) traceback

SRU REGRESSION POTENTIAL:
Very low, but a possible regression is that the toolbar buttons may not be enabled when Software Center has fully initialized. Test launching and relaunching Software Center to confirm that the toolbar buttons always become active when the lobby view initialization is complete.

---

When testing the fix for a similar crash in bug 920196, I found that even with that fix I was able to cause a (different) crash by repeatedly clicking the "All Software" button while Software Center is starting up.

The stacktrace is shown below.

Traceback (most recent call last):
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/enquire.py", line 115, in _get_estimate_nr_apps_and_nr_pkgs
    tmp_matches = enquire.get_mset(0, len(self.db), None, xfilter)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/appfilter.py", line 89, in __call__
    if (not pkgname in self.cache and
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/pkginfo_impl/aptcache.py", line 263, in __contains__
    return self._cache.__contains__(k)
AttributeError: 'NoneType' object has no attribute '__contains__'
Traceback (most recent call last):
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/panes/viewswitcher.py", line 149, in config_view
    pane = vm.set_active_view(view_id)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/session/viewmanager.py", line 149, in set_active_view
    view_widget.init_view()
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/panes/availablepane.py", line 168, in init_view
    self.apps_filter)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/views/catview_gtk.py", line 240, in __init__
    self.build(desktopdir)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/views/catview_gtk.py", line 492, in build
    self._build_homepage_view()
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/views/catview_gtk.py", line 267, in _build_homepage_view
    self._append_top_rated()
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/views/catview_gtk.py", line 404, in _append_top_rated
    top_rated_cat = self._update_top_rated_content()
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/ui/gtk3/views/catview_gtk.py", line 391, in _update_top_rated_content
    docs = top_rated_cat.get_documents(self.db)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/categories.py", line 124, in get_documents
    nonblocking_load=False)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/enquire.py", line 317, in set_query
    self._blocking_perform_search()
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/enquire.py", line 212, in _blocking_perform_search
    matches = enquire.get_mset(0, self.limit, None, xfilter)
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/appfilter.py", line 89, in __call__
    if (not pkgname in self.cache and
  File "/home/tremolux/Projects/precise/software-center_fix_crash_lp920196/5.2/softwarecenter/db/pkginfo_impl/aptcache.py", line 263, in __contains__
    return self._cache.__contains__(k)
AttributeError: 'NoneType' object has no attribute '__contains__'

[Steve Langasek (vorlon)]

Hello Gary, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-center - 5.2.2

---------------
software-center (5.2.2) precise-proposed; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/whatsnew-leak-lp985389:
    - search filter fix for the case when the "installed-only"
      filter leaks into subsequent searches (LP: #985389)
  * lp:~mvo/software-center/fix-lp994632:
    - add a dep to ensure we get the correct ubuntu-sso-client-gtk
      (LP: #994632)
  * lp:~mvo/software-center/proper-error-on-unknown-files:
    - show a proper error message when attempting to open unknown
      file types (LP: #944868)
  * lp:~mvo/software-center/lp921799:
    - fix crash when decoding screenshots JSON (LP: #921799)
  * lp:~mvo/software-center/lp959612:
    - fix crash when selecting the Installed view very quickly
      after startup (LP: #959612)

  [ Ken VanDine ]
  * lp:~ken-vandine/software-center/lp_982567:
    - Check if the proxy is enabled, if the proxy host is set but not
      enabled we shouldn't attempt to use the proxy (LP: #982567)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/fix-crash-lp969732:
    - need to explicitly declare the needs-refresh signal in the
      AppTreeStore class to prevent a crash (LP: #969732)
  * lp:~gary-lasker/software-center/fix-crash-lp870822:
    - don't crash if we don't get a pkgversion object back
      (LP: #870822)
  * lp:~gary-lasker/software-center/fix-shutdown-crash-lp996333:
    - never crash when writing out the software center config file on
      shutdown (LP: #996333)
  * lp:~gary-lasker/software-center/fix-makedirs-race-crashes:
    - fix crash on race when creating the cache or config directories
      (LP: #743003, LP: #621182)
  * lp:~gary-lasker/software-center/fix-crash_lp973379:
    - ensure that the cache is ready before using the recommender
      service (LP: #973379 )
  * lp:~gary-lasker/software-center/toolbar-buttons-insensitive-during-startup:
    - set the toolbar buttons insensitive for the duration of time that the
      lobby panels are initializing (LP: #999486, LP: #994341)

  [ Robert Roth ]
  * lp:~evfool/software-center/bug532072:
    - escape markup for support info and license (LP: #993279)
    - ellipsize summary at trailing end (LP: #532072)
  * lp:~evfool/software-center/lp626037:
    - subtle background color tweak for consistency
      between views (LP: #626037)
  * lp:~evfool/software-center/lp835005:
    - no need for the software-properties dialog to be modal
      to software-center (LP: #835005)
  * lp:~evfool/software-center/lp839389:
    - don't display an "icon not found" image in the Unity
      launcher when a report a review window is opened (LP: #839389)
  * lp:~evfool/software-center/867588:
    - capitalize the first letter of the package summary
      (LP: #867588)
  * lp:~evfool/software-center/lp876657:
    - make sure the search field does not disappear when an
      install or remove is in progress (LP: #876657)
  * lp:~evfool/software-center/lp987797:
    - fix alignment in the reviews part of the appdetails (LP: #987797)
  * lp:~evfool/software-center/lp844768:
    - show a indeterminate progress bar when software-center waits for
      another ...

[Steve Langasek (vorlon)]

Hello Gary, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

[Chris Halse Rogers (raof)]

Hello Gary, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available in a few hours. Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users. If this package fixes the bug for you please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case details of your testing will help us make a better decision. Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Gary Lasker (gary-lasker)]

I have verified that software-center version 5.2.3 in precise-proposed fixes this bug per the test case given in the description.

Thanks!

[rkb100100 (rkb100100)]

This update fails to install using Update Manager and Synaptic :
  * lp:~gary-lasker/software-center/toolbar-buttons-insensitive-during-startup:
    - re-enable the fix for LP: #999486, LP: #994341 that was inadvertently
      disabled in the 5.2.2 release

installArchives() failed: (Reading database ...
(Reading database ... 5%%
(Reading database ... 10%%
(Reading database ... 15%%
(Reading database ... 20%%
(Reading database ... 25%%
(Reading database ... 30%%
(Reading database ... 35%%
(Reading database ... 40%%
(Reading database ... 45%%
(Reading database ... 50%%
(Reading database ... 55%%
(Reading database ... 60%%
(Reading database ... 65%%
(Reading database ... 70%%
(Reading database ... 75%%
(Reading database ... 80%%
(Reading database ... 85%%
(Reading database ... 90%%
(Reading database ... 95%%
(Reading database ... 100%%
(Reading database ... 265761 files and directories currently installed.)
Preparing to replace software-center 5.2.1 (using .../software-center_5.2.3_all.deb) ...
Unpacking replacement software-center ...
dpkg: error processing /var/cache/apt/archives/software-center_5.2.3_all.deb (--unpack):
 symbolic link '/usr/share/gnome/help/software-center/gv/software-center.xml' size has changed from 61 to 0
No apport report written because MaxReports is reached already
Processing triggers for man-db ...
Processing triggers for hicolor-icon-theme ...
Processing triggers for bamfdaemon ...
Rebuilding /usr/share/applications/bamf.index...
Processing triggers for desktop-file-utils ...
Processing triggers for gnome-menus ...
Errors were encountered while processing:
 /var/cache/apt/archives/software-center_5.2.3_all.deb
Error in function: