software-center crashed with AttributeError in _on_network_state_change(): 'UIReview' object has no attribute 'complain'

Bug #977179 reported by Michael Terry on 2012-04-09
46
This bug affects 9 people
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Low
Unassigned
Precise
Undecided
Unassigned
Quantal
Low
Unassigned

Bug Description

I woke up from suspend and got this.

Steps to reproduce:

1. Launch Software Center and navigate to an item that you have installed.
2. Scroll to the reviews area and note how each review has an "Inappropriate?" link and a "Did you find this review helpful?" link.
3. Disable networking.
4. After a short time, observe that the two items described in 2) above are hidden.

ProblemType: Crash
DistroRelease: Ubuntu 12.04
Package: software-center 5.1.14.1
ProcVersionSignature: Ubuntu 3.2.0-22.35-generic-pae 3.2.14
Uname: Linux 3.2.0-22-generic-pae i686
ApportVersion: 2.0-0ubuntu4
Architecture: i386
CheckboxSubmission: 9a284f3f6b4f7829abbe27ad9573a709
CheckboxSystem: 3935143777c965daaa64b51f0134f712
Date: Sun Apr 8 23:34:07 2012
EcryptfsInUse: Yes
ExecutablePath: /usr/share/software-center/software-center
InstallationMedia: Ubuntu 11.04 "Natty Narwhal" - Release i386 (20110422)
InterpreterPath: /usr/bin/python2.7
PackageArchitecture: all
ProcCmdline: /usr/bin/python /usr/bin/software-center
PythonArgs: ['/usr/bin/software-center']
SourcePackage: software-center
Title: software-center crashed with AttributeError in _on_network_state_change(): 'UIReview' object has no attribute 'complain'
UpgradeStatus: Upgraded to precise on 2011-11-05 (155 days ago)
UserGroups: adm admin cdrom dialout lpadmin plugdev sambashare vboxusers

Related branches

Michael Terry (mterry) wrote :
visibility: private → public
tags: removed: need-duplicate-check
Michael Vogt (mvo) wrote :

This appears to be happening when there is a review by the user, in this case the code does not create self.complain.
Looking at the code it does not actually make that much sense to hide this link but instead to hide the box itself, I
created a branch for that.

Changed in software-center (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Michael Vogt (mvo) on 2012-04-16
Changed in software-center (Ubuntu):
status: Triaged → In Progress

Hello Michael, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available in a few hours. Please test and give feedback here. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Thank you in advance!

Changed in software-center (Ubuntu Precise):
status: New → Fix Committed
tags: added: verification-needed
Gary Lasker (gary-lasker) wrote :

I verified this fix in software-center version 5.2.1 in precise-proposed per steps to reproduce in the description.

Many thanks!

description: updated
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.2.1

---------------
software-center (5.2.1) precise-proposed; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/lp977179:
    - make the review UI react correctly to conditions of network
      availability (LP: #977179)
  * lp:~mvo/software-center/fix-crash-deb-file-size-calc:
    - fix crash when installing a deb file that is not found in
      the current apt cache
  * lp:~mvo/software-center/lp981992:
    - fix a crash in the new a11y code if there is a row that has
      no data or is not yet preloaded (LP: #981992)
  * lp:~mvo/software-center/fix-gmenu-searcher:
    - fix the menu searcher for non-Unity configurations after
      the app-install-data-ubuntu file layout changed
  * lp:~mvo/software-center/lp808455:
    - trivial fix for crash on downstream distros (LP: #808455)
  * lp:~mvo/software-center/lp927262:
    - fix crash when get_vadjustment() returns None (LP: #927262)
  * lp:~mvo/software-center/utf8-fixes:
    - fix various utf8-related crashes (LP: #943500, LP: #922225,
      LP: #917755)
  * lp:~mvo/software-center/gwibber-utf8-lp985255:
    - fix a utf8 crash in the gwibber integration (LP: #985255)
  * lp:~mvo/software-center/workaround-gtk-regression-lp986186:
    - workaround performance issue with the Gtk.TreeView.set_model()
      call when there is a cell_data_func attached. Not every user is
      affected (settings dependant somehow), but when affected it causes
      a massive performance degration for huge list models like "System"
      (LP: #986186). This branch works around the problem by disconnecting
      the cell_data_func before setting the new model.
  * lp:~mvo/software-center/fix-clear-credentials-race:
    - fix an incorrect use of the sso dbus backend, we now correctly
      wait until it emits a CredentialsCleared signal (LP: #986117)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/add-to-launcher-after-auth-lp972710:
    - fix bug where an application will be added to the Unity launcher
      in the case where the user cancels the installation auth dialog
      (LP: #972710)
  * lp:~gary-lasker/software-center/recommendations-sso-login-lp973612:
    - fix bug where the recommendations opt-in panel is hidden if
      the user declines the SSO dialog after opting in (LP: #973612)
    - fix the user experience if the user has previously opted-in to
      recommendations and their SSO token is found have been removed
      or revoked or otherwise found to be invalid (LP: #967064)
    - improve the responsiveness of the spinner in the recommendations
      flow
 -- Michael Vogt <email address hidden> Thu, 26 Apr 2012 09:47:19 +0200

Changed in software-center (Ubuntu Quantal):
status: In Progress → Fix Released
Changed in software-center (Ubuntu Precise):
status: Fix Committed → Fix Released
Rainer Rohde (rainer-rohde) wrote :

Just crashed on me...

And on me.

Joseph Mills (josephjamesmills) wrote :

And me also

Paul Greindl (paul-greindl) wrote :

For me this happens when I click "Was this helpful: Yes/No" or "Inappropriate?". In both 12.10 and 13.04. Don't know if it's in 12.04 as well...

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers