USC shows reviews for apps it can't find.

Bug #955005 reported by Alan Pope 🍺🐧🐱 πŸ¦„ on 2012-03-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Medium
Michael Vogt

Bug Description

Wanted to install an app from https://apps.ubuntu.com/cat/applications/oneiric/wireframesketcherstudio/ by clicking the "purchase" link.

Software centre can't find the app in my sources (which is fine) and it tells me this, but then shows two reviews. The reviews seem out of place given it can't find the app.

See screenshot.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: software-center 5.1.12
ProcVersionSignature: Ubuntu 3.2.0-18.29-generic 3.2.9
Uname: Linux 3.2.0-18-generic x86_64
ApportVersion: 1.94.1-0ubuntu2
Architecture: amd64
Date: Wed Mar 14 13:02:53 2012
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 12.04 LTS "Precise Pangolin" - Alpha amd64 (20120203)
PackageArchitecture: all
ProcEnviron:
 LANGUAGE=en_GB:en
 TERM=xterm
 PATH=(custom, user)
 LANG=en_GB.UTF-8
 SHELL=/bin/bash
SourcePackage: software-center
UpgradeStatus: No upgrade log present (probably fresh install)

Related branches

Michael Vogt (mvo) on 2012-03-14
Changed in software-center (Ubuntu):
assignee: nobody → software-center-developers (software-center-developers)
Paolo Rotolo (paolorotolo) wrote :

Hi Alan,
please, can you try to delete or rename the /home/.cache/software-center folder?
It worked for me!

Regards,
Paolo

That made no difference here Paolo.

Michael Vogt (mvo) wrote :

The patch below fixes it:

=== modified file 'softwarecenter/ui/gtk3/views/appdetailsview.py'
--- softwarecenter/ui/gtk3/views/appdetailsview.py 2012-02-27 16:05:43 +0000
+++ softwarecenter/ui/gtk3/views/appdetailsview.py 2012-03-14 17:05:02 +0000
@@ -974,7 +974,7 @@
             # update the widget
             self.review_stats_widget.set_avg_rating(stats.ratings_average)
             self.review_stats_widget.set_nr_reviews(stats.ratings_total)
- self.review_stats_widget.show()
+ #self.review_stats_widget.show()
         else:
             self.review_stats_widget.hide()

@@ -1377,6 +1377,7 @@
         if pkg_error:
             self.addon_view.hide()
             self.reviews.hide()
+ self.review_stats_widget.hide()
             self.screenshot.hide()
             #~ self.info_header.hide()
             self.info_vb.hide()
@@ -1385,6 +1386,7 @@
         else:
             self.addon_view.show()
             self.reviews.show()
+ self.review_stats_widget.show()
             self.screenshot.show()
             #~ self.info_header.show()
             self.info_vb.show()

but needs a proper regression test before it can go in :)

Changed in software-center (Ubuntu):
status: New → In Progress
importance: Undecided → Medium
Changed in software-center (Ubuntu):
assignee: software-center-developers (software-center-developers) → Michael Vogt (mvo)
Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :
Download full text (4.6 KiB)

This bug was fixed in the package software-center - 5.1.13

---------------
software-center (5.1.13) precise; urgency=low

  [ Anthony Lenton ]
  * lp:~elachuni/software-center/pep8-test-part5,
    lp:~elachuni/software-center/pep8-test-part6,
    lp:~elachuni/software-center/pep8-test-part7,
    lp:~elachuni/software-center/pep8-test-part8,
    lp:~elachuni/software-center/pep8-test-part9,
    lp:~elachuni/software-center/pep8-test-part10,
    lp:~elachuni/software-center/pep8-test-part11,
    lp:~elachuni/software-center/pep8-test-part12,
    lp:~elachuni/software-center/pep8-test-part13,
    lp:~elachuni/software-center/pep8-test-part14,
    lp:~elachuni/software-center/pep8-test-part15,
    lp:~elachuni/software-center/pep8-test-part16,
    lp:~elachuni/software-center/pep8-test-part17,
    lp:~elachuni/software-center/pep8-test-part18,
    lp:~elachuni/software-center/pep8-test-part19,
    lp:~elachuni/software-center/pep8-test-part20,
    lp:~elachuni/software-center/pep8-test-part21,
    lp:~elachuni/software-center/pep8-test-part22:
    - many, many, many pep8 fixes
  * lp:~elachuni/software-center/unify-ussoc-envvar:
    - fix USSOC_SERVICE_URL env variable

  [ Gabor Kelemen ]
  * lp:~kelemeng/software-center/bug953812: (LP: #953812)
    - Translate review sorting criteria
    - Fix the Recommendation spinner text translations

  [ Michael Vogt ]
  * lp:~mvo/software-center/small-sso-fixes:
    - fix the clear_credentials() call if a token is no
      longer valid
  * lp:~mvo/software-center/lp955005:
    - don't display ratings for the case where an app
      cannot be found (LP: #955005)
  * lp:~mvo/software-center/opengl-driver-blacklist:
    - add support for video driver blacklisting
  * lp:~mvo/software-center/lp856559:
    - fix case where the search term is not always
      cleared in the search entry (LP: #856559)
  * lp:~mvo/software-center/misc-fixes:
    - when a package can not be authenticated, do not fail
      (hard) but instead offer to "repair" the situation using
      a "reload" and try the install again (LP: #876278)
    - do not crash in if os.makedirs has a race condition
      (LP: #956680)
    - fix the proxy handling with 12.04 as the "enabled" property
      is deprecated now. it will also not mess with the proxy
      environment on non-gnome systems (LP: #742564)
  * lp:~mvo/software-center/lp780812:
    - ensure that the distroseries is updated in the sources
      deb line when updating a purchased item (LP: #780812)
  * lp:~mvo/software-center/recommendations-opt-out:
    - fix double-results when opting-in and back out of of
      the recommendations service repeatedly
  * lp:~mvo/software-center/tos-dialog:
    - display a terms-of-service dialog before the first purchase
  * lp:~mvo/software-center/lp957599:
    - add a new unit test test_spawn_helper.py
  * lp:~mvo/software-center/track-db-open:
    - improve db logging

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/fix-lp955048:
    - String fix for the "Recommended For You" panel. LP: #955048
  * lp:~gary-lasker/software-center/fix-lp856559:
    - Clears the search entry field before doing a reinstall
      previous purchases (LP: #85655...

Read more...

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers