Icon coordinates are not correct for Unity launcher integration dbus call from the list view
Bug #947624 reported by
Gary Lasker
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
software-center (Ubuntu) |
Fix Released
|
High
|
Gary Lasker |
Bug Description
Software Center version 5.1.11, The Precise Pangolin
The icon coordinate values that are used for implementing the cool animation effect for the Unity launcher integration are not correct when an application installation is initiated in Software Center's list view. For this case, the coordinates being reported are 0,0 for icon_x and icon_y.
Note that the correct coordinates *are* sent for the case where an installation is initiated in the details view. We simply need to send the correct values for both cases.
Related branches
lp:~gary-lasker/software-center/list-view-icon-coordinates-lp947624
- Michael Vogt: Approve
-
Diff: 255 lines (+116/-17)5 files modifiedsoftwarecenter/ui/gtk3/panes/availablepane.py (+3/-1)
softwarecenter/ui/gtk3/views/appview.py (+37/-1)
softwarecenter/ui/gtk3/widgets/apptreeview.py (+8/-0)
softwarecenter/ui/gtk3/widgets/cellrenderers.py (+10/-5)
test/gtk3/test_unity_launcher_integration.py (+58/-10)
Changed in software-center (Ubuntu): | |
status: | New → Triaged |
importance: | Undecided → High |
assignee: | nobody → Gary Lasker (gary-lasker) |
description: | updated |
Changed in software-center (Ubuntu): | |
status: | Triaged → In Progress |
Changed in software-center (Ubuntu): | |
status: | In Progress → Fix Committed |
To post a comment you must log in.
This bug was fixed in the package software-center - 5.1.12
---------------
software-center (5.1.12) precise; urgency=low
[ Michael Vogt ] CENTER_ NET_CONNECTED environment value to from_list( ) helper to build (somewhat) modifying review
* lp:~mvo/software-center/webcam-string-fix:
- small fix to support the debtagshw updated tags for hardware::camera
(split into webcam,digicam now)
* lp:~mvo/software-center/trivial-nm-state-override:
- support the SOFTWARE_
force the connected state as a stopgap workaround for bug 911706
* lp:~mvo/software-center/lp941361:
- adds a general make_string_
i18n friendly human readable strings easily (LP: #941361)
* lp:~mvo/software-center/expunge-cache:
- merge os.nice() addition
* lp:~mvo/software-center/lp789596:
- better (less scary) string for updates from third-party
venders (LP: #789596)
* lp:~mvo/software-center/fix-refresh-of-whats-new:
- fix missing refresh of the what's new content on a database
reopen so that new content from the agent appears as soon
as it finishes the update
* lp:~mvo/software-center/review-fixes:
- ensure ui is correctly updated after submitting/
* lp:~mvo/software-center/simulate-slow-network:
- add a small helper to simulate a slow network connection to
see if we have hidden latencies in the UI when the network
is (really) slow
* lp:~mvo/software-center/top-rated-refresh:
- ensure that the top-rated apps are refreshed when we have new data
* lp:~mvo/software-center/apptreeview-tweaks:
- fix 'load_range" errors when navigating the installed view
(LP: #913675), and do some nice needed refactoring/cleanup
[ Anthony Lenton ]
* lp:~elachuni/software-center/dont-store:
- consolidate Ubunty SSO logins to use "Ubuntu Software Center", fixes
inconsistent UI and storing of two keys in they keyring, as well as
being prompted to log in twice the first time that you review an app
* lp:~elachuni/software-center/pep8-test,
lp:~elachuni/software-center/pep8-test-part2,
lp:~elachuni/software-center/pep8-test-part3,
lp:~elachuni/software-center/pep8-test-part4:
- add a unit test to check code statically for pep8 compliance and update
more and more of the code to meet it
[ Gary Lasker ]
* lp:~gary-lasker/software-center/fix-crash-lp944875:
- Fix an intermittent crash that can happen if the installed view pane
has not been built yet when a call to show the spinner is made as a
result of a refresh (LP: #944875)
* lp:~gary-lasker/software-center/list-view-icon-coordinates-lp947624:
- This branch adds support for providing the correct icon size and
on-screen coordinates values in the Unity launcher integration dbus
call when an installation is initiated via the list view
(LP: #947624)
* lp:~gary-lasker/software-center/enable-published-date-unit-test:
- unit test change only, enable the published-date unit test that was
disabled pending deployment of support on the staging server
[ Natalia Bidart ]
* lp:~nataliabidart/software-center/one-auth:
- use consistently the same app name for eve...