"Login was cancelled" after cancelling sign-in for review

[Matthew Paul Thomas]

software-center trunk r2338, Ubuntu 11.10 beta 1

0. Switch to a guest session.
1. Go to the software item screen for something you have installed.
2. Choose "Write your own review".
3. In the Ubuntu SSO dialog, choose "Cancel".

What happens:
2. A review dialog opens, with SSO dialog on top.
3. The review dialog remains open, with centered text "Login was cancelled".

What should happen:
2. The review dialog should not have opened in the first place. <https://wiki.ubuntu.com/SoftwareCenter/RatingsAndReviews#reviews-reviewing>: "Once you are signed in, a dialog should appear for submitting the review."

[Matthew Paul Thomas (mpt)]

From bug 697504, I realize that if we wait to check that you're signed in before opening the dialog, that might be a delay of several seconds between the time you click the link and the time the dialog opens.

One solution would be to show a spinner in the software item screen itself while we're waiting for sign-in, like we do for helpfulness. That would solve the responsiveness problem, but would still risk that you might be trying to navigate elsewhere by the time the dialog opens.

Another solution would be to open the dialog immediately, but close it again automatically if sign-in is cancelled.

[Matthew McGowan (mmcg069)]

Hi Matthew, can you re-test? For me clicking cancel just closes the submit_review window.

[Matthew Paul Thomas (mpt)]

Yes, Matthew, it's still happening in 4.1.23.6.