Wrong icon for search in Software Center

Bug #835529 reported by Jochem on 2011-08-27
18
This bug affects 2 people
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Low
Unassigned

Bug Description

See the screenshot. The icon in the search bar of the new Software Center is not the default icon used in all the other GNOME applications.

Also, in the Software Center the icon in the bar is on the left. In all the other applications it is on the right.

Found in version 4.1.20

Matthew Paul Thomas (mpt) wrote :

As shown in this screenshot, the search icon USC uses is different from the one Nautilus uses, but it's the same as the one Firefox uses.

I don't understand what's going on here. Maybe Firefox and USC are using a non-symbolic icon, while Nautilus is using a symbolic variant? I think a search icon inside a text field should always be a symbolic one.

As for why it's on the left, the Clear button is on the right. In Firefox and Nautilus, the search icon is something you click to perform the search. In USC, we use a live search instead, so putting it on the right would be misleading.

Changed in software-center (Ubuntu):
status: New → Confirmed
importance: Undecided → Low
assignee: nobody → Paul Sladen (sladen)
Paul Sladen (sladen) wrote :

nb. to Self blue icon (Firefox, USC):

  /usr/share/icons/gnome/22x22/actions/edit-find.png

Symbolic flat icon (Nautilus screenshot + Toolbars):

  /usr/share/icons/gnome/scalable/actions/edit-find-symbolic.svg

Matthew Paul Thomas (mpt) wrote :

So, the USC search widget just needs to use edit-find-symbolic rather than edit-find. Thanks Paul.

Changed in software-center (Ubuntu):
assignee: Paul Sladen (sladen) → nobody
status: Confirmed → Triaged
tags: added: bitesize
Paul Sladen (sladen) wrote :

mpt: to pre-empt your next question, the clear icon used in the Shotwell search field is:

  /usr/share/icons/gnome/scalable/actions/edit-clear-symbolic.svg

Paul Sladen (sladen) wrote :

nb. to self; the QML version's search box is hard-coded:

  softwarecenter/ui/gtk3/widgets/qml/SearchBox.qml:
    FocusScope::searchbox:
      source: "file:///usr/share/icons/Humanity/actions/16/edit-find.svg"
      source: "file:///usr/share/icons/Humanity/actions/16/edit-clear.svg"

Gtk3 search box uses Gtk+ STOCK_* enums:

  softwarecenter/ui/gtk3/widgets/searchentry.py:
    Gtk.Entry::SearchEntry::__init__():
      self.set_icon_from_stock(Gtk.EntryIconPosition.PRIMARY, Gtk.STOCK_FIND)
    Gtk.Entry::SearchEntry::_check_style():
      self.set_icon_from_stock(Gtk.EntryIconPosition.SECONDARY, Gtk.STOCK_CLEAR)

Kiwinote (kiwinote) wrote :

I've updated s-c to use the 'edit-find-symbolic' icon in the search box. As for the clear icon I've left that as non-symbolic in the mean time as the symbolic variant looks fairly dark and bulky - but that's just one opinion, so if you want the clear icon to use the symbolic variant too just give a shout and I'll change that too.

Changed in software-center (Ubuntu):
status: Triaged → Fix Committed
Gary Lasker (gary-lasker) wrote :

Looks very nice indeed. Thank you Kiwinote! Now merged to trunk.

Launchpad Janitor (janitor) wrote :
Download full text (5.6 KiB)

This bug was fixed in the package software-center - 4.1.22

---------------
software-center (4.1.22) oneiric; urgency=low

  [ Gary Lasker ]
  * data/ubuntu-software-center.desktop.in,
    debian/rules,
    setup.py,
    software-center,
    software-center-gtk2,
    softwarecenter/toolkit.py:
    - launch the new UI using 'software-center', add script
      to launch the old version if feeling nostalgic (LP: #839257)
  * softwarecenter/ui/gtk3/views/appdetailsview_gtk.py:
    - fix incorrect ellipsize for title and summary in the
      details view (LP: #842271)
  * softwarecenter/ui/gtk3/panes/availablepane.py,
    softwarecenter/ui/gtk3/session/viewmanager.py:
    - hide the search field when in the purchase
      view (LP: #844883)
  * softwarecenter/ui/gtk3/views/catview_gtk.py:
    - don't create the what's new panel if we don't have the
      corresponding category (LP: #835129)
  * softwarecenter/ui/gtk3/panes/installedpane.py:
    - fix crash in rebuild_categorised_view while viewing
      installed items (LP: #834260)
  * test/gtk3/test_catview.py,
    test/gtk3/test_panes.py,
    test/test_addons.py,
    test/test_package_info.py:
    - fix unit tests
  * setup.py:
    - fix build error when merging authors list
  * merged lp:~gary-lasker/software-center/pyflakes-fixes, no
    user visible changes, only code cleanup
  * po/software-center.pot:
    - refresh .pot file

  [ Matthew McGowan ]
  * data/ui/gtk3/css/softwarecenter.css,
    softwarecenter/ui/gtk3/views/appdetailsview_gtk.py:
    - fix grey addon label, only pkgname should be grey
      (LP: #838607)
  * softwarecenter/ui/gtk3/widgets/description.py,
    softwarecenter/utils.py,
    test/test_description_norm.py:
    - description formatting improvements, update unit test
  * data/ui/gtk3/css/softwarecenter.css,
    softwarecenter/ui/gtk3/widgets/cellrenderers.py:
    - use css to set border-radius of cellrenderer button
  * softwarecenter/ui/gtk3/views/appview.py:
    - disable appcount display at the bottom of list views
      for now to allow keyboard scrolling to work (LP: #830258)
  * lp:~mmcg069/software-center/lobby-tweaks:
    - restore tile borders but disable the checkerboard
      rendering, color tweaks and other improvements to the
      title area visuals
  * merge lp:~mmcg069/software-center/image-data-cleanup:
    - cleanup unused image files (LP: #839736)
  * softwarecenter/ui/gtk3/panes/softwarepane.py:
    - fix doubled search results (LP: #840235)
  * softwarecenter/ui/gtk3/app.py:
    - fix "Copy Web Link" feature (LP: #830291)

  [ Andrea Cimitan ]
  * softwarecenter/ui/gtk3/widgets/symbolic_icons.py:
    - Fix blurriness of toolbar icons, reduce shadow alpha level

  [ Gabor Kelemen ]
  * po/POTFILES.in:
    - additional i18n fixes (LP: #836346)

  [ Kiwinote ]
  * remove the old webkit ui
  * remove the need for dummy-screenshot-ubuntu.png (LP: #837223)
  * data/ui/gtk3/SoftwareCenter.ui,
    softwarecenter/ui/gtk3/app.py:
    - make all the accelerators work again (LP: #640426, LP: #660050,
      LP: #828233, LP: #830238, LP: #834988, LP: #843682)
      also fixes (LP: #823094, LP: #837062)
  * softwarecenter/db/appfilter.py,
    softwarecenter/ui/...

Read more...

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers