AvailableApps API should not serve icon_data inline

[Michael Nelson]

The initial implementation of the software center agent required a single 64x64 icon to be base64 encoded into the available_apps api request for each application.

We were very aware this would not scale and would need to change, but from memory the changes required in the client were not possible at the time (?).

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Anthony Lenton (elachuni)]

software-center-agent should now be able to disable the icon_data in our available-apps-for-purchase api, as USC is checking the icon_url field and fetching icons from there.

I think the best approach is to add a feature flag to disable icon_data in both the 1.0 and 2.0 api, and the apps view. This way we can reenable it quickly if anything goes wrong.

[Michael Nelson (michael.nelson)]

@elachuni: Won't the maverick/natty versions of USC still be expecting the icon_data (at least from the 1.0 api?) or has the change been SRU'd?

[Michael Nelson (michael.nelson)]

11:38 < noodles> mvo: Hi! Just wanting to confirm - is it the case that USC only switched to the 2.0 api for the available apps with oneiric? (This is for https://bugs.launchpad.net/software-center-agent/+bug/830825 )
11:46 < mvo> noodles: yes, currently thats the case, we need to SRU this
11:47 < mvo> noodles: I should be able to attack this today, not sure yet how much work it is though
11:47 < noodles> mvo: Sure - the SRU can come later, I just want to be sure that I can safely remove the icon_data from the 2.0 api (I'll leave it in the 1.0/view so it won't affect older versions)
11:49 < mvo> noodles: yeah, in oneiric our default service root is api/2.0
11:49 < noodles> Great, thanks.