[GTK3] Almost all text in the software item screen is the wrong color

Bug #830738 reported by Matthew Paul Thomas on 2011-08-21
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Medium
Matthew McGowan

Bug Description

software-center-gtk3 trunk r2155, Ubuntu Ocelot

In the software item screen, all text that should be black is grey, and almost all text that should be grey is either black or red.

In particular:
* The title, description, add-on names, review titles, and review text are grey when they should be black.
* The add-on package names, metadata labels, reviewer names, and "This review was written for a different version" are black when they should be grey.
* The "Yes", "No", and "Inappropriate" links are red when they should be grey.
* The metadata values and "found this review helpful" text are the right color.

Changed in software-center (Ubuntu):
importance: Undecided → Medium
Changed in software-center (Ubuntu):
assignee: nobody → Matthew McGowan (mmcg069)
Matthew Paul Thomas (mpt) wrote :

In lp:~mmcg069/software-center/Bug830738 r2135:
* the reviewer name and version disclaimer are fixed
* the helpfulness links and Details section aren't fixed yet
* all the text that should be black is #4c4c4c grey.

Changed in software-center (Ubuntu):
status: New → In Progress
Matthew McGowan (mmcg069) wrote :

hi mpt, where do we stand atm, re latest trunk

Cheers

Matthew Paul Thomas (mpt) wrote :

Nearly there. :-) In r2217, the only thing that's still the wrong color is the "Developer Web Site" link, which should be grey rather than red.

sweet will make the change in the next day or so...

On Sat, Aug 27, 2011 at 4:41 AM, Matthew Paul Thomas <email address hidden>wrote:

> Nearly there. :-) In r2217, the only thing that's still the wrong color
> is the "Developer Web Site" link, which should be grey rather than red.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/830738
>
> Title:
> [GTK3] Almost all text in the software item screen is the wrong color
>
> To manage notifications about this bug go to:
>
> https://bugs.launchpad.net/ubuntu/+source/software-center/+bug/830738/+subscriptions
>

--
From the mind of me!

Matthew McGowan (mmcg069) wrote :

Hi mpt,

in the globalpane-themeability branch i have changed things such that the 'sublte-label' color can be controlled by setting the value of the following lines in the softwarecenter/data/ui/gtk3/css/softwarecenter.css file:

#subtle-label {
    -GtkWidget-link-color: shade (@super-light-aubergine, 0.4);
    -GtkWidget-visited-link-color: shade (@super-light-aubergine, 0.5);
    color: shade (@super-light-aubergine, 0.6);
}

This should affect any label with .set_name("subtle-label") in the python code, and in the case of this bug it _should_ cover all applicable labels....

Play around with the css colors and push a branch with the changes or alternatively let me know your fav colors and i can make the changes on your behalf.

Cheers
Matt

Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 4.1.21

---------------
software-center (4.1.21) oneiric; urgency=low

  [ Kiwinote ]
  * AUTHORS:
    - add credits for the new icon (LP: #834882)
  * a stash of unicode fixes to make s-c-gtk3 usable around the world
    (LP: #831865, LP: #834409, LP: #834312)
  * softwarecenter/db/update.py:
    - fix reinstall previous purchases (LP: #834984)
  * softwarecenter/ui/gtk3/panes/availablepane.py:
    - set title for 'previous purchases' list view (LP: #833960)
  * softwarecenter/ui/gtk3/panes/softwarepane.py:
    - fix None.copy() such that switching panes works again (LP: #834196)
  * softwarecenter/ui/gtk3/widgets/buttons.py:
    - escape application name in tiles (LP: #835876)

  [ Jacob Johan Edwards ]
  * softwarecenter/ui/gtk3/panes/softwarepane.py:
    - fix the spinner display when loading slow views (LP: #830682)

  [ Gabor Kelemen ]
  * po/POTFILES.in,
    po/POTFILES.skip:
    - update per latest configuration, add new gtk3 files

  [ Matthew McGowan ]
  * softwarecenter/ui/gtk3/widgets/buttons.py :
    - resize fix for Top Rated and What's New tiles (LP: #833697)
  * softwarecenter/ui/gtk3/views/catview_gtk.py,
    softwarecenter/ui/gtk3/widgets/containers.py:
    - disable the rendering of the checkboard pattern in the
      grid views (at request of mpt)
   * lp:~mmcg069/software-center/description-tweaks:
     - fix badly rendered package descriptions, other tweaks
       (LP: #833954)
   * lp:~mmcg069/software-center/globalpane-themeability:
     - various theming fixes (LP: #828092, LP: #830681,
       LP: #830738 and LP: #838382)

  [ Gary Lasker ]
  * software-center,
    software-center-gtk3,
    softwarecenter/db/update.py:
    - enable CJK support in Xapian (LP: #745243)
  * po/software-center.pot:
    - refresh .pot file
  * softwarecenter/ui/gtk/widgets/thumbnail.py:
    - fix missing icon in theme to let non-gtk3 version
      launch again, also fixes all gtk unit tests
  * test/test_database.py:
    - update unit test

  [ Didier Roche ]
  * softwarecenter/ui/gtk3/panes/installedpane.py,
    softwarecenter/ui/gtk3/views/appview.py,
    softwarecenter/ui/gtk3/widgets/menubutton.py,
    softwarecenter/ui/gtk3/widgets/oneconfviews.py,
    softwarecenter/db/appfilter.py,
    softwarecenter/ui/gtk3/app.py,
    data/ui/gtk3/SoftwareCenter.ui:
    - brings back OneConf to software center gtk3 with a fresh new design
      (LP: #838623)
  * debian/control:
    - depends on latest oneconf
 -- Gary Lasker <email address hidden> Thu, 01 Sep 2011 11:55:14 -0400

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers