On the review screen, the application name is not localized

Bug #782146 reported by Gabor Kelemen on 2011-05-13
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu Translations
software-center (Ubuntu)

Bug Description

Binary package hint: software-center

When writing an application review, the window does not use the translated application name from app-install-data.

Gabor Kelemen (kelemeng) wrote :
Gabor Kelemen (kelemeng) wrote :

This fixes it, but I think for the long term, we might want to insert this name via a variable, and not hardwiring in the middle of the file.

Changed in ubuntu-translations:
status: New → Triaged
importance: Undecided → Low
tags: added: patch
Changed in software-center (Ubuntu):
status: New → Triaged
importance: Undecided → Low
Michael Vogt (mvo) wrote :

Gabor, you rock, thank you very much!

Gabor Kelemen (kelemeng) wrote :

mvo: there is a small problem with this approach: altough it works for app-install-data-ubuntu, if we want to translate things from other domains, like, say, app-install-data-partner, then it is a not-generic-enough solution.

I asked dpm about why is that not translatable, and he said he doesn't know about any particular reason, but will ask on the partners mailing list if they have any objections. I didn't heard back from him since, but I guess I'll file a bug about that too. In which case, this fix won't be good enough.

So, could you make it a little less hackish? Even if only for the P-release?

Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center - 5.0

software-center (5.0) oneiric; urgency=low

  [ Gary Lasker ]
  * softwarecenter/ui/gtk3/views/appdetailsview.py,
    - restore the ability to edit or delete your own
      review (LP: #861999)
  * softwarecenter/db/application.py:
    - fix TypeError in __init__ (LP: #825729)
  * softwarecenter/ui/gtk3/views/appdetailsview_gtk.py:
    - fix crash in _get_app_icon_xy_position_on_screen (LP: #843565)
  * softwarecenter/ui/gtk3/panes/softwarepane.py:
    - fix UnicodeDecodeError in on_add_to_launcher (LP: #835337)

  [ Michael Vogt ]
  * add support for license keys in $HOME
  * set correct version number
  * utils/submit_review_gtk3.py:
    - translate app name in review title, thanks to Gabor Kelemen
      (LP: #782146)
  * softwarecenter/backend/reviews.py:
    - leave the review sorting to the server now that the rnr-server
      is deployed that sorts properly by wilson_score
  * fix None vs "" crashes
  * fix another dbus exception when a tid vanishes (LP: #848676), thanks
    to Marc Deslauriers

  [ Kiwinote ]
  * softwarecenter/distro/Ubuntu.py:
    - display canonical support text again (LP: #862388)
      (no new strings - there was just some 'if False, display the text' code)

  [ Matthew McGowan ]
  * data/ui/gtk3/dialogs.ui:
    - fix incorrect sizing of dialogs (LP: #825959, LP: #844014)
  * display 'where is it' command line helper for installed apps with
    no desktop_files even when unity is running.'
  * set a minimum size for the CategoryTile so all english category
    names fit to two lines (Computer Science and Robotics took 3 lines
    to display).
  * softwarecenter/ui/gtk3/views/appdetailsview_gtk.py:
    - cleanup dead code
 -- Michael Vogt <email address hidden> Thu, 29 Sep 2011 20:45:22 +0200

Changed in software-center (Ubuntu):
status: Triaged → Fix Released
Gabor Kelemen (kelemeng) on 2011-11-20
Changed in ubuntu-translations:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers