"Review infringment" message not clear

Bug #750421 reported by Simos Xenitellis  on 2011-04-04
This bug affects 1 person
Affects Status Importance Assigned to Milestone
software-center (Ubuntu)
Gary Lasker

Bug Description

Binary package hint: software-center

There is a discussion that the Ubuntu-Translators list,
regarding the message "Review Infringement" (utils/submit_review.py:1002).

These messages are not clear for the translators, and probably neither for English-speaking users.
The patch makes the messages more verbose.

tags: added: patch

Simons: I suggest you create a branch, apply your patch and request the branch for inclusion. Maybe this would speed things up a bit :)

Devs: it would be best if this is applied earlier so that translator teams get time to translate it before launch.

Changed in software-center (Ubuntu):
status: New → Confirmed
Matthew Paul Thomas (mpt) wrote :

As far as Gary Lasker and I can tell, the "Review Infringment" string is dead code: it is not mentioned in the design specification, and it is not actually used in the interface. That is just as well, because "Infringment" is a misspelling of "Infringement"! So it is a bug that the string exists in the code to confuse translators (sorry!), but not as important as it would be if the string was visible.

As for the patch, that is unrelated to this bug report, because it doesn't change actually the "Review Infringment" string. And I think the patch would not be an improvement anyway, because it makes strings longer and more redundant without really making them any more understandable.

The intro label is "Why is this review inappropriate?" So it's obvious that the context is a review, without repeating the word "Review" at the start of each option. What might be useful, instead, would be to add a translator note before each of these strings, explaining that it is one of the options following that question.

Changed in software-center (Ubuntu):
importance: Undecided → Low
status: Confirmed → Triaged
Changed in software-center (Ubuntu):
assignee: nobody → Gary Lasker (gary-lasker)
status: Triaged → In Progress
Gary Lasker (gary-lasker) wrote :

The attached branch removes the never-shown "Review Infringment" string for translation, along with a second string that is also never actually displayed ("Reported by" ). I also added a comment to the translator before each of the four combobox entries as shown:

 #. TRANSLATORS: The following is one entry in a combobox that is
#. located directly beneath a label asking 'Why is this review inappropriate?'.
#. This text refers to a possible reason for why the corresponding
#. review is being flagged as inappropriate.
#: ../utils/submit_review.py:997
msgid "Contains inaccuracies"
msgstr ""

Hopefully, this does this trick! Simon, Lucian, please let us know if this indeed takes care of the problem and we will work to get this fix merged and released as quickly as we can so we don't impact your team further with this. And thanks very much!

Gary Lasker (gary-lasker) wrote :

P.S. My apologies Simos for misspelling your name in my previous comment!

Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package software-center -

software-center ( natty; urgency=low

  [ Michael Vogt ]
  * softwarecenter/db/update.py:
    - do not crash if /var/lib/apt-xapian-index/cataloged_times.p can
      not be read (LP: #636049)
  * merged lp:~mvo/software-center/get-reviews-subprocess (LP: #743020):
    - don't use multiprocessing anymore, instead glib.spawn_async()
      a helper app, this finally fixes the crashes with accessibility
      turned on (LP: #743020)
    - update rnrclient_pristine.py to the latest upstream version
      that supports origin and distroseries as arguments
    - add support for getting all the origins of the DB, this is
      needed for the new rnrclient_pristine.py functionatlity
    - ship get_reviews_helper.py, get_review_stats_helper.py for
      the glib.spawn_async() change
    - this also makes the reviews fully work in the guest session again

  [ Gary Lasker ]
  * softwarecenter/db/reviews.py:
    - update review loader to check for JoinableQueue rather than
      Queue so that we re-enable the ReviewLoaderThreadedRNRClient
      (LP: #754639)
  * utils/submit_review.py:
    - remove two strings marked for translation that are never
      actually shown in the ui, also add translators note for
      combobox entries (LP: #750421)
  * refresh .pot file

  [ Aaron Peachey ]
  * softwarecenter/view/widgets/reviews.py:
    - advise user that app needs to be installed in order to review,
      even if reviews exist (LP: #754879)
 -- Michael Vogt <email address hidden> Mon, 11 Apr 2011 23:02:12 +0200

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers