"Cancel" on payment screen exits with bad message

Bug #641321 reported by Matthew Paul Thomas on 2010-09-17
24
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Payment service
High
Ricardo Kirkner
software-center (Ubuntu)
High
Gary Lasker

Bug Description

Binary package hint: software-center

Ubuntu Software Center 2.1.21, Ubuntu Maverick

1. Select an item for purchase and choose "Buy".
2. Sign in.
3. In the "Purchase of software" screen, choose "Cancel".

What happens: The screen goes blank except for the utterly wrong text "Payment initiated".
What should happen: The payment window closes, returning you to where you were before you chose "Buy".

This may share a callback with bug 637231.

Changed in software-center (Ubuntu):
importance: Undecided → High
Ara Pulido (ara) on 2010-09-27
Changed in software-center (Ubuntu):
status: New → Confirmed
Changed in canonical-payment-service:
milestone: none → 1.0.0
assignee: nobody → Ricardo Kirkner (ricardokirkner)
importance: Undecided → High
status: New → Confirmed
Changed in canonical-payment-service:
status: Confirmed → In Progress
Changed in canonical-payment-service:
status: In Progress → Fix Committed
Dave Morley (davmor2) wrote :

Needs testing in an end to end on SCA.

Dave Morley (davmor2) wrote :

This exits with an ugly warning message but at least exits now.

Dave Morley (davmor2) wrote :

This exits with an ugly warning message but at least exits now.

Matthew Paul Thomas (mpt) wrote :

Ok, so now we need to suppress the error alert in USC if the status is "CANCELLED".

summary: - "Cancel" on payment screen abandons you on wrong "Payment initiated"
- screen
+ "Cancel" on payment screen exits with bad message
Dave Morley (davmor2) wrote :

Still has the ugly error message

Changed in canonical-payment-service:
status: Fix Committed → Fix Released
Dave Morley (davmor2) on 2010-10-07
Changed in canonical-payment-service:
status: Fix Released → Fix Committed
Dave Morley (davmor2) wrote :

This still has an ugly message but exits correctly.

Changed in canonical-payment-service:
status: Fix Committed → Fix Released
Olivier Tilloy (osomon) wrote :

I believe this was fixed in S-C in revision 1374 (in release 3.1.8).

Changed in software-center (Ubuntu):
status: Confirmed → Fix Committed
Changed in software-center (Ubuntu):
status: Fix Committed → Confirmed
status: Confirmed → Triaged
assignee: nobody → Gary Lasker (gary-lasker)
Gary Lasker (gary-lasker) wrote :

Attached branch fixes the issue in mpt's comment #4 on the client side:

"Ok, so now we need to suppress the error alert in USC if the status is 'CANCELLED'."

The software-center-agent side of this fix is committed but has not yet been deployed (see bug 696861).

Changed in software-center (Ubuntu):
status: Triaged → In Progress
Changed in software-center (Ubuntu):
status: In Progress → Fix Committed
Launchpad Janitor (janitor) wrote :
Download full text (3.7 KiB)

This bug was fixed in the package software-center - 3.1.25

---------------
software-center (3.1.25) natty; urgency=low

  [ Kiwinote ]
  * data/ui/SoftwareCenter.ui:
    - mark the back/forward actions as translatable (LP: #742129)
  * softwarecenter/db/database.py,
    softwarecenter/models/appstore.py,
    softwarecenter/view/availablepane.py,
    others:
    - make custom lists work (LP: #712903)
  * softwarecenter/app.py,
    softwarecenter/distro/Ubuntu.py,
    softwarecenter/view/widgets/pathbar_gtk_atk.py:
    - when the supported filter is set to supported_only, navigate up if:
      - we are in a details view of an app which is not supported (LP: #480827)
      - we are in a list view which becomes empty
  * softwarecenter/app.py,
    softwarecenter/view/catview_gtk.py:
    - correctly count the nr of apps displayed in the recommended category and
      update it when needed (LP: #735634)
    - only display subcategories if they are non-empty (LP: #419270)
  * softwarecenter/backend/weblive.py:
    - don't crash if we try to delete a non-existent file (LP: #743511)
  * softwarecenter/db/reviews.py,
    softwarecenter/distro/Ubuntu.py:
    - fallback to ReviewLoaderJsonAsync when we can't use multiprocessing
      (LP: #741069)
    - fixes to make ReviewLoaderJsonAsync 'work' (ie most common cases)
  * softwarecenter/db/update.py:
    - don't import softwarecenter.log
  * softwarecenter/view/appdetailsview_gtk.py:
    - don't draw random boxes when we have an error layout (LP: #739269)
    - retire share button as we now have full microblogging support in the
      review dialog (LP: #592619, LP: #743765)
  * softwarecenter/view/appview.py:
    - correctly refresh listview when supported filters are changed
  * softwarecenter/view/catview.py:
    - if a category has subcategories, then category.query should include all
      items included in the subcategories, not a subset of these
  * softwarecenter/view/widgets/pathbar_gtk_atk.py:
    - avoid having a half-height pathbar (LP: #743614)
  * refresh .pot file

  [ Gary Lasker ]
  * softwarecenter/view/widgets/reviews.py:
    - fix crash if app_version is not defined when
      calling upstream_version_compare (LP: #746120)
  * softwarecenter/view/purchaseview.py:
    - disconnect webkit signal handlers when the webkit view
      is not showing (LP: #696861)
    - support 'user_cancelled' from the software-center-agent
      (LP: #641321)
  * softwarecenter/view/softwarepane.py,
    softwarecenter/view/widgets/actionbar.py:
    - animate the action bar show/hide
  * softwarecenter/view/appview.py:
    - in the AppViewFilter, also consider apps in the for-purchase
      channel as available; this allows them to show up in
      e.g. What's New (LP: #746679)

  [ Michael Vogt ]
  * softwarecenter/db/update.py:
    - ensure the iconname that comes from the software-center-agent
      does not contain a ".", the icon cache gets confused otherwise
  * merged lp:~evfool/software-center/sfix672229, many thanks to
    Robert Roth (LP: #672229)
  * merged lp:~alexeftimie/software-center/fix-704719-briefly-wrong-display,
    many thanks to Alex Eftimie (LP: #704719)
  * softwarecenter/view/purc...

Read more...

Changed in software-center (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers