NoDisplay=true items are added to the launcher after installation

[Niklas Rosenqvist]

[TEST CASE]
1. Launch the current Ubuntu Software Center in Precise.
2. Search for the Deja Dup package.
3. In the list displaying the Deja Dup package, click the "More Info" button.
4. If Deja Dup is installed, click the "Remove" button to uninstall it.
5. Click the "Install" button to install it.
6. Enter the password for the install if prompted.
7: At the very *end* of the installation process (when the progress bar has completed), verify that an icon for DeJa Dup has been added to the Unity launcher.
8. Right click on the Deja Dup icon in the Unity launcher and choose to "Unlock from launcher" to remove it.
9. Close Ubuntu Software Center.
10. Update to both the software-center *and* unity packages in precise-proposed.
11. Repeat steps 1 through 6.
12. This time, at the very *end* of the install process, verify that no icon has been added to the Unity launcher for Deja Dup.

[REGRESSION POTENTIAL]
Risk of regression is very low. Probably the only thing you might watch for would be an unexpected exception reported. If anything like this occurs, of course, please note it in the bug.

---

When I installed GNOME-Shell and the OGRE-SDK both got added to the Launcher, which is ridiculous since none of them can be launched in this manner.

Ubuntu 12.04 x64 Desktop
unity 5.12-0ubuntu1
software-center 5.2.2.1

[Bilal Akhtar (bilalakhtar)]

Software center shouldn't send the AddLauncherIconFromPosition call in these cases

[Gary Lasker (gary-lasker)]

Hi Niklas, and thank you for your report. Could you please tell me the package name for OGRE-SDK? I can't seem to find this in Software Center. Meanwhile, I'll investigate the gnome shell issue.

Thanks for your help!

[Gary Lasker (gary-lasker)]

Hi Nikals, never mind my last request, I believe that I can see the problem from looking at gnome-shell and I have a planned fix, so I will mark this as triaged.

Many thanks for your help!

[Niklas Rosenqvist (niklas-s-rosenqvist)]

Great! Thank you for looking into this! :)

[Matthew Paul Thomas (mpt)]

Specification updated. <https://wiki.ubuntu.com/SoftwareCenter?action=diff&rev2=642&rev1=641>

[Stéphane Graber (stgraber)]

Reverting the precise task to In Porogress, Fix Commited is for packages that are in the -proposed pocket, this package is still in the Unapproved queue.

[Clint Byrum (clint-fewbar)]

Hello Niklas, or anyone else affected,

Accepted software-center into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/software-center/5.2.5 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Niklas Rosenqvist (niklas-s-rosenqvist)]

Do I need to run precise to test the precise-proposed packages?

[Gary Lasker (gary-lasker)]

Hi Niklas, yes, you would need to be running Precise (or, a have a VM image for Precise). Don't worry, I can verify this one now.

Thank you for your help!

Best regards,
Gary

[Gary Lasker (gary-lasker)]

I have verified that software-center version 5.2.5 in precise-proposed fixes this bug per the test case given in the description.

Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package software-center - 5.2.5

---------------
software-center (5.2.5) precise-proposed; urgency=low

  [ Michael Vogt ]
  * lp:~mvo/software-center/fix-lp1009039:
    - fix treeview selection background (LP: #1009039)
  * lp:~mvo/software-center/fix-lp1011522:
    - fix bug where clicking on "Reinstall previous purchases" twice
      shows endless spinner (LP: #1011522)
  * lp:~mvo/software-center/click_url:
    - adds support for a "click_url" from the exhibits banner to
      support banners for things like the humble-bundle where we
      don't have packages but URLs (LP: #1020205)
  * lp:~mvo/software-center/hopefully-fix-lp1008229:
    - fix crash that can happen if there is an error while
      opening a deb file (LP: #1008229)
  * lp:~mvo/software-center/lp1026494:
    - typo fix in the hw description code (LP: #1026494)

  [ Gary Lasker ]
  * lp:~gary-lasker/software-center/unity-launcher-integration-fixes:
    - fix bug where for-purchase items are not being added to the Unity
      launcher (LP: #925014)
    - fix bug where the Unity launcher item for an application incorrectly
      points to its app-install-data desktop file rather than its installed
      desktop file (LP: #999427)
    - fix bug where an application's icon remains in the Unity launcher after
      the corresponding application has been uninstalled (LP: #981488)
    - fix bug where the Unity launcher fails to auto-hide after installation
      of a for-purchase item (LP: #1002440)
    - fix bug where items in the "Independent" section are not being added
      to the Unity launcher (LP: #1012877)
  * lp:~gary-lasker/software-center/tech-items-to-launcher-fix-lp1006483:
    - don't add an item to the launcher if its desktop file specifies
      NoDisplay=true (LP: #1006483)
  * lp:~gary-lasker/software-center/launcher-integration-unit-tests:
   - additional unit tests to round out the suite for the Unity
     launcher integration feature
  * lp:~gary-lasker/software-center/fix-lp969907-for-5.2:
    - fix race condition in _app_activated_cb() (LP: #969907)
 -- Michael Vogt <email address hidden> Mon, 23 Jul 2012 16:38:04 +0200

[Steve Langasek (vorlon)]

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.